Skip to content

Conversation

shunting314
Copy link
Contributor

@shunting314 shunting314 commented Mar 21, 2023

Stack from ghstack (oldest at bottom):

Previous attempt of landing this PR is reverted due to a landrace: #96410 .

The reason is PyCodeCache.load has a new linemap argument being added but my previous PR does not handle it (due to a stale checkout). Fix is trivial.

cc @soumith @voznesenskym @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @desertfire

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 21, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/97215

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b3c5239:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@shunting314
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 21, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 23, 2023
…#97215)

Previous attempt of landing this PR is reverted due to a landrace: pytorch/pytorch#96410 .

The reason is `PyCodeCache.load` has a new linemap argument being added but my previous PR does not handle it (due to a stale checkout). Fix is trivial.

Pull Request resolved: pytorch/pytorch#97215
Approved by: https://github.com/Chillee, https://github.com/jansel
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 27, 2023
…#97215)

Previous attempt of landing this PR is reverted due to a landrace: pytorch/pytorch#96410 .

The reason is `PyCodeCache.load` has a new linemap argument being added but my previous PR does not handle it (due to a stale checkout). Fix is trivial.

Pull Request resolved: pytorch/pytorch#97215
Approved by: https://github.com/Chillee, https://github.com/jansel
@facebook-github-bot facebook-github-bot deleted the gh/shunting314/34/head branch June 8, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants