Uninstall PyTorch after testing on non-ephemeral Windows runners #97285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huydhn
added
ciflow/trunk
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/97285
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 67a287d: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
huydhn
changed the title
seemethere
approved these changes
Mar 22, 2023
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 23, 2023
…285) Per title, I suspect that having a leftover PyTorch built from CUDA 11.7 installed in non-ephemeral Windows runners could cause some flakiness on Windows CUDA 11.8 jobs also running on the same type of runners, for example `win-vs2019-cuda11.8-py3` in https://hud.pytorch.org/pytorch/pytorch/commit/5d3c347bf6f0b86c96a1fe541db5d4f9586c8840 failed with a PATH error: ``` nvrtc: error: failed to open nvrtc-builtins64_117.dll. Make sure that nvrtc-builtins64_117.dll is installed correctly. ``` This also cleans up the dead code about `pytorch_env_restore.bat` under `ci_scripts` temp directory. This directory is cleaned up always by [teardown-win](https://github.com/pytorch/pytorch/blob/master/.github/actions/teardown-win/action.yml#L33). So the bat script will never be there for the next job anyway. As Windows test jobs are doing fine, proving that we don't need this adhoc script anymore. ### Testing https://github.com/pytorch/pytorch/actions/runs/4485931686/jobs/7888513795 Pull Request resolved: pytorch/pytorch#97285 Approved by: https://github.com/seemethere
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 27, 2023
…285) Per title, I suspect that having a leftover PyTorch built from CUDA 11.7 installed in non-ephemeral Windows runners could cause some flakiness on Windows CUDA 11.8 jobs also running on the same type of runners, for example `win-vs2019-cuda11.8-py3` in https://hud.pytorch.org/pytorch/pytorch/commit/5d3c347bf6f0b86c96a1fe541db5d4f9586c8840 failed with a PATH error: ``` nvrtc: error: failed to open nvrtc-builtins64_117.dll. Make sure that nvrtc-builtins64_117.dll is installed correctly. ``` This also cleans up the dead code about `pytorch_env_restore.bat` under `ci_scripts` temp directory. This directory is cleaned up always by [teardown-win](https://github.com/pytorch/pytorch/blob/master/.github/actions/teardown-win/action.yml#L33). So the bat script will never be there for the next job anyway. As Windows test jobs are doing fine, proving that we don't need this adhoc script anymore. ### Testing https://github.com/pytorch/pytorch/actions/runs/4485931686/jobs/7888513795 Pull Request resolved: pytorch/pytorch#97285 Approved by: https://github.com/seemethere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per title, I suspect that having a leftover PyTorch built from CUDA 11.7 installed in non-ephemeral Windows runners could cause some flakiness on Windows CUDA 11.8 jobs also running on the same type of runners, for example
win-vs2019-cuda11.8-py3in https://hud.pytorch.org/pytorch/pytorch/commit/5d3c347bf6f0b86c96a1fe541db5d4f9586c8840 failed with a PATH error:This also cleans up the dead code about
pytorch_env_restore.batunderci_scriptstemp directory. This directory is cleaned up always by teardown-win. So the bat script will never be there for the next job anyway. As Windows test jobs are doing fine, proving that we don't need this adhoc script anymore.Testing
https://github.com/pytorch/pytorch/actions/runs/4485931686/jobs/7888513795