[Dynamo] throw better error message if assert with non-string message #97297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanboliang
commented
Mar 21, 2023
| args = (torch.Tensor([3, 4, 5]),) | ||
| with self.assertRaisesRegex(torch._dynamo.exc.Unsupported, "generic_jump"): | ||
| exported, _ = torch._dynamo.export(f, torch.Tensor([3, 4, 5])) | ||
|
|
There was a problem hiding this comment.
This exception is raised by export not assert, we don't support fstring.
tugsbayasgalan
approved these changes
Mar 21, 2023
yanboliang
added
ciflow/trunk
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 23, 2023
… (#97297) Error message before this PR: ``` torch._dynamo.exc.Unsupported: missing: LOAD_ASSERTION_ERROR ``` After: ``` torch._dynamo.exc.Unsupported: assert with non-string message ``` Pull Request resolved: pytorch/pytorch#97297 Approved by: https://github.com/tugsbayasgalan
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 27, 2023
… (#97297) Error message before this PR: ``` torch._dynamo.exc.Unsupported: missing: LOAD_ASSERTION_ERROR ``` After: ``` torch._dynamo.exc.Unsupported: assert with non-string message ``` Pull Request resolved: pytorch/pytorch#97297 Approved by: https://github.com/tugsbayasgalan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error message before this PR:
After:
cc @soumith @voznesenskym @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @desertfire