Skip to content

Conversation

mcr229
Copy link
Contributor

@mcr229 mcr229 commented Mar 22, 2023

Stack from ghstack (oldest at bottom):

Enabling S8 Operators for quantized Clamp.

This is only for clamp nodes by themselves. I believe once they are fused with the previous node they are no longer needed

Differential Revision: D43901200

NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!

Enabling S8 Operators for quantized Clamp.

This is only for clamp nodes by themselves. I believe once they are fused with the previous node they are no longer needed

Differential Revision: [D43901200](https://our.internmc.facebook.com/intern/diff/D43901200/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D43901200/)!

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 22, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/97386

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 99ecdfc:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

mcr229 added 5 commits March 23, 2023 14:39
Enabling S8 Operators for quantized Clamp.

This is only for clamp nodes by themselves. I believe once they are fused with the previous node they are no longer needed

Differential Revision: [D43901200](https://our.internmc.facebook.com/intern/diff/D43901200/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D43901200/)!

[ghstack-poisoned]
Enabling S8 Operators for quantized Clamp.

This is only for clamp nodes by themselves. I believe once they are fused with the previous node they are no longer needed

Differential Revision: [D43901200](https://our.internmc.facebook.com/intern/diff/D43901200/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D43901200/)!

[ghstack-poisoned]
Enabling S8 Operators for quantized Clamp.

This is only for clamp nodes by themselves. I believe once they are fused with the previous node they are no longer needed

Differential Revision: [D43901200](https://our.internmc.facebook.com/intern/diff/D43901200/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D43901200/)!

[ghstack-poisoned]
Enabling S8 Operators for quantized Clamp.

This is only for clamp nodes by themselves. I believe once they are fused with the previous node they are no longer needed

Differential Revision: [D43901200](https://our.internmc.facebook.com/intern/diff/D43901200/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D43901200/)!

[ghstack-poisoned]
Enabling S8 Operators for quantized Clamp.

This is only for clamp nodes by themselves. I believe once they are fused with the previous node they are no longer needed

Differential Revision: [D43901200](https://our.internmc.facebook.com/intern/diff/D43901200/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D43901200/)!

[ghstack-poisoned]
Copy link
Contributor

@salilsdesai salilsdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mcr229 added 8 commits March 28, 2023 14:40
Enabling S8 Operators for quantized Clamp.

This is only for clamp nodes by themselves. I believe once they are fused with the previous node they are no longer needed

Differential Revision: [D43901200](https://our.internmc.facebook.com/intern/diff/D43901200/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D43901200/)!

[ghstack-poisoned]
Enabling S8 Operators for quantized Clamp.

This is only for clamp nodes by themselves. I believe once they are fused with the previous node they are no longer needed

Differential Revision: [D43901200](https://our.internmc.facebook.com/intern/diff/D43901200/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D43901200/)!

[ghstack-poisoned]
Enabling S8 Operators for quantized Clamp.

This is only for clamp nodes by themselves. I believe once they are fused with the previous node they are no longer needed

Differential Revision: [D43901200](https://our.internmc.facebook.com/intern/diff/D43901200/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D43901200/)!

[ghstack-poisoned]
Enabling S8 Operators for quantized Clamp.

This is only for clamp nodes by themselves. I believe once they are fused with the previous node they are no longer needed

Differential Revision: [D43901200](https://our.internmc.facebook.com/intern/diff/D43901200/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D43901200/)!

[ghstack-poisoned]
Enabling S8 Operators for quantized Clamp.

This is only for clamp nodes by themselves. I believe once they are fused with the previous node they are no longer needed

Differential Revision: [D43901200](https://our.internmc.facebook.com/intern/diff/D43901200/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D43901200/)!

[ghstack-poisoned]
Enabling S8 Operators for quantized Clamp.

This is only for clamp nodes by themselves. I believe once they are fused with the previous node they are no longer needed

Differential Revision: [D43901200](https://our.internmc.facebook.com/intern/diff/D43901200/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D43901200/)!

[ghstack-poisoned]
Enabling S8 Operators for quantized Clamp.

This is only for clamp nodes by themselves. I believe once they are fused with the previous node they are no longer needed

Differential Revision: [D43901200](https://our.internmc.facebook.com/intern/diff/D43901200/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D43901200/)!

[ghstack-poisoned]
Enabling S8 Operators for quantized Clamp.

This is only for clamp nodes by themselves. I believe once they are fused with the previous node they are no longer needed

Differential Revision: [D43901200](https://our.internmc.facebook.com/intern/diff/D43901200/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D43901200/)!

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/mcr229/27/head branch June 8, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants