Skip to content

Conversation

@dagitses
Copy link
Collaborator

remove redundant trailing semicolons in StorageImpl.h

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 27, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/97658

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c50e7bd:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@dagitses dagitses marked this pull request as ready for review March 27, 2023 14:06
@dagitses dagitses added ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category labels Mar 27, 2023
@kit1980
Copy link
Contributor

kit1980 commented Apr 20, 2023

@pytorchbot merge -r

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased pr97658 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout pr97658 && git pull --rebase)

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 20, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@dagitses
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@malfet
Copy link
Contributor

malfet commented Apr 25, 2023

@mikey do you mind changing your email to personal one for this PR?

@dagitses
Copy link
Collaborator Author

@mikey do you mind changing your email to personal one for this PR?

@malfet I can't push to pytorch. But I have updated a branch in my fork. Are you able to change the head ref to the corresponding branch in my fork? https://github.com/dagitses/pytorch/tree/pr97658

@malfet
Copy link
Contributor

malfet commented Apr 25, 2023

@dagitses sent you an invite. If PR has one thing, that should be immutable, is PR head. But you should be able to push the update.

@malfet
Copy link
Contributor

malfet commented Apr 25, 2023

@pytorchbot merge -f "Lint is green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@dagitses dagitses deleted the pr97658 branch April 26, 2023 00:23
@mikey
Copy link

mikey commented Apr 26, 2023

@mikey do you mind changing your email to personal one for this PR?

Wrong git user @malfet ? @mikey is me and I'm not involved in this PR.

@malfet
Copy link
Contributor

malfet commented Apr 26, 2023

Wrong git user @malfet ? @mikey is me and I'm not involved in this PR.

Sorry about the confusion. GitHub sometimes converts first name to the user name, but sometimes fails to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged merging open source topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants