distinguish mutability of untyped Storage::data

[dagitses]

Stack from ghstack (oldest at bottom):

• distinguish mutability of TensorImpl::data() #97776
• make TensorImpl::data_ptr_impl() non-const and have mutable in the name #97744
• add mutable to name of non-const Storage::data_ptr #97694
• -> distinguish mutability of untyped Storage::data #97690

See D44409928.

Differential Revision: D44429769

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/97690

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 19 Failures

As of commit 513ca29:

NEW FAILURES - The following jobs have failed:

• lintrunner (gh)
• linux-bionic-cpu-py3.10-gcc7-bazel-test / build-and-test (gh)
• linux-bionic-cuda11.8-py3.10-gcc7 (gh)
• linux-bionic-cuda11.8-py3.10-gcc7-bazel-test / build-and-test (gh)
• linux-bionic-cuda11.8-py3.10-gcc7-sm86 (gh)
• linux-bionic-py3_8-clang8-xla (gh)
• linux-bionic-py3.11-clang9 (gh)
• linux-bionic-py3.8-clang9 (gh)
• linux-docs (gh)
• linux-focal-py3-clang7-android-ndk-r19c-gradle-custom-build-single / build-and-test (gh)
• linux-focal-py3-clang7-android-ndk-r19c-gradle-custom-build-single-full-jit / build-and-test (gh)
• linux-focal-py3.8-clang10-onnx (gh)
• linux-focal-py3.8-gcc7 (gh)
• linux-focal-py3.9-clang7-asan (gh)
• quick-checks (gh)
• Test tools (gh)
• toc (gh)
• win-vs2019-cpu-py3 (gh)
• workflow-checks (gh)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[dagitses]

@pytorchbot --help

[pytorch-bot]

PyTorchBot Help

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci} ...

In order to invoke the bot on your PR, include a line that starts with
@pytorchbot anywhere in a comment. That line will form the command; no
multi-line commands are allowed. 

Example:
    Some extra context, blah blah, wow this PR looks awesome

    @pytorchbot merge

optional arguments:
  -h, --help            Show this help message and exit.

command:
  {merge,revert,rebase,label,drci}
    merge               Merge a PR
    revert              Revert a PR
    rebase              Rebase a PR
    label               Add label to a PR
    drci                Update Dr. CI

Merge

usage: @pytorchbot merge [-f MESSAGE | -ic] [-r [{viable/strict,master}]]

Merge an accepted PR, subject to the rules in .github/merge_rules.json.
By default, this will wait for all required checks (lint, pull) to succeed before merging.

optional arguments:
  -f MESSAGE, --force MESSAGE
                        Merge without checking anything. This requires a reason for auditting purpose, for example:
                        @pytorchbot merge -f 'Minor update to fix lint. Expecting all PR tests to pass'
  -ic, --ignore-current
                        Merge while ignore the currently failing jobs.  If there are no pending checks, use -f/--force since this will fail.
  -r [{viable/strict,master}], --rebase [{viable/strict,master}]
                        Rebase the PR to re run checks before merging.  Accepts viable/strict or master as branch options and will default to viable/strict if not specified.

Revert

usage: @pytorchbot revert -m MESSAGE -c
                          {nosignal,ignoredsignal,landrace,weird,ghfirst}

Revert a merged PR. This requires that you are a Meta employee.

Example:
  @pytorchbot revert -m="This is breaking tests on trunk. hud.pytorch.org/" -c=nosignal

optional arguments:
  -m MESSAGE, --message MESSAGE
                        The reason you are reverting, will be put in the commit message. Must be longer than 3 words.
  -c {nosignal,ignoredsignal,landrace,weird,ghfirst}, --classification {nosignal,ignoredsignal,landrace,weird,ghfirst}
                        A machine-friendly classification of the revert reason.

Rebase

usage: @pytorchbot rebase [-s | -b BRANCH]

Rebase a PR. Rebasing defaults to the stable viable/strict branch of pytorch.
You must have write permissions to the repo to rebase a PR.

optional arguments:
  -s, --stable          [DEPRECATED] Rebase onto viable/strict
  -b BRANCH, --branch BRANCH
                        Branch you would like to rebase to

Label

usage: @pytorchbot label labels [labels ...]

Adds label to a PR

positional arguments:
  labels  Labels to add to given Pull Request

Dr CI

usage: @pytorchbot drci 

Update Dr. CI. Updates the Dr. CI comment on the PR in case it's gotten out of sync with actual CI results.

[dagitses]

@pytorchbot drci

[facebook-github-bot]

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

[pytorchmergebot]

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here