add support for SymNodeVariable in getitem_const #97756
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/97756
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 26879ef: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]
cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]
cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]
test/inductor/test_torchinductor.py
Outdated
| with self.assertRaises(RuntimeError): | ||
| torch.compile(fn)(a) | ||
|
|
||
| def test_getitem(self): |
There was a problem hiding this comment.
Is it common for both CPU and GPU? If it is common, can you move it outside of CPU repro?
cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]
| from .tensor import SymNodeVariable | ||
|
|
||
| if isinstance(arg, SymNodeVariable): | ||
| index = arg.sym_num |
There was a problem hiding this comment.
@ezyang is this right way to trigger a guard_as_constant on a symint?
There was a problem hiding this comment.
No, but it works out in the end because self.items[index] will call __index__ which will force a guard. You can use arg.evaluate_expr() (idk why it takes an output graph arg, delete that arg lol)
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
7 participants
Stack from ghstack (oldest at bottom):
cc @soumith @voznesenskym @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @desertfire