Inductor cpp wrapper: support dynamic shapes #97965
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/97965
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 25e4554: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]
cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]
cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]
cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]
cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]
cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]
cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]
cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]
1. Fixed dynamic shapes support in cpp_wrapper - fixed the cpp codegen of `size()` and `stride()` - fixed the cpp codegen of `ShapeAsConstantBuffer` - changed to use `cexpr` instead of `pexpr` in the cpp codegen of the `sizevar` 2. Enabled dynamic shapes tests for cpp_wrapper cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]
1. Fixed dynamic shapes support in cpp_wrapper - fixed the cpp codegen of `size()` and `stride()` - fixed the cpp codegen of `ShapeAsConstantBuffer` - changed to use `cexpr` instead of `pexpr` in the cpp codegen of the `sizevar` 2. Enabled dynamic shapes tests for cpp_wrapper cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]
1. Fixed dynamic shapes support in cpp_wrapper - fixed the cpp codegen of `size()` and `stride()` - fixed the cpp codegen of `ShapeAsConstantBuffer` - changed to use `cexpr` instead of `pexpr` in the cpp codegen of the `sizevar` 2. Enabled dynamic shapes tests for cpp_wrapper cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]
1. Fixed dynamic shapes support in cpp_wrapper - fixed the cpp codegen of `size()` and `stride()` - fixed the cpp codegen of `ShapeAsConstantBuffer` - changed to use `cexpr` instead of `pexpr` in the cpp codegen of the `sizevar` 2. Enabled dynamic shapes tests for cpp_wrapper cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]
jgong5
approved these changes
Apr 4, 2023
test/inductor/test_torchinductor.py
Outdated
Comment on lines
1679
to
1681
| def test_int_div(self): | ||
| if self.device == "cuda": | ||
| raise unittest.SkipTest("only support cpu int_div test") |
There was a problem hiding this comment.
If so, consider to move it to CPURepro?
There was a problem hiding this comment.
Moved to CPURepro.
1. Fixed dynamic shapes support in cpp_wrapper - fixed the cpp codegen of `size()` and `stride()` - fixed the cpp codegen of `ShapeAsConstantBuffer` - changed to use `cexpr` instead of `pexpr` in the cpp codegen of the `sizevar` 2. Enabled dynamic shapes tests for cpp_wrapper cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]
1. Fixed dynamic shapes support in cpp_wrapper - fixed the cpp codegen of `size()` and `stride()` - fixed the cpp codegen of `ShapeAsConstantBuffer` - changed to use `cexpr` instead of `pexpr` in the cpp codegen of the `sizevar` 2. Enabled dynamic shapes tests for cpp_wrapper cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]
jansel
approved these changes
Apr 4, 2023
1. Fixed dynamic shapes support in cpp_wrapper - fixed the cpp codegen of `size()` and `stride()` - fixed the cpp codegen of `ShapeAsConstantBuffer` - changed to use `cexpr` instead of `pexpr` in the cpp codegen of the `sizevar` 2. Enabled dynamic shapes tests for cpp_wrapper cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Fixed dynamic shapes support in cpp_wrapper
size()andstride()ShapeAsConstantBuffercexprinstead ofpexprin the cpp codegen of thesizevarEnabled dynamic shapes tests for cpp_wrapper
cc @soumith @voznesenskym @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @desertfire