Skip to content

Conversation

huydhn
Copy link
Contributor

@huydhn huydhn commented Mar 31, 2023

This cleanup some redundant CI jobs that I found:

  • @malfet @ZainRizvi Do we need debug build in periodic for both 11.8 and 11.7? This is rarely needed AFAIK. I try to remove 11.8 here while keep 11.7 to be consistent with the rest of the CI. Or may be it should be the other way around to keep 11.8
  • Remove libtorch 11.7 and 11.8 builds in periodic as it has already been done in trunk
  • Cleanup TSAN (I added this a while back, but there is no drive to go into that further, so let's just kill it) - If you want to keep it, please raise your hand.

🤖 Generated by Copilot at 4b3ec53

This pull request simplifies and consolidates the scripts and workflows for the thread sanitizer (TSAN) build and test configuration. It removes redundant and outdated logic, files, and workflows that were previously used to handle the TSAN build differently from the regular build. It enables all the tests for the TSAN build, which has been fixed by another pull request.

@huydhn huydhn added ciflow/trunk Trigger trunk jobs on your pull request ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR test-config/default labels Mar 31, 2023
@huydhn huydhn requested review from clee2000 and malfet March 31, 2023 00:39
@huydhn huydhn requested a review from a team as a code owner March 31, 2023 00:39
@pytorch-bot pytorch-bot bot added the release notes: releng release notes category label Mar 31, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 31, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/98044

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Failures

As of commit fa210c5:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@huydhn huydhn requested a review from ZainRizvi March 31, 2023 20:40
@ZainRizvi
Copy link
Contributor

It enables all the tests for the TSAN build, which has been fixed by another pull request.

Bad Copilot bot, this is the opposite of what Huy said, lol

@malfet
Copy link
Contributor

malfet commented Apr 3, 2023

I would reduce testing on CUDA-11.7 and move as much as possible toward 11.8 (as 12.1 is coming in 2.1)
The rest looks fine to me

Copy link
Contributor

@ZainRizvi ZainRizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up!

@huydhn
Copy link
Contributor Author

huydhn commented Apr 4, 2023

@pytorchbot merge -f 'Periodic failures on ROCm and benchmark jobs are unrelated'

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: releng release notes category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants