Skip to content

Added allowed_workflows to pytorch probot #98082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Added allowed_workflows to pytorch probot #98082

wants to merge 1 commit into from

Conversation

DanilBaibak
Copy link
Contributor

@DanilBaibak DanilBaibak commented Mar 31, 2023 •
edited
Loading

Added allowed_workflows to pytorch probot. This is a follow up PR regarding the retry bot.

@DanilBaibak DanilBaibak requested a review from a team as a code owner March 31, 2023 14:19
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Mar 31, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 31, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/98082

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 28795d1:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 31, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: DanilBaibak / name: Danylo Baibak (28795d1)

@DanilBaibak DanilBaibak requested a review from malfet March 31, 2023 14:24
huydhn
huydhn approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I really want to also add inductor, but then it's better to do it another day

@DanilBaibak
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 3, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-12-py3-arm64 / build

Details for Dev Infra team Raised by workflow job

@DanilBaibak
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

malfet
malfet reviewed Apr 5, 2023
View reviewed changes
.github/pytorch-probot.yml
- ciflow/periodic
- ciflow/trunk
- ciflow/unstable
allowed_workflows:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be retriable_workflows:

@github-actions github-actions bot deleted the Add-Allowed-Workflows-for-Retry-Bot branch October 1, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet left review comments

@huydhn huydhn huydhn approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DanilBaibak @pytorchmergebot @huydhn @malfet