Skip to content

Conversation

desertfire
Copy link
Contributor

@desertfire desertfire commented Apr 2, 2023

Stack from ghstack (oldest at bottom):

Summary: Remove fp32 training performance run and trade for amp inference
performance run.

Summary: Remove fp32 training performance run and trade for amp inference
performance run.

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Apr 2, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/98174

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 Failures

As of commit 13145b4:

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base 0217982:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

desertfire added a commit that referenced this pull request Apr 2, 2023
Summary: Remove fp32 training performance run and trade for amp inference
performance run.

ghstack-source-id: 391ef42
Pull Request resolved: #98174
@desertfire desertfire added ciflow/inductor topic: not user facing topic category ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR labels Apr 2, 2023
@desertfire desertfire requested review from ezyang and huydhn April 3, 2023 13:05
if [[ "${TEST_CONFIG}" == *perf_compare* ]]; then
test_single_dynamo_benchmark "training" "$suite" "$shard_id" --training --amp "$@"
elif [[ "${TEST_CONFIG}" == *perf* ]]; then
# Performance test training only
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: just remove this comment as this is not the case anymore

Summary: Remove fp32 training performance run and trade for amp inference
performance run.

[ghstack-poisoned]
desertfire added a commit that referenced this pull request Apr 3, 2023
Summary: Remove fp32 training performance run and trade for amp inference
performance run.

ghstack-source-id: d0611a4
Pull Request resolved: #98174
@desertfire
Copy link
Contributor Author

@pytorchbot merge -f "dashboard run has passed. CI failures are irrelevant."

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/desertfire/118/head branch June 8, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR Merged topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants