[c10d] delete lengths offset checks #98368
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to @kewen2501, NCCL supports up to size_t send counts, so PGNCCL shouldn't restrict it A follow up is to think about whether we should add overflow protection of offset [ghstack-poisoned]
wanchaol
requested review from
H-Huang,
awgu,
d4l3k,
fegin,
kiukchung,
kwen2501,
mrshenli,
rohan-varma and
zhaojuanmao
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/98368
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 FailuresAs of commit 9e217c6: BROKEN TRUNK - The following jobs failed but were present on the merge base a6bd21d:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
release notes: distributed (c10d)
According to kwen2501, NCCL supports up to size_t send counts, so PGNCCL shouldn't restrict it A follow up is to think about whether we should add overflow protection of offset [ghstack-poisoned]
kwen2501
approved these changes
Apr 5, 2023
|
@pytorchbot merge -f "The failure is in trunk and not related to this change" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
According to @kwen2501, NCCL supports up to size_t send counts, so
PGNCCL shouldn't restrict it
A follow up is to think about whether we should add overflow protection
of offset