[kineto] add SOFT_ASSERT when logging metdata #98442
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/98442
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 0181ec3: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D44513152 |
aaronenyeshi
approved these changes
Apr 5, 2023
Summary: Pull Request resolved: pytorch#98442 having a valid `kineto_activity_` before logging metadata is a crucial invariant worthy of asserts Test Plan: ## Test with D44362040 Verify that we get SOFT_ASSERT logs before and after the diff ## Log ``` W0329 11:29:34.269824 718148 profiler_kineto.cpp:122] Warning: (function operator()) W0329 11:29:34.270107 718148 profiler_kineto.cpp:122] Warning: (function operator()) W0329 11:29:34.270385 718148 profiler_kineto.cpp:122] Warning: (function operator()) W0329 11:29:34.270653 718148 profiler_kineto.cpp:122] Warning: (function operator()) W0329 11:29:34.270941 718148 profiler_kineto.cpp:122] Warning: (function operator()) W0329 11:29:34.271199 718148 profiler_kineto.cpp:122] Warning: (function operator()) W0329 11:29:34.271476 718148 profiler_kineto.cpp:122] Warning: (function operator()) W0329 11:29:34.271724 718148 profiler_kineto.cpp:122] Warning: (function operator()) W0329 11:29:34.272003 718148 profiler_kineto.cpp:122] Warning: (function operator()) W0329 11:29:34.272280 718148 profiler_kineto.cpp:122] Warning: (function operator()) W0329 11:29:34.272553 718148 profiler_kineto.cpp:122] Warning: (function operator()) W0329 11:29:34.272822 718148 profiler_kineto.cpp:122] Warning: (function operator()) W0329 11:29:34.273092 718148 profiler_kineto.cpp:122] Warning: (function operator()) ``` Reviewed By: aaronenyeshi Differential Revision: D44513152 fbshipit-source-id: 60eb53248290993f3128ad8dc89c55bda58e2691
|
This pull request was exported from Phabricator. Differential Revision: D44513152 |
chaekit
force-pushed
the
export-D44513152
branch
from
93b1302 to
0181ec3
Compare
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: having a valid
kineto_activity_before logging metadata is a crucial invariant worthy of assertsTest Plan:
Test with D44362040
Verify that we get SOFT_ASSERT logs before and after the diff
Log
Reviewed By: aaronenyeshi
Differential Revision: D44513152