Skip to content

Skip test test_triton_bsr_dense_bmm if not TEST_WITH_TORCHINDUCTOR #98462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Skip test test_triton_bsr_dense_bmm if not TEST_WITH_TORCHINDUCTOR #98462

wants to merge 3 commits into from

Conversation

xwang233
Copy link
Collaborator

@xwang233 xwang233 commented Apr 5, 2023

Fixes #ISSUE_NUMBER

@xwang233 xwang233 requested review from malfet and ptrblck April 5, 2023 23:38
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Apr 5, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Apr 5, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/98462

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 2 Pending

As of commit 666760e:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@zou3519 zou3519 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Apr 10, 2023
zou3519
zou3519 approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@zou3519 zou3519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint needs to be fix, otherwise lgtm

@xwang233
Copy link
Collaborator Author

@pytorchmergebot merge -g

@pytorch-bot
Copy link

pytorch-bot bot commented Apr 10, 2023

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: -g

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci} ...

Try @pytorchbot --help for more info.

@xwang233
Copy link
Collaborator Author

@pytorchmergebot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 10, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@xwang233 xwang233 mentioned this pull request May 31, 2023
Closed
pytorchmergebot pushed a commit that referenced this pull request Jun 1, 2023
@xwang233 @pytorchmergebot
Skip test test_triton_bsr_dense_bmm if not TEST_WITH_TORCHINDUCTOR [v…
6340aa5 
…2] (#102660)

Test was originally skipped in #98462

Not sure why it was removed in #94825

Now the test hits CUDA illegal memory access on H100 again after #101163

Pull Request resolved: #102660
Approved by: https://github.com/zou3519
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zou3519 zou3519 zou3519 approved these changes

@malfet malfet Awaiting requested review from malfet

@ptrblck ptrblck Awaiting requested review from ptrblck

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged merging open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xwang233 @pytorchmergebot @zou3519 @pytorchbot