[pt2] add meta functions for cummax and cummin
#98552
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/98552
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ef59b4b: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
[ghstack-poisoned]
nkaretnikov
added
ciflow/trunk
This comment was marked as resolved.
This comment was marked as resolved.
torch/_meta_registrations.py
Outdated
| if self.numel() != 0 and self.ndim != 0: | ||
| # Checks that dim is within bounds | ||
| maybe_wrap_dim(dim, self.ndim) | ||
| return values, indices |
There was a problem hiding this comment.
numel/ndim checks are based on cummax_out
There was a problem hiding this comment.
You can maybe just use the same function for both cummax and cummin?
| if (input.sym_numel() == 0) { | ||
| return input; | ||
| } | ||
| auto result = at::zeros(input.sizes(), input.options()); |
There was a problem hiding this comment.
Required to unlock test/functorch/test_aotdispatch.py
torch/_meta_registrations.py
Outdated
| if self.numel() != 0 and self.ndim != 0: | ||
| # Checks that dim is within bounds | ||
| maybe_wrap_dim(dim, self.ndim) | ||
| return values, indices |
There was a problem hiding this comment.
You can maybe just use the same function for both cummax and cummin?
[ghstack-poisoned]
[ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
4 participants
Stack from ghstack:
cummaxandcummin#98552