Skip to content

Assert that there are not duplicate sources for distinct arguments #98738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Assert that there are not duplicate sources for distinct arguments #98738

wants to merge 2 commits into from

Conversation

@ezyang
Copy link
Contributor

@ezyang ezyang commented Apr 10, 2023 •
edited
Loading

@ezyang
Assert that there are not duplicate sources for distinct arguments
f4f51d8 
Signed-off-by: Edward Z. Yang <ezyang@meta.com>

[ghstack-poisoned]
@ezyang ezyang mentioned this pull request Apr 10, 2023
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Apr 10, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/98738

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a709b4c:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ezyang added a commit that referenced this pull request Apr 10, 2023
@ezyang
Assert that there are not duplicate sources for distinct arguments
01814d4 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: c7c8e66
Pull Request resolved: #98738
albanD
albanD approved these changes Apr 10, 2023
View reviewed changes
torch/_functorch/aot_autograd.py
assert name in mod._param_name_to_source, f"{name} not found."
aot_autograd_arg_pos_to_source.append(mod._param_name_to_source[name])
source = mod._param_name_to_source[name]
assert source not in seen_sources, source
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: better error message?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i plead "this is an assert error we shouldn't hit it ever lol"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're confident this will never happen, I'm good with it!

@albanD albanD added ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category labels Apr 10, 2023
@ezyang
Update on "Assert that there are not duplicate sources for distinct a…
a709b4c 
…rguments"

Signed-off-by: Edward Z. Yang <ezyangmeta.com>

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Apr 10, 2023
@ezyang
Assert that there are not duplicate sources for distinct arguments
971d574 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: 382e172
Pull Request resolved: #98738
@ezyang
Copy link
Contributor Author

ezyang commented Apr 10, 2023

@pytorchbot merge

@ezyang
Copy link
Contributor Author

ezyang commented Apr 10, 2023

Note that @awgu has a test case that trips this assert. I'm landing the assert anyway to help make the ongoing brokenness on master more clear.

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/ezyang/1980/head branch June 8, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

@bdhirsh bdhirsh bdhirsh approved these changes

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@jbschlosser jbschlosser Awaiting requested review from jbschlosser

@miladm miladm Awaiting requested review from miladm

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

@voznesenskym voznesenskym Awaiting requested review from voznesenskym

@wconstab wconstab Awaiting requested review from wconstab

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged merging release notes: AO frontend topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ezyang @pytorchmergebot @albanD @bdhirsh