Remove un-used part of cuda rng state #98787
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/98787
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 25963c7: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
albanD
added
the
suppress-api-compatibility-check
|
@albanD has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
albanD
added
topic: not user facing
ngimel
approved these changes
Apr 11, 2023
|
Unlinked internal and will land now. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment is quite confusing as given the use of
sizeof(), this was never backward compatible as the state is not the same size as it used to be.Running this through CI right now. If it turns our we serialize some rng_state Tensor, I will update the set function to be BC.
cc @ezyang @gchanan