Skip to content

Conversation

awgu
Copy link
Collaborator

@awgu awgu commented Apr 11, 2023

Stack from ghstack (oldest at bottom):

def wrap_tensor(self, value: torch.Tensor):
source = self.get_source()

We already save source = self.get_source() to begin wrap_tensor(). Since the source should be fixed at VariableBuilder construction time, we should be okay to reuse the source variable instead of calling get_source() every time.

cc @soumith @voznesenskym @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @desertfire

@pytorch-bot
Copy link

pytorch-bot bot commented Apr 11, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/98845

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 2fab289:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

awgu pushed a commit that referenced this pull request Apr 11, 2023
ghstack-source-id: 7130c95
Pull Request resolved: #98845
@awgu awgu added the topic: not user facing topic category label Apr 11, 2023
@awgu awgu marked this pull request as ready for review April 11, 2023 16:09
@awgu awgu requested a review from ezyang April 11, 2023 17:57
@awgu awgu added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 11, 2023
@awgu
Copy link
Collaborator Author

awgu commented Apr 11, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants