[dynamo] Remove _dynamo.skip and fold it in _dynamo.disable #98899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/98899
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit c9eb760: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Summary There is confusion between`_dynamo.skip` and `_dynamo.disable`. This removes the `_dynamo.skip` API. The functionality is still available via `_dynamo.disable(recursive=False)` cc soumith voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
jansel
reviewed
Apr 12, 2023
Comment on lines
+966
to
+973
| if recursive: | ||
| if fn is not None: | ||
| fn = innermost_fn(fn) | ||
| assert callable(fn) | ||
| return DisableContext()(fn) | ||
| return DisableContext() | ||
| else: | ||
| return skip(fn) |
There was a problem hiding this comment.
Suggested change
| if recursive: | |
| if fn is not None: | |
| fn = innermost_fn(fn) | |
| assert callable(fn) | |
| return DisableContext()(fn) | |
| return DisableContext() | |
| else: | |
| return skip(fn) | |
| if recursive: | |
| if fn is not None: | |
| fn = innermost_fn(fn) | |
| assert callable(fn) | |
| return DisableContext()(fn) | |
| return DisableContext() | |
| else: | |
| if fn is None: | |
| return functools.partial(disable, recursive=recursive) | |
| return skip(fn) |
to allow decorator syntax.
There was a problem hiding this comment.
The skip function internally handles the decorator syntax as well. Let me know if you still want the change though.
jansel
approved these changes
Apr 12, 2023
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary
There is confusion between
_dynamo.skipand_dynamo.disable. This removes the_dynamo.skipAPI. The functionality is still available via_dynamo.disable(recursive=False)cc @soumith @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @desertfire