[PT2E][Quant] Support for embedding op quantization via ExecuTorchNativeQuantizer #99106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ExecuTorchNativeQuantizer ExecuTorchNativeQuantizer is a terribly name, I admit, however lets fix it once we align on what the quantized kernel lib within executorch runtime should be called Differential Revision: [D44986258](https://our.internmc.facebook.com/intern/diff/D44986258/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D44986258/)! [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/99106
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 Failures, 1 PendingAs of commit 1478bb7: NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Apr 13, 2023
kimishpatel
added a commit
that referenced
this pull request
Apr 13, 2023
ExecuTorchNativeQuantizer ExecuTorchNativeQuantizer is a terribly name, I admit, however lets fix it once we align on what the quantized kernel lib within executorch runtime should be called Differential Revision: [D44986258](https://our.internmc.facebook.com/intern/diff/D44986258/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D44986258/)! ghstack-source-id: 186076652 Pull Request resolved: #99106
ExecuTorchNativeQuantizer" ExecuTorchNativeQuantizer ExecuTorchNativeQuantizer is a terribly name, I admit, however lets fix it once we align on what the quantized kernel lib within executorch runtime should be called Differential Revision: [D44986258](https://our.internmc.facebook.com/intern/diff/D44986258/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D44986258/)! [ghstack-poisoned]
ExecuTorchNativeQuantizer" ExecuTorchNativeQuantizer ExecuTorchNativeQuantizer is a terribly name, I admit, however lets fix it once we align on what the quantized kernel lib within executorch runtime should be called Differential Revision: [D44986258](https://our.internmc.facebook.com/intern/diff/D44986258/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D44986258/)! [ghstack-poisoned]
ExecuTorchNativeQuantizer" ExecuTorchNativeQuantizer ExecuTorchNativeQuantizer is a terribly name, I admit, however lets fix it once we align on what the quantized kernel lib within executorch runtime should be called Differential Revision: [D44986258](https://our.internmc.facebook.com/intern/diff/D44986258/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D44986258/)! [ghstack-poisoned]
jerryzh168
approved these changes
Apr 14, 2023
ExecuTorchNativeQuantizer" ExecuTorchNativeQuantizer ExecuTorchNativeQuantizer is a terribly name, I admit, however lets fix it once we align on what the quantized kernel lib within executorch runtime should be called Differential Revision: [D44986258](https://our.internmc.facebook.com/intern/diff/D44986258/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D44986258/)! [ghstack-poisoned]
ExecuTorchNativeQuantizer" ExecuTorchNativeQuantizer ExecuTorchNativeQuantizer is a terribly name, I admit, however lets fix it once we align on what the quantized kernel lib within executorch runtime should be called Differential Revision: [D44986258](https://our.internmc.facebook.com/intern/diff/D44986258/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D44986258/)! [ghstack-poisoned]
ExecuTorchNativeQuantizer" ExecuTorchNativeQuantizer ExecuTorchNativeQuantizer is a terribly name, I admit, however lets fix it once we align on what the quantized kernel lib within executorch runtime should be called Differential Revision: [D44986258](https://our.internmc.facebook.com/intern/diff/D44986258/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D44986258/)! [ghstack-poisoned]
ExecuTorchNativeQuantizer" ExecuTorchNativeQuantizer ExecuTorchNativeQuantizer is a terribly name, I admit, however lets fix it once we align on what the quantized kernel lib within executorch runtime should be called Differential Revision: [D44986258](https://our.internmc.facebook.com/intern/diff/D44986258/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D44986258/)! [ghstack-poisoned]
ExecuTorchNativeQuantizer" ExecuTorchNativeQuantizer ExecuTorchNativeQuantizer is a terribly name, I admit, however lets fix it once we align on what the quantized kernel lib within executorch runtime should be called Differential Revision: [D44986258](https://our.internmc.facebook.com/intern/diff/D44986258/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D44986258/)! [ghstack-poisoned]
kimishpatel
added a commit
that referenced
this pull request
Apr 15, 2023
ExecuTorchNativeQuantizer Pull Request resolved: #99106 ExecuTorchNativeQuantizer is a terribly name, I admit, however lets fix it once we align on what the quantized kernel lib within executorch runtime should be called ghstack-source-id: 186213421 Differential Revision: [D44986258](https://our.internmc.facebook.com/intern/diff/D44986258/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D44986258/)!
ExecuTorchNativeQuantizer" ExecuTorchNativeQuantizer ExecuTorchNativeQuantizer is a terribly name, I admit, however lets fix it once we align on what the quantized kernel lib within executorch runtime should be called Differential Revision: [D44986258](https://our.internmc.facebook.com/intern/diff/D44986258/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D44986258/)! [ghstack-poisoned]
kimishpatel
added a commit
that referenced
this pull request
Apr 15, 2023
ExecuTorchNativeQuantizer Pull Request resolved: #99106 ExecuTorchNativeQuantizer is a terribly name, I admit, however lets fix it once we align on what the quantized kernel lib within executorch runtime should be called ghstack-source-id: 186225181 Differential Revision: [D44986258](https://our.internmc.facebook.com/intern/diff/D44986258/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D44986258/)!
|
diff hasnt landed and linter fix is not yes upstreamed so dont merge it yet |
ExecuTorchNativeQuantizer" ExecuTorchNativeQuantizer ExecuTorchNativeQuantizer is a terribly name, I admit, however lets fix it once we align on what the quantized kernel lib within executorch runtime should be called Differential Revision: [D44986258](https://our.internmc.facebook.com/intern/diff/D44986258/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D44986258/)! [ghstack-poisoned]
This was referenced Apr 18, 2023
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
ExecuTorchNativeQuantizer
ExecuTorchNativeQuantizer is a terribly name, I admit, however lets fix it once
we align on what the quantized kernel lib within executorch runtime should be called
Differential Revision: D44986258
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!