[inductor] Update triton pin #99209
Closed
[inductor] Update triton pin #99209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`triton.testing.do_bench` on master has a new signature with different default behaviour. This updates our users and adds a small wrapper `run_benchmark` so we can uniformly decide what metric to use. Here I've kept median for BC, while triton has changed to mean. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/99209
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 3 FailuresAs of commit b212bb8: NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
peterbell10
added a commit
that referenced
this pull request
Apr 14, 2023
`triton.testing.do_bench` on master has a new signature with different default behaviour. This updates our users and adds a small wrapper `run_benchmark` so we can uniformly decide what metric to use. Here I've kept median for BC, while triton has changed to mean. ghstack-source-id: f69224c Pull Request resolved: #99209
github-actions
bot
added
ciflow/inductor
ciflow/trunk
|
#99216 adapts inductor do_bench to triton changes. |
|
Previous pin update fails due to #98728 (comment) |
`triton.testing.do_bench` on master has a new signature with different default behaviour. This updates our users and adds a small wrapper `run_benchmark` so we can uniformly decide what metric to use. Here I've kept median for BC, while triton has changed to mean. cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
`triton.testing.do_bench` on master has a new signature with different default behaviour. This updates our users and adds a small wrapper `run_benchmark` so we can uniformly decide what metric to use. Here I've kept median for BC, while triton has changed to mean. cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
`triton.testing.do_bench` on master has a new signature with different default behaviour. This updates our users and adds a small wrapper `run_benchmark` so we can uniformly decide what metric to use. Here I've kept median for BC, while triton has changed to mean. cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
`triton.testing.do_bench` on master has a new signature with different default behaviour. This updates our users and adds a small wrapper `run_benchmark` so we can uniformly decide what metric to use. Here I've kept median for BC, while triton has changed to mean. cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
`triton.testing.do_bench` on master has a new signature with different default behaviour. This updates our users and adds a small wrapper `run_benchmark` so we can uniformly decide what metric to use. Here I've kept median for BC, while triton has changed to mean. cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
peterbell10
added a commit
to peterbell10/pytorch
that referenced
this pull request
Apr 19, 2023
ghstack-source-id: e951fba Pull Request resolved: pytorch#99209
ngimel
approved these changes
Apr 20, 2023
`triton.testing.do_bench` on master has a new signature with different default behaviour. This updates our users and adds a small wrapper `run_benchmark` so we can uniformly decide what metric to use. Here I've kept median for BC, while triton has changed to mean. cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
This was referenced Apr 20, 2023
peterbell10
requested review from
Chillee,
desertfire,
eellison and
shunting314
as code owners
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_8-cuda12_1-test / test Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge -f "dynamo failure is pre-existing" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
cc @soumith @voznesenskym @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @desertfire