Skip to content

Add an expect test for test_save_graph_repro #99538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Add an expect test for test_save_graph_repro #99538

wants to merge 5 commits into from

Conversation

@ezyang
Copy link
Contributor

@ezyang ezyang commented Apr 19, 2023 •
edited
Loading

@ezyang
Add an expect test for test_save_graph_repro
4bdb537 
Signed-off-by: Edward Z. Yang <ezyang@meta.com>

[ghstack-poisoned]
@ezyang ezyang mentioned this pull request Apr 19, 2023
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Apr 19, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/99538

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 Failures

As of commit 6eb0810:

BROKEN TRUNK - The following jobs failed but were present on the merge base c67c16b:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Apr 19, 2023
Closed
Closed
Closed
Closed
@github-actions github-actions bot requested a review from wconstab April 19, 2023 15:31
@github-actions
Copy link
Contributor

This PR needs a label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@ezyang ezyang added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 19, 2023
@ezyang
Update on "Add an expect test for test_save_graph_repro"
3383cfa 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire

[ghstack-poisoned]
@ezyang
Update on "Add an expect test for test_save_graph_repro"
4a822d1 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire

[ghstack-poisoned]
@ezyang
Update on "Add an expect test for test_save_graph_repro"
94b0d21 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire

[ghstack-poisoned]
anijain2305
anijain2305 reviewed Apr 19, 2023
View reviewed changes
test/dynamo/test_after_aot.py
assert not torch.cuda.is_initialized()

def test_save_graph_repro(self):
return
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover?

anijain2305
anijain2305 approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@anijain2305 anijain2305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the return! lgtm

@ezyang
Update on "Add an expect test for test_save_graph_repro"
6eb0810 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Apr 19, 2023
@ezyang
Add an expect test for test_save_graph_repro
8597204 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: d714e0e
Pull Request resolved: #99538
@albanD albanD removed their request for review April 19, 2023 19:50
@ezyang
Copy link
Contributor Author

ezyang commented Apr 19, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@ezyang ezyang mentioned this pull request Apr 19, 2023
Closed
@ezyang
Copy link
Contributor Author

ezyang commented Apr 19, 2023

@pytorchbot merge -f "test failure is spurious"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@huydhn huydhn mentioned this pull request Apr 20, 2023
Closed
@facebook-github-bot facebook-github-bot deleted the gh/ezyang/2017/head branch June 8, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anijain2305 anijain2305 anijain2305 approved these changes

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

@jbschlosser jbschlosser Awaiting requested review from jbschlosser

@miladm miladm Awaiting requested review from miladm

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

@voznesenskym voznesenskym Awaiting requested review from voznesenskym

@wconstab wconstab Awaiting requested review from wconstab

@mlazos mlazos Awaiting requested review from mlazos

@Chillee Chillee Awaiting requested review from Chillee

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ezyang @pytorchmergebot @anijain2305