Skip to content

[combined tracebacks] missing gil acquire #99685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[combined tracebacks] missing gil acquire #99685

wants to merge 1 commit into from

Conversation

@zdevito
Copy link
Contributor

@zdevito zdevito commented Apr 21, 2023 •
edited
Loading

Stack from ghstack (oldest at bottom):

When this code was refactored, the GIL for appendSymbolized
was dropped accidentally.

@zdevito
[combined tracebacks] missing gil acquire
823d3b3 
When this code was refactored, the GIL for appendSymbolized
was dropped accidentally.

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Apr 21, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/99685

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 823d3b3:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

zdevito added a commit that referenced this pull request Apr 21, 2023
@zdevito
[combined tracebacks] missing gil acquire
66784ea 
When this code was refactored, the GIL for appendSymbolized
was dropped accidentally.

ghstack-source-id: 7da75dd
Pull Request resolved: #99685
@zdevito zdevito requested a review from davidberard98 April 21, 2023 02:31
@zdevito zdevito added the topic: not user facing topic category label Apr 21, 2023
davidberard98
davidberard98 approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@davidberard98 davidberard98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! tested it and verified that it fixes combined tracebacks in my use case

@zdevito
Copy link
Contributor Author

zdevito commented Apr 21, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 21, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/zdevito/236/head branch June 8, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@davidberard98 davidberard98 davidberard98 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged merging topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zdevito @pytorchmergebot @davidberard98