Skip to content

Conversation

dirkgr
Copy link
Contributor

@dirkgr dirkgr commented Apr 22, 2023

It looks like passing *args and **kwargs to checkpoint_wrapper() does not work because someone forgot some *s. This adds them back in.

@pytorch-bot
Copy link

pytorch-bot bot commented Apr 22, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/99791

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure

As of commit e19332e:

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 22, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: dirkgr / name: Dirk Groeneveld (3e69a32)

@awgu
Copy link
Collaborator

awgu commented Apr 22, 2023

Good catch! Let us see how CI responds in case we need to adjust any unit tests (that might have been passing due to the args/kwargs not propagating).

@awgu
Copy link
Collaborator

awgu commented Apr 23, 2023

@dirkgr Could you sign the CLA?

@awgu awgu added ciflow/trunk Trigger trunk jobs on your pull request topic: bug fixes topic category labels Apr 23, 2023
@dirkgr
Copy link
Contributor Author

dirkgr commented Apr 23, 2023

I sent it to my manager. I assume he'll sign it on Monday.

@mikaylagawarecki mikaylagawarecki added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Apr 25, 2023
@dirkgr
Copy link
Contributor Author

dirkgr commented May 1, 2023

It is done.

@kit1980
Copy link
Contributor

kit1980 commented May 3, 2023

If nothing on the CI fails after the change, then it would be really nice to add a test for this.

@awgu
Copy link
Collaborator

awgu commented May 3, 2023

#100576

@awgu
Copy link
Collaborator

awgu commented May 3, 2023

@pytorchbot merge

@pytorch-bot
Copy link

pytorch-bot bot commented May 3, 2023

This PR needs to be approved by an authorized maintainer before merge.

@awgu
Copy link
Collaborator

awgu commented May 3, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@awgu awgu added the topic: not user facing topic category label May 3, 2023
@awgu
Copy link
Collaborator

awgu commented May 3, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR is too stale; the last push date was more than 3 days ago. Please rebase and try again. You can rebase and merge by leaving the following comment on this PR:
@pytorchbot merge -r
Or just rebase by leaving @pytorchbot rebase comment

Details for Dev Infra team Raised by workflow job

@awgu
Copy link
Collaborator

awgu commented May 3, 2023

@pytorchbot merge -r

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased CheckpointWrapperKwargs onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout CheckpointWrapperKwargs && git pull --rebase)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@kit1980
Copy link
Contributor

kit1980 commented May 3, 2023

@pytorchbot merge -ic

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 1 checks: pull / win-vs2019-cpu-py3 / build

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: bug fixes topic category topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants