Skip to content

[BUG] Incorrect default value for normalize_advantage. #2049

@DobromirM

Description

@DobromirM

Describe the bug

The default value of normalize_advantage in ClipPPOLoss and KLPENPPOLoss is set to True even though the documentation states that it should be False.
The base class PPOLoss uses the correct default value.

Expected behavior

Change the default value to False to match the documentation and the base class.

Checklist

  • I have checked that there is no similar issue in the repo (required)
  • I have read the documentation (required)

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions