[Feature Request] Remove duplicated code from /examples

[acforvs]

Motivation

Hi, this is a small suggestion to refactor the code in the examples directory.

The reason for it is that different examples have a lot of code in common (see here, here and here for the examples). I guess this small change would increase the readability

Solution

I would suggest to create a utils.py file inside the examples dir and put the duplicated code here. For instance, for the logging example described above we could simply create get_logger(cfg: "DictConfig") function and import it inside examples if needed

Alternatives

Do nothing and close this issue :)

Additional context

If it seems as an OK improvement I would be able to create a PR and address this issue. Please let me know what you think!

Checklist

• I have checked that there is no similar issue in the repo (required)

[vmoens]

Hi @acforvs

The spirit of the training scripts as they are now is certainly to reduce the duplicated code as much as can be, especially if it does not bring any additional value to the library (e.g. in terms of usage instruction for instance).
As such I'd be in favour of deduplicating the code.
If you'd like to work on this I'd be very supportive!

cc @albertbou92

[acforvs]

Hi @vmoens

Thanks for getting back to me! I've just uploaded a PR that introduces a deduplication for the logger creation part

[vmoens]

Cool!
You may want to sync with main, we just landed some changes in the training scripts #715