Skip to content

[Refactor] Use filter_empty=True in apply #1879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2024
Merged

[Refactor] Use filter_empty=True in apply #1879

merged 1 commit into from
Feb 6, 2024

Conversation

@vmoens
Copy link
Collaborator

@vmoens vmoens commented Feb 6, 2024 •
edited
Loading

No description provided.

@pytorch-bot
Copy link

pytorch-bot bot commented Feb 6, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/1879

Note: Links to docs will display an error until the docs builds have been completed.

❌ 7 New Failures, 5 Unrelated Failures

As of commit e51edbf with merge base ff3a350 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 6, 2024
@github-actions
Copy link

github-actions bot commented Feb 6, 2024

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 89. Improved: $\large\color{#35bf28}3$. Worsened: $\large\color{#d91a1a}4$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1370s 65.5198ms 15.2626 Ops/s 16.3111 Ops/s $\textbf{\color{#d91a1a}-6.43\%}$
test_sync 36.8212ms 32.8580ms 30.4340 Ops/s 27.7268 Ops/s $\textbf{\color{#35bf28}+9.76\%}$
test_async 0.1227s 32.2529ms 31.0050 Ops/s 30.7150 Ops/s $\color{#35bf28}+0.94\%$
test_simple 0.4868s 0.4245s 2.3560 Ops/s 2.3648 Ops/s $\color{#d91a1a}-0.37\%$
test_transformed 0.6391s 0.5866s 1.7048 Ops/s 1.7140 Ops/s $\color{#d91a1a}-0.54\%$
test_serial 1.4511s 1.3916s 0.7186 Ops/s 0.7187 Ops/s $-0.01\%$
test_parallel 1.4308s 1.3649s 0.7326 Ops/s 0.7259 Ops/s $\color{#35bf28}+0.93\%$
test_step_mdp_speed[True-True-True-True-True] 0.1573ms 21.3287μs 46.8853 KOps/s 47.6553 KOps/s $\color{#d91a1a}-1.62\%$
test_step_mdp_speed[True-True-True-True-False] 41.8480μs 13.0882μs 76.4045 KOps/s 78.7605 KOps/s $\color{#d91a1a}-2.99\%$
test_step_mdp_speed[True-True-True-False-True] 34.7340μs 12.7163μs 78.6390 KOps/s 81.1338 KOps/s $\color{#d91a1a}-3.07\%$
test_step_mdp_speed[True-True-True-False-False] 42.7550μs 7.5519μs 132.4175 KOps/s 134.1891 KOps/s $\color{#d91a1a}-1.32\%$
test_step_mdp_speed[True-True-False-True-True] 57.1460μs 22.5599μs 44.3265 KOps/s 45.0027 KOps/s $\color{#d91a1a}-1.50\%$
test_step_mdp_speed[True-True-False-True-False] 31.0080μs 14.2251μs 70.2983 KOps/s 72.2000 KOps/s $\color{#d91a1a}-2.63\%$
test_step_mdp_speed[True-True-False-False-True] 72.7700μs 13.8086μs 72.4186 KOps/s 74.1952 KOps/s $\color{#d91a1a}-2.39\%$
test_step_mdp_speed[True-True-False-False-False] 28.8140μs 8.9576μs 111.6368 KOps/s 116.1420 KOps/s $\color{#d91a1a}-3.88\%$
test_step_mdp_speed[True-False-True-True-True] 69.1350μs 24.0198μs 41.6324 KOps/s 41.9456 KOps/s $\color{#d91a1a}-0.75\%$
test_step_mdp_speed[True-False-True-True-False] 66.4940μs 15.8547μs 63.0728 KOps/s 65.0567 KOps/s $\color{#d91a1a}-3.05\%$
test_step_mdp_speed[True-False-True-False-True] 70.7660μs 13.7565μs 72.6927 KOps/s 72.9881 KOps/s $\color{#d91a1a}-0.40\%$
test_step_mdp_speed[True-False-True-False-False] 53.7560μs 8.8945μs 112.4292 KOps/s 115.6838 KOps/s $\color{#d91a1a}-2.81\%$
test_step_mdp_speed[True-False-False-True-True] 62.9270μs 25.1960μs 39.6888 KOps/s 40.0219 KOps/s $\color{#d91a1a}-0.83\%$
test_step_mdp_speed[True-False-False-True-False] 61.4940μs 16.7506μs 59.6994 KOps/s 60.4668 KOps/s $\color{#d91a1a}-1.27\%$
test_step_mdp_speed[True-False-False-False-True] 36.6480μs 14.9176μs 67.0351 KOps/s 67.6975 KOps/s $\color{#d91a1a}-0.98\%$
test_step_mdp_speed[True-False-False-False-False] 45.7250μs 10.0166μs 99.8338 KOps/s 100.8543 KOps/s $\color{#d91a1a}-1.01\%$
test_step_mdp_speed[False-True-True-True-True] 58.2090μs 24.1773μs 41.3610 KOps/s 41.9072 KOps/s $\color{#d91a1a}-1.30\%$
test_step_mdp_speed[False-True-True-True-False] 60.3460μs 15.5638μs 64.2517 KOps/s 64.4148 KOps/s $\color{#d91a1a}-0.25\%$
test_step_mdp_speed[False-True-True-False-True] 55.4490μs 15.8903μs 62.9316 KOps/s 62.8984 KOps/s $\color{#35bf28}+0.05\%$
test_step_mdp_speed[False-True-True-False-False] 31.8700μs 10.1137μs 98.8756 KOps/s 101.3036 KOps/s $\color{#d91a1a}-2.40\%$
test_step_mdp_speed[False-True-False-True-True] 37.1090μs 25.7918μs 38.7720 KOps/s 40.1436 KOps/s $\color{#d91a1a}-3.42\%$
test_step_mdp_speed[False-True-False-True-False] 64.7710μs 16.8927μs 59.1971 KOps/s 60.2981 KOps/s $\color{#d91a1a}-1.83\%$
test_step_mdp_speed[False-True-False-False-True] 39.2830μs 17.2021μs 58.1323 KOps/s 59.0023 KOps/s $\color{#d91a1a}-1.47\%$
test_step_mdp_speed[False-True-False-False-False] 53.5500μs 11.1699μs 89.5267 KOps/s 90.4248 KOps/s $\color{#d91a1a}-0.99\%$
test_step_mdp_speed[False-False-True-True-True] 74.9600μs 26.6437μs 37.5323 KOps/s 37.9577 KOps/s $\color{#d91a1a}-1.12\%$
test_step_mdp_speed[False-False-True-True-False] 45.9350μs 18.1375μs 55.1343 KOps/s 55.7165 KOps/s $\color{#d91a1a}-1.04\%$
test_step_mdp_speed[False-False-True-False-True] 48.2490μs 17.1640μs 58.2614 KOps/s 55.5761 KOps/s $\color{#35bf28}+4.83\%$
test_step_mdp_speed[False-False-True-False-False] 38.0810μs 11.2604μs 88.8071 KOps/s 90.2924 KOps/s $\color{#d91a1a}-1.65\%$
test_step_mdp_speed[False-False-False-True-True] 75.2700μs 27.3844μs 36.5171 KOps/s 36.8392 KOps/s $\color{#d91a1a}-0.87\%$
test_step_mdp_speed[False-False-False-True-False] 94.0440μs 19.0533μs 52.4844 KOps/s 52.8093 KOps/s $\color{#d91a1a}-0.62\%$
test_step_mdp_speed[False-False-False-False-True] 43.2610μs 18.2656μs 54.7478 KOps/s 55.5594 KOps/s $\color{#d91a1a}-1.46\%$
test_step_mdp_speed[False-False-False-False-False] 48.4400μs 12.3180μs 81.1821 KOps/s 82.3295 KOps/s $\color{#d91a1a}-1.39\%$
test_values[generalized_advantage_estimate-True-True] 9.6905ms 9.2834ms 107.7192 Ops/s 107.9182 Ops/s $\color{#d91a1a}-0.18\%$
test_values[vec_generalized_advantage_estimate-True-True] 36.9194ms 35.5067ms 28.1637 Ops/s 28.8935 Ops/s $\color{#d91a1a}-2.53\%$
test_values[td0_return_estimate-False-False] 0.2341ms 0.1651ms 6.0581 KOps/s 5.7566 KOps/s $\textbf{\color{#35bf28}+5.24\%}$
test_values[td1_return_estimate-False-False] 24.7599ms 22.8155ms 43.8299 Ops/s 43.5409 Ops/s $\color{#35bf28}+0.66\%$
test_values[vec_td1_return_estimate-False-False] 38.4074ms 35.2603ms 28.3605 Ops/s 29.7355 Ops/s $\color{#d91a1a}-4.62\%$
test_values[td_lambda_return_estimate-True-False] 33.5490ms 33.0003ms 30.3028 Ops/s 30.0465 Ops/s $\color{#35bf28}+0.85\%$
test_values[vec_td_lambda_return_estimate-True-False] 37.4139ms 35.4440ms 28.2135 Ops/s 29.1671 Ops/s $\color{#d91a1a}-3.27\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 15.4849ms 8.5589ms 116.8374 Ops/s 125.3001 Ops/s $\textbf{\color{#d91a1a}-6.75\%}$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.2480ms 1.9555ms 511.3704 Ops/s 521.0677 Ops/s $\color{#d91a1a}-1.86\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.5055ms 0.3524ms 2.8374 KOps/s 2.9342 KOps/s $\color{#d91a1a}-3.30\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 44.0637ms 41.1484ms 24.3023 Ops/s 22.8649 Ops/s $\textbf{\color{#35bf28}+6.29\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 3.1127ms 3.0132ms 331.8757 Ops/s 330.5104 Ops/s $\color{#35bf28}+0.41\%$
test_dqn_speed 80.7291ms 6.5332ms 153.0651 Ops/s 154.0892 Ops/s $\color{#d91a1a}-0.66\%$
test_ddpg_speed 12.9010ms 11.5502ms 86.5784 Ops/s 83.0487 Ops/s $\color{#35bf28}+4.25\%$
test_sac_speed 24.3207ms 23.4346ms 42.6720 Ops/s 41.2848 Ops/s $\color{#35bf28}+3.36\%$
test_redq_speed 0.1032s 15.1157ms 66.1565 Ops/s 69.5078 Ops/s $\color{#d91a1a}-4.82\%$
test_redq_deprec_speed 23.4940ms 22.3963ms 44.6502 Ops/s 44.2769 Ops/s $\color{#35bf28}+0.84\%$
test_td3_speed 30.5391ms 16.7531ms 59.6905 Ops/s 59.0548 Ops/s $\color{#35bf28}+1.08\%$
test_cql_speed 75.9705ms 74.8224ms 13.3650 Ops/s 13.6058 Ops/s $\color{#d91a1a}-1.77\%$
test_a2c_speed 26.6575ms 22.3914ms 44.6601 Ops/s 45.5519 Ops/s $\color{#d91a1a}-1.96\%$
test_ppo_speed 25.1457ms 22.6147ms 44.2191 Ops/s 45.0651 Ops/s $\color{#d91a1a}-1.88\%$
test_reinforce_speed 23.6402ms 21.3299ms 46.8824 Ops/s 46.8986 Ops/s $\color{#d91a1a}-0.03\%$
test_iql_speed 59.0244ms 57.0746ms 17.5209 Ops/s 17.9294 Ops/s $\color{#d91a1a}-2.28\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.2947ms 2.9261ms 341.7491 Ops/s 369.5348 Ops/s $\textbf{\color{#d91a1a}-7.52\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.8261ms 0.5039ms 1.9845 KOps/s 2.0149 KOps/s $\color{#d91a1a}-1.51\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.5941ms 0.4754ms 2.1034 KOps/s 2.1194 KOps/s $\color{#d91a1a}-0.76\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.0953ms 2.8105ms 355.8035 Ops/s 368.0724 Ops/s $\color{#d91a1a}-3.33\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.8706ms 0.5000ms 1.9999 KOps/s 2.0320 KOps/s $\color{#d91a1a}-1.58\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7636ms 0.4785ms 2.0897 KOps/s 2.1352 KOps/s $\color{#d91a1a}-2.13\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.7800ms 2.5638ms 390.0479 Ops/s 407.3768 Ops/s $\color{#d91a1a}-4.25\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8744ms 0.6232ms 1.6047 KOps/s 1.6369 KOps/s $\color{#d91a1a}-1.97\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.7580ms 0.5925ms 1.6876 KOps/s 1.7147 KOps/s $\color{#d91a1a}-1.58\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 4.0672ms 2.8675ms 348.7387 Ops/s 366.4425 Ops/s $\color{#d91a1a}-4.83\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.8510ms 0.5122ms 1.9522 KOps/s 1.9845 KOps/s $\color{#d91a1a}-1.62\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.9036ms 0.4858ms 2.0586 KOps/s 2.0837 KOps/s $\color{#d91a1a}-1.20\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.6705ms 2.9321ms 341.0469 Ops/s 358.8198 Ops/s $\color{#d91a1a}-4.95\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.6451ms 0.5042ms 1.9832 KOps/s 2.0154 KOps/s $\color{#d91a1a}-1.60\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7669ms 0.4847ms 2.0633 KOps/s 2.1144 KOps/s $\color{#d91a1a}-2.42\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.0000ms 2.5649ms 389.8859 Ops/s 401.0935 Ops/s $\color{#d91a1a}-2.79\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.0174ms 0.6208ms 1.6107 KOps/s 1.6185 KOps/s $\color{#d91a1a}-0.48\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.9260ms 0.6027ms 1.6591 KOps/s 1.7070 KOps/s $\color{#d91a1a}-2.81\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.2152s 12.5894ms 79.4322 Ops/s 124.4058 Ops/s $\textbf{\color{#d91a1a}-36.15\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 15.6545ms 13.2147ms 75.6733 Ops/s 76.1186 Ops/s $\color{#d91a1a}-0.58\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 4.7917ms 2.5145ms 397.6981 Ops/s 397.1323 Ops/s $\color{#35bf28}+0.14\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.2170s 8.3989ms 119.0626 Ops/s 118.2211 Ops/s $\color{#35bf28}+0.71\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 15.9251ms 13.2003ms 75.7558 Ops/s 76.5979 Ops/s $\color{#d91a1a}-1.10\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 4.8986ms 2.5081ms 398.7089 Ops/s 397.3802 Ops/s $\color{#35bf28}+0.33\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.2218s 8.6910ms 115.0610 Ops/s 116.5226 Ops/s $\color{#d91a1a}-1.25\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 15.9570ms 13.6411ms 73.3077 Ops/s 72.1836 Ops/s $\color{#35bf28}+1.56\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 3.8831ms 2.7562ms 362.8186 Ops/s 371.5300 Ops/s $\color{#d91a1a}-2.34\%$

@github-actions
Copy link

github-actions bot commented Feb 6, 2024

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 92. Improved: $\large\color{#35bf28}2$. Worsened: $\large\color{#d91a1a}1$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1153s 0.1134s 8.8191 Ops/s 8.6009 Ops/s $\color{#35bf28}+2.54\%$
test_sync 99.3491ms 96.0400ms 10.4123 Ops/s 10.3896 Ops/s $\color{#35bf28}+0.22\%$
test_async 0.2526s 92.1694ms 10.8496 Ops/s 10.7413 Ops/s $\color{#35bf28}+1.01\%$
test_single_pixels 0.1352s 0.1349s 7.4115 Ops/s 7.2400 Ops/s $\color{#35bf28}+2.37\%$
test_sync_pixels 83.7927ms 81.9830ms 12.1977 Ops/s 12.2431 Ops/s $\color{#d91a1a}-0.37\%$
test_async_pixels 0.1541s 75.4099ms 13.2609 Ops/s 13.2225 Ops/s $\color{#35bf28}+0.29\%$
test_simple 0.8754s 0.8069s 1.2393 Ops/s 1.1957 Ops/s $\color{#35bf28}+3.65\%$
test_transformed 1.1174s 1.0524s 0.9502 Ops/s 0.9205 Ops/s $\color{#35bf28}+3.22\%$
test_serial 2.4094s 2.3458s 0.4263 Ops/s 0.4122 Ops/s $\color{#35bf28}+3.41\%$
test_parallel 2.1388s 2.0593s 0.4856 Ops/s 0.4745 Ops/s $\color{#35bf28}+2.33\%$
test_step_mdp_speed[True-True-True-True-True] 98.4210μs 31.7456μs 31.5005 KOps/s 31.0086 KOps/s $\color{#35bf28}+1.59\%$
test_step_mdp_speed[True-True-True-True-False] 42.5200μs 19.0210μs 52.5736 KOps/s 51.8940 KOps/s $\color{#35bf28}+1.31\%$
test_step_mdp_speed[True-True-True-False-True] 35.3300μs 17.7294μs 56.4034 KOps/s 54.9078 KOps/s $\color{#35bf28}+2.72\%$
test_step_mdp_speed[True-True-True-False-False] 28.9610μs 10.8572μs 92.1051 KOps/s 91.2912 KOps/s $\color{#35bf28}+0.89\%$
test_step_mdp_speed[True-True-False-True-True] 53.8500μs 33.8778μs 29.5179 KOps/s 28.9051 KOps/s $\color{#35bf28}+2.12\%$
test_step_mdp_speed[True-True-False-True-False] 37.9600μs 20.9384μs 47.7591 KOps/s 46.2964 KOps/s $\color{#35bf28}+3.16\%$
test_step_mdp_speed[True-True-False-False-True] 41.2010μs 20.2069μs 49.4881 KOps/s 49.4188 KOps/s $\color{#35bf28}+0.14\%$
test_step_mdp_speed[True-True-False-False-False] 31.4300μs 12.7213μs 78.6083 KOps/s 76.6233 KOps/s $\color{#35bf28}+2.59\%$
test_step_mdp_speed[True-False-True-True-True] 57.0810μs 35.6465μs 28.0533 KOps/s 27.0827 KOps/s $\color{#35bf28}+3.58\%$
test_step_mdp_speed[True-False-True-True-False] 38.3200μs 22.6845μs 44.0830 KOps/s 42.5994 KOps/s $\color{#35bf28}+3.48\%$
test_step_mdp_speed[True-False-True-False-True] 53.9610μs 19.9831μs 50.0424 KOps/s 50.0165 KOps/s $\color{#35bf28}+0.05\%$
test_step_mdp_speed[True-False-True-False-False] 27.8000μs 12.6640μs 78.9638 KOps/s 78.2203 KOps/s $\color{#35bf28}+0.95\%$
test_step_mdp_speed[True-False-False-True-True] 81.4510μs 37.3006μs 26.8092 KOps/s 26.5647 KOps/s $\color{#35bf28}+0.92\%$
test_step_mdp_speed[True-False-False-True-False] 70.7710μs 24.8760μs 40.1994 KOps/s 40.2573 KOps/s $\color{#d91a1a}-0.14\%$
test_step_mdp_speed[True-False-False-False-True] 43.1300μs 21.6575μs 46.1735 KOps/s 46.8801 KOps/s $\color{#d91a1a}-1.51\%$
test_step_mdp_speed[True-False-False-False-False] 33.3500μs 14.6506μs 68.2567 KOps/s 67.8215 KOps/s $\color{#35bf28}+0.64\%$
test_step_mdp_speed[False-True-True-True-True] 58.8510μs 36.1652μs 27.6509 KOps/s 27.3244 KOps/s $\color{#35bf28}+1.19\%$
test_step_mdp_speed[False-True-True-True-False] 46.8700μs 22.7189μs 44.0162 KOps/s 43.7131 KOps/s $\color{#35bf28}+0.69\%$
test_step_mdp_speed[False-True-True-False-True] 43.4400μs 23.3236μs 42.8750 KOps/s 41.2227 KOps/s $\color{#35bf28}+4.01\%$
test_step_mdp_speed[False-True-True-False-False] 36.4510μs 14.4233μs 69.3324 KOps/s 67.5378 KOps/s $\color{#35bf28}+2.66\%$
test_step_mdp_speed[False-True-False-True-True] 63.5810μs 37.4136μs 26.7282 KOps/s 26.2383 KOps/s $\color{#35bf28}+1.87\%$
test_step_mdp_speed[False-True-False-True-False] 52.7810μs 24.5942μs 40.6600 KOps/s 39.3466 KOps/s $\color{#35bf28}+3.34\%$
test_step_mdp_speed[False-True-False-False-True] 43.8500μs 25.4304μs 39.3230 KOps/s 37.9343 KOps/s $\color{#35bf28}+3.66\%$
test_step_mdp_speed[False-True-False-False-False] 40.3510μs 16.1794μs 61.8070 KOps/s 61.0475 KOps/s $\color{#35bf28}+1.24\%$
test_step_mdp_speed[False-False-True-True-True] 66.3210μs 39.4760μs 25.3319 KOps/s 25.1883 KOps/s $\color{#35bf28}+0.57\%$
test_step_mdp_speed[False-False-True-True-False] 44.4600μs 26.2099μs 38.1535 KOps/s 36.6474 KOps/s $\color{#35bf28}+4.11\%$
test_step_mdp_speed[False-False-True-False-True] 42.3200μs 25.3324μs 39.4752 KOps/s 38.3453 KOps/s $\color{#35bf28}+2.95\%$
test_step_mdp_speed[False-False-True-False-False] 34.0300μs 16.3674μs 61.0971 KOps/s 59.7682 KOps/s $\color{#35bf28}+2.22\%$
test_step_mdp_speed[False-False-False-True-True] 64.8210μs 40.6806μs 24.5817 KOps/s 24.1489 KOps/s $\color{#35bf28}+1.79\%$
test_step_mdp_speed[False-False-False-True-False] 48.3510μs 28.3721μs 35.2459 KOps/s 34.6831 KOps/s $\color{#35bf28}+1.62\%$
test_step_mdp_speed[False-False-False-False-True] 93.7710μs 26.6797μs 37.4817 KOps/s 36.7741 KOps/s $\color{#35bf28}+1.92\%$
test_step_mdp_speed[False-False-False-False-False] 63.9610μs 18.0088μs 55.5284 KOps/s 54.3258 KOps/s $\color{#35bf28}+2.21\%$
test_values[generalized_advantage_estimate-True-True] 24.0558ms 23.5483ms 42.4659 Ops/s 42.1988 Ops/s $\color{#35bf28}+0.63\%$
test_values[vec_generalized_advantage_estimate-True-True] 90.3238ms 3.3552ms 298.0409 Ops/s 307.6333 Ops/s $\color{#d91a1a}-3.12\%$
test_values[td0_return_estimate-False-False] 88.7010μs 58.2888μs 17.1559 KOps/s 16.7357 KOps/s $\color{#35bf28}+2.51\%$
test_values[td1_return_estimate-False-False] 52.8066ms 50.9789ms 19.6159 Ops/s 19.6522 Ops/s $\color{#d91a1a}-0.18\%$
test_values[vec_td1_return_estimate-False-False] 1.9582ms 1.7408ms 574.4537 Ops/s 571.4906 Ops/s $\color{#35bf28}+0.52\%$
test_values[td_lambda_return_estimate-True-False] 82.0962ms 81.1440ms 12.3238 Ops/s 12.2684 Ops/s $\color{#35bf28}+0.45\%$
test_values[vec_td_lambda_return_estimate-True-False] 4.0468ms 1.7815ms 561.3373 Ops/s 558.3605 Ops/s $\color{#35bf28}+0.53\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 22.7851ms 22.6255ms 44.1979 Ops/s 43.9398 Ops/s $\color{#35bf28}+0.59\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.8684ms 0.6779ms 1.4752 KOps/s 1.4558 KOps/s $\color{#35bf28}+1.34\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.7551ms 0.6432ms 1.5546 KOps/s 1.5526 KOps/s $\color{#35bf28}+0.13\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.5409ms 1.4330ms 697.8127 Ops/s 693.7348 Ops/s $\color{#35bf28}+0.59\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.9145ms 0.6527ms 1.5320 KOps/s 1.5129 KOps/s $\color{#35bf28}+1.26\%$
test_dqn_speed 15.2284ms 7.2814ms 137.3360 Ops/s 132.1264 Ops/s $\color{#35bf28}+3.94\%$
test_ddpg_speed 15.3185ms 14.0896ms 70.9745 Ops/s 68.4133 Ops/s $\color{#35bf28}+3.74\%$
test_sac_speed 0.1219s 30.5158ms 32.7699 Ops/s 31.2010 Ops/s $\textbf{\color{#35bf28}+5.03\%}$
test_redq_speed 12.3579ms 11.3077ms 88.4356 Ops/s 87.1096 Ops/s $\color{#35bf28}+1.52\%$
test_redq_deprec_speed 23.6433ms 22.4898ms 44.4646 Ops/s 44.1260 Ops/s $\color{#35bf28}+0.77\%$
test_td3_speed 30.8144ms 18.7748ms 53.2628 Ops/s 51.6441 Ops/s $\color{#35bf28}+3.13\%$
test_cql_speed 74.8980ms 73.4826ms 13.6087 Ops/s 13.0882 Ops/s $\color{#35bf28}+3.98\%$
test_a2c_speed 25.4311ms 24.6218ms 40.6143 Ops/s 39.3376 Ops/s $\color{#35bf28}+3.25\%$
test_ppo_speed 25.7761ms 24.8054ms 40.3138 Ops/s 39.3739 Ops/s $\color{#35bf28}+2.39\%$
test_reinforce_speed 25.0384ms 23.8477ms 41.9328 Ops/s 41.0752 Ops/s $\color{#35bf28}+2.09\%$
test_iql_speed 50.3246ms 49.6908ms 20.1244 Ops/s 19.7672 Ops/s $\color{#35bf28}+1.81\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.7445ms 3.5300ms 283.2841 Ops/s 279.1838 Ops/s $\color{#35bf28}+1.47\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.8093ms 0.5596ms 1.7871 KOps/s 1.8043 KOps/s $\color{#d91a1a}-0.95\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7315ms 0.5235ms 1.9104 KOps/s 1.8956 KOps/s $\color{#35bf28}+0.78\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.7066ms 3.5353ms 282.8607 Ops/s 273.6101 Ops/s $\color{#35bf28}+3.38\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.6733ms 0.5470ms 1.8282 KOps/s 1.8027 KOps/s $\color{#35bf28}+1.41\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6785ms 0.5200ms 1.9232 KOps/s 1.9075 KOps/s $\color{#35bf28}+0.82\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.4441ms 3.2451ms 308.1613 Ops/s 300.2847 Ops/s $\color{#35bf28}+2.62\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.9011ms 0.6693ms 1.4941 KOps/s 1.4835 KOps/s $\color{#35bf28}+0.71\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.7853ms 0.6460ms 1.5480 KOps/s 1.5271 KOps/s $\color{#35bf28}+1.37\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.6591ms 3.5100ms 284.9040 Ops/s 280.0360 Ops/s $\color{#35bf28}+1.74\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7178ms 0.5545ms 1.8036 KOps/s 1.7917 KOps/s $\color{#35bf28}+0.66\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7346ms 0.5277ms 1.8951 KOps/s 1.4264 KOps/s $\textbf{\color{#35bf28}+32.86\%}$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.8701ms 3.5596ms 280.9272 Ops/s 275.2259 Ops/s $\color{#35bf28}+2.07\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.6850ms 0.5471ms 1.8277 KOps/s 1.8114 KOps/s $\color{#35bf28}+0.90\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7756ms 0.5218ms 1.9164 KOps/s 1.9097 KOps/s $\color{#35bf28}+0.35\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.4085ms 3.2827ms 304.6228 Ops/s 299.9103 Ops/s $\color{#35bf28}+1.57\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.9227ms 0.6741ms 1.4835 KOps/s 1.4468 KOps/s $\color{#35bf28}+2.54\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8076ms 0.6524ms 1.5327 KOps/s 1.4894 KOps/s $\color{#35bf28}+2.91\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.2332s 14.0744ms 71.0509 Ops/s 103.8745 Ops/s $\textbf{\color{#d91a1a}-31.60\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 18.7383ms 16.1964ms 61.7420 Ops/s 62.2876 Ops/s $\color{#d91a1a}-0.88\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 8.1855ms 3.0650ms 326.2609 Ops/s 329.7659 Ops/s $\color{#d91a1a}-1.06\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.2079s 9.5033ms 105.2263 Ops/s 103.1737 Ops/s $\color{#35bf28}+1.99\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 18.2174ms 15.8567ms 63.0646 Ops/s 62.7845 Ops/s $\color{#35bf28}+0.45\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 5.1781ms 2.9693ms 336.7793 Ops/s 328.1519 Ops/s $\color{#35bf28}+2.63\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.2078s 9.6970ms 103.1244 Ops/s 101.2317 Ops/s $\color{#35bf28}+1.87\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 18.9789ms 16.3432ms 61.1875 Ops/s 62.1986 Ops/s $\color{#d91a1a}-1.63\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 6.3616ms 3.2353ms 309.0913 Ops/s 307.0941 Ops/s $\color{#35bf28}+0.65\%$

@vmoens vmoens added the Refactoring Refactoring of an existing feature label Feb 6, 2024
@vmoens vmoens merged commit 62d977b into main Feb 6, 2024
@vmoens vmoens deleted the filter-empty branch February 6, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Refactoring Refactoring of an existing feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vmoens @facebook-github-bot