Skip to content

[CI] Unpin mpmath #1997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2024
Merged

[CI] Unpin mpmath #1997

merged 1 commit into from
Mar 6, 2024

Conversation

@vmoens
Copy link
Collaborator

@vmoens vmoens commented Mar 6, 2024 •
edited
Loading

No description provided.

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 6, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/1997

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 19 Unrelated Failures

As of commit a517907 with merge base fe6c070 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 6, 2024
@vmoens vmoens added the CI Has to do with CI setup (e.g. wheels & builds, tests...) label Mar 6, 2024
@vmoens vmoens marked this pull request as ready for review March 6, 2024 21:09
@vmoens vmoens merged commit 73e9b3f into main Mar 6, 2024
@vmoens vmoens deleted the unpin-mpmath branch March 6, 2024 21:09
@github-actions
Copy link

github-actions bot commented Mar 6, 2024

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 91. Improved: $\large\color{#35bf28}5$. Worsened: $\large\color{#d91a1a}3$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 60.5544ms 60.2764ms 16.5902 Ops/s 16.4290 Ops/s $\color{#35bf28}+0.98\%$
test_sync 37.1266ms 32.3775ms 30.8857 Ops/s 30.6485 Ops/s $\color{#35bf28}+0.77\%$
test_async 60.8889ms 29.3782ms 34.0388 Ops/s 33.2030 Ops/s $\color{#35bf28}+2.52\%$
test_simple 0.4665s 0.4167s 2.4001 Ops/s 2.3755 Ops/s $\color{#35bf28}+1.04\%$
test_transformed 0.6133s 0.5679s 1.7608 Ops/s 1.7796 Ops/s $\color{#d91a1a}-1.06\%$
test_serial 1.4178s 1.3733s 0.7282 Ops/s 0.7307 Ops/s $\color{#d91a1a}-0.35\%$
test_parallel 1.3900s 1.3510s 0.7402 Ops/s 0.7410 Ops/s $\color{#d91a1a}-0.11\%$
test_step_mdp_speed[True-True-True-True-True] 0.1153ms 21.3937μs 46.7427 KOps/s 46.7024 KOps/s $\color{#35bf28}+0.09\%$
test_step_mdp_speed[True-True-True-True-False] 37.8000μs 13.0809μs 76.4475 KOps/s 76.5179 KOps/s $\color{#d91a1a}-0.09\%$
test_step_mdp_speed[True-True-True-False-True] 31.8190μs 12.4672μs 80.2102 KOps/s 79.0766 KOps/s $\color{#35bf28}+1.43\%$
test_step_mdp_speed[True-True-True-False-False] 37.8490μs 7.5346μs 132.7218 KOps/s 132.1555 KOps/s $\color{#35bf28}+0.43\%$
test_step_mdp_speed[True-True-False-True-True] 69.6200μs 22.7518μs 43.9525 KOps/s 43.6564 KOps/s $\color{#35bf28}+0.68\%$
test_step_mdp_speed[True-True-False-True-False] 48.9720μs 14.4127μs 69.3835 KOps/s 69.1406 KOps/s $\color{#35bf28}+0.35\%$
test_step_mdp_speed[True-True-False-False-True] 41.0970μs 13.7923μs 72.5041 KOps/s 72.2763 KOps/s $\color{#35bf28}+0.32\%$
test_step_mdp_speed[True-True-False-False-False] 40.5450μs 8.8262μs 113.2993 KOps/s 112.9722 KOps/s $\color{#35bf28}+0.29\%$
test_step_mdp_speed[True-False-True-True-True] 46.2170μs 24.3065μs 41.1413 KOps/s 41.1679 KOps/s $\color{#d91a1a}-0.06\%$
test_step_mdp_speed[True-False-True-True-False] 52.4980μs 15.8360μs 63.1473 KOps/s 63.2998 KOps/s $\color{#d91a1a}-0.24\%$
test_step_mdp_speed[True-False-True-False-True] 53.0690μs 13.8467μs 72.2194 KOps/s 72.6805 KOps/s $\color{#d91a1a}-0.63\%$
test_step_mdp_speed[True-False-True-False-False] 31.0080μs 8.8113μs 113.4907 KOps/s 112.2248 KOps/s $\color{#35bf28}+1.13\%$
test_step_mdp_speed[True-False-False-True-True] 60.5930μs 25.3888μs 39.3875 KOps/s 39.5155 KOps/s $\color{#d91a1a}-0.32\%$
test_step_mdp_speed[True-False-False-True-False] 59.9120μs 17.1245μs 58.3960 KOps/s 58.3437 KOps/s $\color{#35bf28}+0.09\%$
test_step_mdp_speed[True-False-False-False-True] 53.5700μs 14.9130μs 67.0554 KOps/s 66.8500 KOps/s $\color{#35bf28}+0.31\%$
test_step_mdp_speed[True-False-False-False-False] 30.8670μs 10.0129μs 99.8714 KOps/s 99.3847 KOps/s $\color{#35bf28}+0.49\%$
test_step_mdp_speed[False-True-True-True-True] 65.5020μs 24.0771μs 41.5333 KOps/s 41.0927 KOps/s $\color{#35bf28}+1.07\%$
test_step_mdp_speed[False-True-True-True-False] 49.3720μs 15.6932μs 63.7218 KOps/s 62.4086 KOps/s $\color{#35bf28}+2.10\%$
test_step_mdp_speed[False-True-True-False-True] 41.4980μs 16.1272μs 62.0070 KOps/s 61.4487 KOps/s $\color{#35bf28}+0.91\%$
test_step_mdp_speed[False-True-True-False-False] 42.2790μs 10.1782μs 98.2489 KOps/s 97.6241 KOps/s $\color{#35bf28}+0.64\%$
test_step_mdp_speed[False-True-False-True-True] 35.2060μs 25.6353μs 39.0088 KOps/s 37.7822 KOps/s $\color{#35bf28}+3.25\%$
test_step_mdp_speed[False-True-False-True-False] 41.1880μs 17.1478μs 58.3164 KOps/s 58.4902 KOps/s $\color{#d91a1a}-0.30\%$
test_step_mdp_speed[False-True-False-False-True] 54.3310μs 17.2841μs 57.8565 KOps/s 57.7454 KOps/s $\color{#35bf28}+0.19\%$
test_step_mdp_speed[False-True-False-False-False] 43.7810μs 11.4417μs 87.3997 KOps/s 87.8164 KOps/s $\color{#d91a1a}-0.47\%$
test_step_mdp_speed[False-False-True-True-True] 64.0600μs 26.9568μs 37.0964 KOps/s 37.0243 KOps/s $\color{#35bf28}+0.19\%$
test_step_mdp_speed[False-False-True-True-False] 52.7490μs 18.5265μs 53.9767 KOps/s 54.4387 KOps/s $\color{#d91a1a}-0.85\%$
test_step_mdp_speed[False-False-True-False-True] 43.7920μs 17.4073μs 57.4471 KOps/s 57.6741 KOps/s $\color{#d91a1a}-0.39\%$
test_step_mdp_speed[False-False-True-False-False] 42.3280μs 11.3698μs 87.9519 KOps/s 87.4645 KOps/s $\color{#35bf28}+0.56\%$
test_step_mdp_speed[False-False-False-True-True] 95.4390μs 27.4171μs 36.4736 KOps/s 35.8716 KOps/s $\color{#35bf28}+1.68\%$
test_step_mdp_speed[False-False-False-True-False] 48.8410μs 19.4031μs 51.5382 KOps/s 50.8579 KOps/s $\color{#35bf28}+1.34\%$
test_step_mdp_speed[False-False-False-False-True] 52.7690μs 18.1478μs 55.1031 KOps/s 54.1209 KOps/s $\color{#35bf28}+1.81\%$
test_step_mdp_speed[False-False-False-False-False] 31.2580μs 12.4607μs 80.2523 KOps/s 78.8762 KOps/s $\color{#35bf28}+1.74\%$
test_values[generalized_advantage_estimate-True-True] 9.6957ms 9.2727ms 107.8431 Ops/s 107.2422 Ops/s $\color{#35bf28}+0.56\%$
test_values[vec_generalized_advantage_estimate-True-True] 37.3365ms 32.9766ms 30.3245 Ops/s 28.4271 Ops/s $\textbf{\color{#35bf28}+6.67\%}$
test_values[td0_return_estimate-False-False] 0.2222ms 0.1627ms 6.1464 KOps/s 6.0809 KOps/s $\color{#35bf28}+1.08\%$
test_values[td1_return_estimate-False-False] 26.7578ms 23.8239ms 41.9747 Ops/s 43.4660 Ops/s $\color{#d91a1a}-3.43\%$
test_values[vec_td1_return_estimate-False-False] 34.3681ms 33.0573ms 30.2505 Ops/s 27.9901 Ops/s $\textbf{\color{#35bf28}+8.08\%}$
test_values[td_lambda_return_estimate-True-False] 36.7619ms 34.2989ms 29.1554 Ops/s 29.9408 Ops/s $\color{#d91a1a}-2.62\%$
test_values[vec_td_lambda_return_estimate-True-False] 34.6487ms 33.0207ms 30.2840 Ops/s 28.3698 Ops/s $\textbf{\color{#35bf28}+6.75\%}$
test_gae_speed[generalized_advantage_estimate-False-1-512] 8.4100ms 8.1817ms 122.2247 Ops/s 122.9014 Ops/s $\color{#d91a1a}-0.55\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.2353ms 1.9436ms 514.5052 Ops/s 525.1501 Ops/s $\color{#d91a1a}-2.03\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.5204ms 0.3536ms 2.8282 KOps/s 2.9049 KOps/s $\color{#d91a1a}-2.64\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 39.7983ms 38.4996ms 25.9743 Ops/s 21.6759 Ops/s $\textbf{\color{#35bf28}+19.83\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 3.8389ms 3.0091ms 332.3223 Ops/s 332.1981 Ops/s $\color{#35bf28}+0.04\%$
test_dqn_speed 7.4824ms 1.3389ms 746.8900 Ops/s 752.2066 Ops/s $\color{#d91a1a}-0.71\%$
test_ddpg_speed 3.2592ms 2.6435ms 378.2798 Ops/s 378.1554 Ops/s $\color{#35bf28}+0.03\%$
test_sac_speed 8.6894ms 8.1018ms 123.4292 Ops/s 124.3167 Ops/s $\color{#d91a1a}-0.71\%$
test_redq_speed 14.1945ms 12.9239ms 77.3762 Ops/s 77.4592 Ops/s $\color{#d91a1a}-0.11\%$
test_redq_deprec_speed 79.2424ms 13.6120ms 73.4648 Ops/s 78.8116 Ops/s $\textbf{\color{#d91a1a}-6.78\%}$
test_td3_speed 8.2206ms 8.0065ms 124.8993 Ops/s 126.2229 Ops/s $\color{#d91a1a}-1.05\%$
test_cql_speed 36.7797ms 35.7820ms 27.9470 Ops/s 27.7410 Ops/s $\color{#35bf28}+0.74\%$
test_a2c_speed 7.9529ms 7.2385ms 138.1500 Ops/s 138.1561 Ops/s $-0.00\%$
test_ppo_speed 8.2027ms 7.4955ms 133.4127 Ops/s 133.0017 Ops/s $\color{#35bf28}+0.31\%$
test_reinforce_speed 7.4966ms 6.4573ms 154.8635 Ops/s 154.5484 Ops/s $\color{#35bf28}+0.20\%$
test_iql_speed 32.9747ms 32.0864ms 31.1658 Ops/s 31.1920 Ops/s $\color{#d91a1a}-0.08\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.1710ms 2.1094ms 474.0722 Ops/s 477.5995 Ops/s $\color{#d91a1a}-0.74\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.4400ms 0.5036ms 1.9856 KOps/s 1.9845 KOps/s $\color{#35bf28}+0.05\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6670ms 0.4684ms 2.1349 KOps/s 2.1371 KOps/s $\color{#d91a1a}-0.10\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.2723ms 2.0777ms 481.3028 Ops/s 480.5758 Ops/s $\color{#35bf28}+0.15\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.6322ms 0.4855ms 2.0596 KOps/s 2.0580 KOps/s $\color{#35bf28}+0.08\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 3.4952ms 0.4649ms 2.1512 KOps/s 2.1575 KOps/s $\color{#d91a1a}-0.29\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.4203ms 1.2567ms 795.7205 Ops/s 803.5739 Ops/s $\color{#d91a1a}-0.98\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.9162ms 1.1892ms 840.9345 Ops/s 746.7424 Ops/s $\textbf{\color{#35bf28}+12.61\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.3842ms 2.2181ms 450.8285 Ops/s 450.2147 Ops/s $\color{#35bf28}+0.14\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8715ms 0.6092ms 1.6415 KOps/s 1.6559 KOps/s $\color{#d91a1a}-0.87\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.7865ms 0.5829ms 1.7155 KOps/s 1.7271 KOps/s $\color{#d91a1a}-0.67\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.3102ms 2.0732ms 482.3574 Ops/s 476.9535 Ops/s $\color{#35bf28}+1.13\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.5725ms 0.4919ms 2.0330 KOps/s 2.0186 KOps/s $\color{#35bf28}+0.71\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 3.3900ms 0.4760ms 2.1008 KOps/s 2.1344 KOps/s $\color{#d91a1a}-1.57\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.4594ms 2.0820ms 480.3053 Ops/s 478.6181 Ops/s $\color{#35bf28}+0.35\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.0232ms 0.4866ms 2.0550 KOps/s 2.0512 KOps/s $\color{#35bf28}+0.19\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6591ms 0.4662ms 2.1450 KOps/s 2.1547 KOps/s $\color{#d91a1a}-0.45\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 4.9103ms 2.2622ms 442.0479 Ops/s 451.2509 Ops/s $\color{#d91a1a}-2.04\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8589ms 0.6138ms 1.6293 KOps/s 1.6448 KOps/s $\color{#d91a1a}-0.94\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 3.6308ms 0.5880ms 1.7007 KOps/s 1.7314 KOps/s $\color{#d91a1a}-1.77\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 95.9780ms 7.0035ms 142.7847 Ops/s 179.1875 Ops/s $\textbf{\color{#d91a1a}-20.32\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 13.5732ms 11.7814ms 84.8792 Ops/s 84.2980 Ops/s $\color{#35bf28}+0.69\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 1.4086ms 0.9947ms 1.0053 KOps/s 1.0050 KOps/s $\color{#35bf28}+0.04\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 84.3827ms 6.8032ms 146.9896 Ops/s 142.1830 Ops/s $\color{#35bf28}+3.38\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 13.7737ms 11.7758ms 84.9201 Ops/s 84.4176 Ops/s $\color{#35bf28}+0.60\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 1.4459ms 0.9942ms 1.0058 KOps/s 1.0118 KOps/s $\color{#d91a1a}-0.59\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 85.8726ms 7.2137ms 138.6259 Ops/s 178.1503 Ops/s $\textbf{\color{#d91a1a}-22.19\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 14.0380ms 12.0914ms 82.7037 Ops/s 82.3358 Ops/s $\color{#35bf28}+0.45\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 1.8167ms 1.3317ms 750.8959 Ops/s 750.0813 Ops/s $\color{#35bf28}+0.11\%$

@github-actions
Copy link

github-actions bot commented Mar 6, 2024

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 94. Improved: $\large\color{#35bf28}6$. Worsened: $\large\color{#d91a1a}7$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1108s 0.1106s 9.0450 Ops/s 8.8540 Ops/s $\color{#35bf28}+2.16\%$
test_sync 94.9339ms 94.5375ms 10.5778 Ops/s 10.5022 Ops/s $\color{#35bf28}+0.72\%$
test_async 0.1802s 91.2355ms 10.9606 Ops/s 11.0033 Ops/s $\color{#d91a1a}-0.39\%$
test_single_pixels 0.1981s 0.1304s 7.6707 Ops/s 8.1137 Ops/s $\textbf{\color{#d91a1a}-5.46\%}$
test_sync_pixels 81.9101ms 78.5554ms 12.7299 Ops/s 13.3288 Ops/s $\color{#d91a1a}-4.49\%$
test_async_pixels 0.1527s 64.0756ms 15.6066 Ops/s 13.6656 Ops/s $\textbf{\color{#35bf28}+14.20\%}$
test_simple 0.8086s 0.8057s 1.2411 Ops/s 1.1989 Ops/s $\color{#35bf28}+3.52\%$
test_transformed 1.1019s 1.0460s 0.9560 Ops/s 0.9416 Ops/s $\color{#35bf28}+1.52\%$
test_serial 2.4684s 2.3985s 0.4169 Ops/s 0.4165 Ops/s $\color{#35bf28}+0.10\%$
test_parallel 2.0794s 2.0383s 0.4906 Ops/s 0.4837 Ops/s $\color{#35bf28}+1.43\%$
test_step_mdp_speed[True-True-True-True-True] 90.0020μs 32.6482μs 30.6296 KOps/s 30.2482 KOps/s $\color{#35bf28}+1.26\%$
test_step_mdp_speed[True-True-True-True-False] 35.5310μs 19.5177μs 51.2356 KOps/s 50.2456 KOps/s $\color{#35bf28}+1.97\%$
test_step_mdp_speed[True-True-True-False-True] 32.3310μs 18.5263μs 53.9772 KOps/s 54.2360 KOps/s $\color{#d91a1a}-0.48\%$
test_step_mdp_speed[True-True-True-False-False] 30.7710μs 11.1057μs 90.0441 KOps/s 88.8950 KOps/s $\color{#35bf28}+1.29\%$
test_step_mdp_speed[True-True-False-True-True] 49.2910μs 34.4023μs 29.0678 KOps/s 28.8082 KOps/s $\color{#35bf28}+0.90\%$
test_step_mdp_speed[True-True-False-True-False] 0.1009ms 21.4791μs 46.5570 KOps/s 46.3247 KOps/s $\color{#35bf28}+0.50\%$
test_step_mdp_speed[True-True-False-False-True] 40.8310μs 20.3678μs 49.0971 KOps/s 49.1767 KOps/s $\color{#d91a1a}-0.16\%$
test_step_mdp_speed[True-True-False-False-False] 37.8710μs 13.1127μs 76.2618 KOps/s 76.7508 KOps/s $\color{#d91a1a}-0.64\%$
test_step_mdp_speed[True-False-True-True-True] 61.4310μs 36.6036μs 27.3197 KOps/s 27.1365 KOps/s $\color{#35bf28}+0.68\%$
test_step_mdp_speed[True-False-True-True-False] 44.5010μs 23.3456μs 42.8347 KOps/s 42.4800 KOps/s $\color{#35bf28}+0.83\%$
test_step_mdp_speed[True-False-True-False-True] 0.1018ms 20.4356μs 48.9342 KOps/s 49.1242 KOps/s $\color{#d91a1a}-0.39\%$
test_step_mdp_speed[True-False-True-False-False] 30.5200μs 13.0280μs 76.7576 KOps/s 76.6154 KOps/s $\color{#35bf28}+0.19\%$
test_step_mdp_speed[True-False-False-True-True] 62.2620μs 38.1869μs 26.1870 KOps/s 25.8829 KOps/s $\color{#35bf28}+1.18\%$
test_step_mdp_speed[True-False-False-True-False] 42.0210μs 25.1161μs 39.8151 KOps/s 39.2433 KOps/s $\color{#35bf28}+1.46\%$
test_step_mdp_speed[True-False-False-False-True] 44.3710μs 22.1873μs 45.0709 KOps/s 45.2810 KOps/s $\color{#d91a1a}-0.46\%$
test_step_mdp_speed[True-False-False-False-False] 31.2110μs 14.8949μs 67.1370 KOps/s 67.3838 KOps/s $\color{#d91a1a}-0.37\%$
test_step_mdp_speed[False-True-True-True-True] 60.3320μs 36.4416μs 27.4411 KOps/s 27.1017 KOps/s $\color{#35bf28}+1.25\%$
test_step_mdp_speed[False-True-True-True-False] 47.0310μs 23.2464μs 43.0173 KOps/s 42.0987 KOps/s $\color{#35bf28}+2.18\%$
test_step_mdp_speed[False-True-True-False-True] 51.3210μs 24.0980μs 41.4973 KOps/s 40.6848 KOps/s $\color{#35bf28}+2.00\%$
test_step_mdp_speed[False-True-True-False-False] 35.1610μs 14.8727μs 67.2374 KOps/s 67.3528 KOps/s $\color{#d91a1a}-0.17\%$
test_step_mdp_speed[False-True-False-True-True] 57.4710μs 38.4667μs 25.9965 KOps/s 25.8795 KOps/s $\color{#35bf28}+0.45\%$
test_step_mdp_speed[False-True-False-True-False] 44.8610μs 25.3574μs 39.4362 KOps/s 39.2702 KOps/s $\color{#35bf28}+0.42\%$
test_step_mdp_speed[False-True-False-False-True] 0.1128ms 26.2313μs 38.1224 KOps/s 38.2824 KOps/s $\color{#d91a1a}-0.42\%$
test_step_mdp_speed[False-True-False-False-False] 36.9710μs 16.5866μs 60.2895 KOps/s 60.1914 KOps/s $\color{#35bf28}+0.16\%$
test_step_mdp_speed[False-False-True-True-True] 65.3420μs 40.3274μs 24.7971 KOps/s 24.8068 KOps/s $\color{#d91a1a}-0.04\%$
test_step_mdp_speed[False-False-True-True-False] 43.4510μs 27.2039μs 36.7594 KOps/s 36.1983 KOps/s $\color{#35bf28}+1.55\%$
test_step_mdp_speed[False-False-True-False-True] 46.5510μs 26.1330μs 38.2658 KOps/s 38.3485 KOps/s $\color{#d91a1a}-0.22\%$
test_step_mdp_speed[False-False-True-False-False] 34.6410μs 16.6856μs 59.9318 KOps/s 60.2254 KOps/s $\color{#d91a1a}-0.49\%$
test_step_mdp_speed[False-False-False-True-True] 63.6120μs 41.8690μs 23.8840 KOps/s 23.7851 KOps/s $\color{#35bf28}+0.42\%$
test_step_mdp_speed[False-False-False-True-False] 51.0010μs 29.0729μs 34.3963 KOps/s 34.3204 KOps/s $\color{#35bf28}+0.22\%$
test_step_mdp_speed[False-False-False-False-True] 55.6610μs 27.6454μs 36.1724 KOps/s 35.8566 KOps/s $\color{#35bf28}+0.88\%$
test_step_mdp_speed[False-False-False-False-False] 47.9410μs 18.2666μs 54.7446 KOps/s 54.4988 KOps/s $\color{#35bf28}+0.45\%$
test_values[generalized_advantage_estimate-True-True] 23.5943ms 22.8144ms 43.8320 Ops/s 42.2799 Ops/s $\color{#35bf28}+3.67\%$
test_values[vec_generalized_advantage_estimate-True-True] 83.9496ms 3.2319ms 309.4139 Ops/s 312.2458 Ops/s $\color{#d91a1a}-0.91\%$
test_values[td0_return_estimate-False-False] 97.2720μs 62.6740μs 15.9556 KOps/s 15.8864 KOps/s $\color{#35bf28}+0.44\%$
test_values[td1_return_estimate-False-False] 49.7254ms 48.9769ms 20.4178 Ops/s 19.6128 Ops/s $\color{#35bf28}+4.10\%$
test_values[vec_td1_return_estimate-False-False] 1.9627ms 1.7369ms 575.7353 Ops/s 570.4378 Ops/s $\color{#35bf28}+0.93\%$
test_values[td_lambda_return_estimate-True-False] 79.8085ms 78.8331ms 12.6850 Ops/s 12.3108 Ops/s $\color{#35bf28}+3.04\%$
test_values[vec_td_lambda_return_estimate-True-False] 2.1200ms 1.7399ms 574.7363 Ops/s 572.5200 Ops/s $\color{#35bf28}+0.39\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 21.6169ms 21.3392ms 46.8622 Ops/s 45.2636 Ops/s $\color{#35bf28}+3.53\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.9156ms 0.6631ms 1.5080 KOps/s 1.4516 KOps/s $\color{#35bf28}+3.89\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.6711ms 0.6281ms 1.5921 KOps/s 1.5715 KOps/s $\color{#35bf28}+1.31\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.4631ms 1.4298ms 699.4162 Ops/s 696.0356 Ops/s $\color{#35bf28}+0.49\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.9409ms 0.6330ms 1.5797 KOps/s 1.5209 KOps/s $\color{#35bf28}+3.86\%$
test_dqn_speed 1.9227ms 1.4511ms 689.1473 Ops/s 623.9733 Ops/s $\textbf{\color{#35bf28}+10.45\%}$
test_ddpg_speed 2.9432ms 2.6707ms 374.4372 Ops/s 366.0469 Ops/s $\color{#35bf28}+2.29\%$
test_sac_speed 8.3386ms 7.8959ms 126.6476 Ops/s 125.5262 Ops/s $\color{#35bf28}+0.89\%$
test_redq_speed 11.7172ms 10.4766ms 95.4511 Ops/s 95.9109 Ops/s $\color{#d91a1a}-0.48\%$
test_redq_deprec_speed 11.2888ms 10.8689ms 92.0059 Ops/s 87.4173 Ops/s $\textbf{\color{#35bf28}+5.25\%}$
test_td3_speed 16.0749ms 7.9128ms 126.3768 Ops/s 126.6841 Ops/s $\color{#d91a1a}-0.24\%$
test_cql_speed 27.0202ms 25.9646ms 38.5140 Ops/s 38.9245 Ops/s $\color{#d91a1a}-1.05\%$
test_a2c_speed 6.2310ms 5.5169ms 181.2620 Ops/s 178.2379 Ops/s $\color{#35bf28}+1.70\%$
test_ppo_speed 5.9673ms 5.7685ms 173.3550 Ops/s 168.6800 Ops/s $\color{#35bf28}+2.77\%$
test_reinforce_speed 4.6869ms 4.4617ms 224.1294 Ops/s 218.0390 Ops/s $\color{#35bf28}+2.79\%$
test_iql_speed 20.0108ms 19.4979ms 51.2875 Ops/s 49.8498 Ops/s $\color{#35bf28}+2.88\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.0299ms 2.9258ms 341.7911 Ops/s 343.7541 Ops/s $\color{#d91a1a}-0.57\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 98.8250ms 0.6296ms 1.5882 KOps/s 1.8077 KOps/s $\textbf{\color{#d91a1a}-12.14\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7253ms 0.5337ms 1.8735 KOps/s 1.8754 KOps/s $\color{#d91a1a}-0.10\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.1730ms 2.9578ms 338.0916 Ops/s 342.1973 Ops/s $\color{#d91a1a}-1.20\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.3496ms 0.5519ms 1.8119 KOps/s 1.8483 KOps/s $\color{#d91a1a}-1.97\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6937ms 0.5312ms 1.8824 KOps/s 1.9089 KOps/s $\color{#d91a1a}-1.39\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 2.0403ms 1.4549ms 687.3241 Ops/s 687.6681 Ops/s $\color{#d91a1a}-0.05\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.5780ms 1.3941ms 717.2914 Ops/s 714.3787 Ops/s $\color{#35bf28}+0.41\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.2734ms 3.0505ms 327.8189 Ops/s 329.3688 Ops/s $\color{#d91a1a}-0.47\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.9187ms 0.6791ms 1.4725 KOps/s 1.4826 KOps/s $\color{#d91a1a}-0.68\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8833ms 0.6602ms 1.5147 KOps/s 1.5083 KOps/s $\color{#35bf28}+0.42\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.0470ms 2.9233ms 342.0816 Ops/s 343.7312 Ops/s $\color{#d91a1a}-0.48\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.6871ms 0.5482ms 1.8241 KOps/s 1.8125 KOps/s $\color{#35bf28}+0.64\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7338ms 0.5319ms 1.8800 KOps/s 1.5006 KOps/s $\textbf{\color{#35bf28}+25.29\%}$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.1849ms 2.9660ms 337.1502 Ops/s 337.8007 Ops/s $\color{#d91a1a}-0.19\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.6621ms 0.5438ms 1.8389 KOps/s 1.8253 KOps/s $\color{#35bf28}+0.74\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 4.7658ms 0.5267ms 1.8986 KOps/s 1.8948 KOps/s $\color{#35bf28}+0.20\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.2194ms 3.0634ms 326.4363 Ops/s 327.5738 Ops/s $\color{#d91a1a}-0.35\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8085ms 0.6853ms 1.4593 KOps/s 1.4718 KOps/s $\color{#d91a1a}-0.85\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8339ms 0.6624ms 1.5097 KOps/s 1.2253 KOps/s $\textbf{\color{#35bf28}+23.22\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1355s 9.4283ms 106.0632 Ops/s 146.6490 Ops/s $\textbf{\color{#d91a1a}-27.68\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 16.7948ms 14.4220ms 69.3386 Ops/s 69.1538 Ops/s $\color{#35bf28}+0.27\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 2.5728ms 1.2477ms 801.4832 Ops/s 911.5542 Ops/s $\textbf{\color{#d91a1a}-12.08\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1113s 6.8836ms 145.2738 Ops/s 111.2387 Ops/s $\textbf{\color{#35bf28}+30.60\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 0.1179s 16.3803ms 61.0489 Ops/s 69.6491 Ops/s $\textbf{\color{#d91a1a}-12.35\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 2.3711ms 1.1878ms 841.8757 Ops/s 913.6817 Ops/s $\textbf{\color{#d91a1a}-7.86\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1160s 7.3095ms 136.8086 Ops/s 137.2071 Ops/s $\color{#d91a1a}-0.29\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 17.1103ms 14.6378ms 68.3163 Ops/s 68.1588 Ops/s $\color{#35bf28}+0.23\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 7.4101ms 1.6432ms 608.5624 Ops/s 698.0199 Ops/s $\textbf{\color{#d91a1a}-12.82\%}$

vmoens pushed a commit that referenced this pull request Mar 25, 2024
[CI] Unpin mpmath (#1997)
35ce73e 
(cherry picked from commit 73e9b3f)
vmoens pushed a commit that referenced this pull request Apr 7, 2024
[CI] Unpin mpmath (#1997)
b7207d6 
(cherry picked from commit 73e9b3f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CI Has to do with CI setup (e.g. wheels & builds, tests...) CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vmoens @facebook-github-bot