Skip to content

Conversation

@vmoens
Copy link
Collaborator

@vmoens vmoens commented Mar 18, 2024

No description provided.

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 18, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2013

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures

As of commit 74f9eef with merge base c371266 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 18, 2024
@github-actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 91. Improved: $\large\color{#35bf28}8$. Worsened: $\large\color{#d91a1a}15$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 64.0479ms 60.5110ms 16.5259 Ops/s 14.3876 Ops/s $\textbf{\color{#35bf28}+14.86\%}$
test_sync 49.0183ms 34.4483ms 29.0290 Ops/s 27.5611 Ops/s $\textbf{\color{#35bf28}+5.33\%}$
test_async 63.6534ms 29.6643ms 33.7106 Ops/s 31.8163 Ops/s $\textbf{\color{#35bf28}+5.95\%}$
test_simple 0.4476s 0.3750s 2.6667 Ops/s 2.8430 Ops/s $\textbf{\color{#d91a1a}-6.20\%}$
test_transformed 0.5187s 0.5037s 1.9855 Ops/s 1.8890 Ops/s $\textbf{\color{#35bf28}+5.11\%}$
test_serial 1.4511s 1.3817s 0.7237 Ops/s 0.7510 Ops/s $\color{#d91a1a}-3.63\%$
test_parallel 1.2967s 1.2458s 0.8027 Ops/s 0.7980 Ops/s $\color{#35bf28}+0.59\%$
test_step_mdp_speed[True-True-True-True-True] 0.2310ms 21.3571μs 46.8229 KOps/s 46.9258 KOps/s $\color{#d91a1a}-0.22\%$
test_step_mdp_speed[True-True-True-True-False] 61.6750μs 13.3022μs 75.1756 KOps/s 77.8233 KOps/s $\color{#d91a1a}-3.40\%$
test_step_mdp_speed[True-True-True-False-True] 71.5630μs 12.4764μs 80.1516 KOps/s 80.6437 KOps/s $\color{#d91a1a}-0.61\%$
test_step_mdp_speed[True-True-True-False-False] 44.1430μs 7.6259μs 131.1326 KOps/s 132.7787 KOps/s $\color{#d91a1a}-1.24\%$
test_step_mdp_speed[True-True-False-True-True] 76.7830μs 22.7076μs 44.0380 KOps/s 44.5242 KOps/s $\color{#d91a1a}-1.09\%$
test_step_mdp_speed[True-True-False-True-False] 56.6360μs 14.4091μs 69.4006 KOps/s 70.0067 KOps/s $\color{#d91a1a}-0.87\%$
test_step_mdp_speed[True-True-False-False-True] 64.6500μs 13.8324μs 72.2942 KOps/s 73.1899 KOps/s $\color{#d91a1a}-1.22\%$
test_step_mdp_speed[True-True-False-False-False] 45.7950μs 8.9060μs 112.2835 KOps/s 113.0788 KOps/s $\color{#d91a1a}-0.70\%$
test_step_mdp_speed[True-False-True-True-True] 94.3160μs 23.7551μs 42.0962 KOps/s 41.8403 KOps/s $\color{#35bf28}+0.61\%$
test_step_mdp_speed[True-False-True-True-False] 77.1530μs 15.8544μs 63.0739 KOps/s 64.5733 KOps/s $\color{#d91a1a}-2.32\%$
test_step_mdp_speed[True-False-True-False-True] 56.4450μs 13.7599μs 72.6749 KOps/s 73.2585 KOps/s $\color{#d91a1a}-0.80\%$
test_step_mdp_speed[True-False-True-False-False] 56.3050μs 8.9895μs 111.2410 KOps/s 113.6217 KOps/s $\color{#d91a1a}-2.10\%$
test_step_mdp_speed[True-False-False-True-True] 67.6460μs 25.2173μs 39.6553 KOps/s 39.8446 KOps/s $\color{#d91a1a}-0.48\%$
test_step_mdp_speed[True-False-False-True-False] 0.1052ms 16.9303μs 59.0655 KOps/s 59.5944 KOps/s $\color{#d91a1a}-0.89\%$
test_step_mdp_speed[True-False-False-False-True] 80.1690μs 14.7918μs 67.6051 KOps/s 67.3974 KOps/s $\color{#35bf28}+0.31\%$
test_step_mdp_speed[True-False-False-False-False] 50.1840μs 10.0695μs 99.3100 KOps/s 100.2086 KOps/s $\color{#d91a1a}-0.90\%$
test_step_mdp_speed[False-True-True-True-True] 0.1005ms 24.2674μs 41.2075 KOps/s 41.6478 KOps/s $\color{#d91a1a}-1.06\%$
test_step_mdp_speed[False-True-True-True-False] 90.2380μs 15.6644μs 63.8389 KOps/s 64.5405 KOps/s $\color{#d91a1a}-1.09\%$
test_step_mdp_speed[False-True-True-False-True] 53.8310μs 15.8429μs 63.1196 KOps/s 62.9893 KOps/s $\color{#35bf28}+0.21\%$
test_step_mdp_speed[False-True-True-False-False] 48.6310μs 10.0817μs 99.1897 KOps/s 99.5606 KOps/s $\color{#d91a1a}-0.37\%$
test_step_mdp_speed[False-True-False-True-True] 57.1760μs 25.8897μs 38.6254 KOps/s 39.8057 KOps/s $\color{#d91a1a}-2.97\%$
test_step_mdp_speed[False-True-False-True-False] 60.9240μs 16.9902μs 58.8573 KOps/s 60.1223 KOps/s $\color{#d91a1a}-2.10\%$
test_step_mdp_speed[False-True-False-False-True] 59.8110μs 17.0905μs 58.5119 KOps/s 58.7334 KOps/s $\color{#d91a1a}-0.38\%$
test_step_mdp_speed[False-True-False-False-False] 69.2890μs 11.1828μs 89.4227 KOps/s 89.9060 KOps/s $\color{#d91a1a}-0.54\%$
test_step_mdp_speed[False-False-True-True-True] 73.4070μs 26.5966μs 37.5988 KOps/s 38.2671 KOps/s $\color{#d91a1a}-1.75\%$
test_step_mdp_speed[False-False-True-True-False] 84.1960μs 18.1224μs 55.1803 KOps/s 55.6449 KOps/s $\color{#d91a1a}-0.83\%$
test_step_mdp_speed[False-False-True-False-True] 65.5320μs 17.0224μs 58.7460 KOps/s 57.5770 KOps/s $\color{#35bf28}+2.03\%$
test_step_mdp_speed[False-False-True-False-False] 73.5570μs 11.2248μs 89.0885 KOps/s 89.4604 KOps/s $\color{#d91a1a}-0.42\%$
test_step_mdp_speed[False-False-False-True-True] 65.8830μs 27.4389μs 36.4446 KOps/s 36.8973 KOps/s $\color{#d91a1a}-1.23\%$
test_step_mdp_speed[False-False-False-True-False] 73.9480μs 19.2503μs 51.9472 KOps/s 52.7565 KOps/s $\color{#d91a1a}-1.53\%$
test_step_mdp_speed[False-False-False-False-True] 63.9400μs 18.0301μs 55.4629 KOps/s 55.5441 KOps/s $\color{#d91a1a}-0.15\%$
test_step_mdp_speed[False-False-False-False-False] 59.9920μs 12.4714μs 80.1836 KOps/s 80.7901 KOps/s $\color{#d91a1a}-0.75\%$
test_values[generalized_advantage_estimate-True-True] 10.3892ms 9.9242ms 100.7639 Ops/s 98.0221 Ops/s $\color{#35bf28}+2.80\%$
test_values[vec_generalized_advantage_estimate-True-True] 43.0330ms 39.0431ms 25.6127 Ops/s 28.1237 Ops/s $\textbf{\color{#d91a1a}-8.93\%}$
test_values[td0_return_estimate-False-False] 0.4540ms 0.2423ms 4.1264 KOps/s 4.7329 KOps/s $\textbf{\color{#d91a1a}-12.81\%}$
test_values[td1_return_estimate-False-False] 28.1299ms 24.8157ms 40.2971 Ops/s 40.4491 Ops/s $\color{#d91a1a}-0.38\%$
test_values[vec_td1_return_estimate-False-False] 40.8361ms 38.8582ms 25.7346 Ops/s 27.6713 Ops/s $\textbf{\color{#d91a1a}-7.00\%}$
test_values[td_lambda_return_estimate-True-False] 39.0637ms 35.3947ms 28.2528 Ops/s 28.0772 Ops/s $\color{#35bf28}+0.63\%$
test_values[vec_td_lambda_return_estimate-True-False] 43.5881ms 39.4364ms 25.3573 Ops/s 27.6798 Ops/s $\textbf{\color{#d91a1a}-8.39\%}$
test_gae_speed[generalized_advantage_estimate-False-1-512] 11.7785ms 8.5930ms 116.3734 Ops/s 114.8905 Ops/s $\color{#35bf28}+1.29\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.6861ms 2.0880ms 478.9290 Ops/s 469.2867 Ops/s $\color{#35bf28}+2.05\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.4832ms 0.3644ms 2.7440 KOps/s 2.7046 KOps/s $\color{#35bf28}+1.46\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 57.4776ms 52.1905ms 19.1606 Ops/s 20.3427 Ops/s $\textbf{\color{#d91a1a}-5.81\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 4.6736ms 3.4811ms 287.2688 Ops/s 280.3888 Ops/s $\color{#35bf28}+2.45\%$
test_dqn_speed 8.4284ms 1.6947ms 590.0755 Ops/s 639.1055 Ops/s $\textbf{\color{#d91a1a}-7.67\%}$
test_ddpg_speed 4.0437ms 3.2357ms 309.0566 Ops/s 311.7616 Ops/s $\color{#d91a1a}-0.87\%$
test_sac_speed 14.6433ms 11.1339ms 89.8155 Ops/s 93.1220 Ops/s $\color{#d91a1a}-3.55\%$
test_redq_speed 19.1201ms 16.0185ms 62.4278 Ops/s 60.7034 Ops/s $\color{#35bf28}+2.84\%$
test_redq_deprec_speed 18.7861ms 16.7692ms 59.6333 Ops/s 60.3701 Ops/s $\color{#d91a1a}-1.22\%$
test_td3_speed 12.4176ms 11.1191ms 89.9351 Ops/s 88.0696 Ops/s $\color{#35bf28}+2.12\%$
test_cql_speed 46.8780ms 44.4151ms 22.5149 Ops/s 22.9019 Ops/s $\color{#d91a1a}-1.69\%$
test_a2c_speed 10.0187ms 8.9412ms 111.8424 Ops/s 107.3943 Ops/s $\color{#35bf28}+4.14\%$
test_ppo_speed 10.5099ms 9.3773ms 106.6409 Ops/s 106.9648 Ops/s $\color{#d91a1a}-0.30\%$
test_reinforce_speed 8.4010ms 7.5650ms 132.1872 Ops/s 123.2195 Ops/s $\textbf{\color{#35bf28}+7.28\%}$
test_iql_speed 0.1336s 41.6892ms 23.9870 Ops/s 26.0509 Ops/s $\textbf{\color{#d91a1a}-7.92\%}$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 4.9026ms 3.1763ms 314.8326 Ops/s 304.9060 Ops/s $\color{#35bf28}+3.26\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.1957ms 0.5713ms 1.7505 KOps/s 1.5132 KOps/s $\textbf{\color{#35bf28}+15.68\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7728ms 0.5397ms 1.8529 KOps/s 1.8642 KOps/s $\color{#d91a1a}-0.61\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 4.3535ms 3.3465ms 298.8159 Ops/s 318.5447 Ops/s $\textbf{\color{#d91a1a}-6.19\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.4098ms 0.5551ms 1.8013 KOps/s 1.8100 KOps/s $\color{#d91a1a}-0.48\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7110ms 0.5182ms 1.9298 KOps/s 1.8796 KOps/s $\color{#35bf28}+2.68\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.9893ms 1.4666ms 681.8551 Ops/s 707.3672 Ops/s $\color{#d91a1a}-3.61\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 5.4984ms 1.3678ms 731.1113 Ops/s 732.5605 Ops/s $\color{#d91a1a}-0.20\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 5.2615ms 3.8120ms 262.3326 Ops/s 291.5847 Ops/s $\textbf{\color{#d91a1a}-10.03\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.9050ms 0.6931ms 1.4427 KOps/s 1.4571 KOps/s $\color{#d91a1a}-0.98\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 4.1133ms 0.6525ms 1.5326 KOps/s 1.4668 KOps/s $\color{#35bf28}+4.48\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 5.7195ms 3.4404ms 290.6636 Ops/s 298.7929 Ops/s $\color{#d91a1a}-2.72\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.6441ms 0.5720ms 1.7483 KOps/s 1.7297 KOps/s $\color{#35bf28}+1.08\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7125ms 0.5366ms 1.8635 KOps/s 1.8651 KOps/s $\color{#d91a1a}-0.09\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 4.6413ms 3.3832ms 295.5769 Ops/s 319.2054 Ops/s $\textbf{\color{#d91a1a}-7.40\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7468ms 0.5545ms 1.8035 KOps/s 1.8409 KOps/s $\color{#d91a1a}-2.04\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 4.4559ms 0.5225ms 1.9138 KOps/s 1.9047 KOps/s $\color{#35bf28}+0.48\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 5.4454ms 3.6350ms 275.1058 Ops/s 268.3616 Ops/s $\color{#35bf28}+2.51\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.6263ms 0.6940ms 1.4409 KOps/s 1.4658 KOps/s $\color{#d91a1a}-1.70\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8258ms 0.6404ms 1.5616 KOps/s 1.5625 KOps/s $\color{#d91a1a}-0.06\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1408s 7.8221ms 127.8424 Ops/s 98.8494 Ops/s $\textbf{\color{#35bf28}+29.33\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 0.1392s 17.0944ms 58.4987 Ops/s 68.4387 Ops/s $\textbf{\color{#d91a1a}-14.52\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 2.2295ms 1.2710ms 786.7793 Ops/s 795.8905 Ops/s $\color{#d91a1a}-1.14\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1223s 7.0199ms 142.4527 Ops/s 107.9339 Ops/s $\textbf{\color{#35bf28}+31.98\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 17.5707ms 14.3647ms 69.6153 Ops/s 68.9703 Ops/s $\color{#35bf28}+0.94\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 5.3578ms 1.4104ms 709.0291 Ops/s 801.2911 Ops/s $\textbf{\color{#d91a1a}-11.51\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1427s 11.2357ms 89.0018 Ops/s 170.7510 Ops/s $\textbf{\color{#d91a1a}-47.88\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 17.9111ms 14.6582ms 68.2210 Ops/s 66.6435 Ops/s $\color{#35bf28}+2.37\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 5.4107ms 1.7725ms 564.1765 Ops/s 612.3425 Ops/s $\textbf{\color{#d91a1a}-7.87\%}$

@github-actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 94. Improved: $\large\color{#35bf28}9$. Worsened: $\large\color{#d91a1a}3$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 99.7364ms 98.2222ms 10.1810 Ops/s 9.4970 Ops/s $\textbf{\color{#35bf28}+7.20\%}$
test_sync 88.9064ms 86.9173ms 11.5052 Ops/s 11.4002 Ops/s $\color{#35bf28}+0.92\%$
test_async 0.1728s 85.7868ms 11.6568 Ops/s 13.8392 Ops/s $\textbf{\color{#d91a1a}-15.77\%}$
test_single_pixels 0.1796s 0.1167s 8.5726 Ops/s 8.9971 Ops/s $\color{#d91a1a}-4.72\%$
test_sync_pixels 75.6409ms 67.2751ms 14.8643 Ops/s 15.1759 Ops/s $\color{#d91a1a}-2.05\%$
test_async_pixels 0.1216s 55.1022ms 18.1481 Ops/s 18.0236 Ops/s $\color{#35bf28}+0.69\%$
test_simple 0.6624s 0.6413s 1.5594 Ops/s 1.4546 Ops/s $\textbf{\color{#35bf28}+7.21\%}$
test_transformed 0.9056s 0.8524s 1.1731 Ops/s 1.1166 Ops/s $\textbf{\color{#35bf28}+5.06\%}$
test_serial 2.0954s 2.0753s 0.4818 Ops/s 0.4816 Ops/s $\color{#35bf28}+0.04\%$
test_parallel 1.8271s 1.7807s 0.5616 Ops/s 0.5476 Ops/s $\color{#35bf28}+2.56\%$
test_step_mdp_speed[True-True-True-True-True] 0.1066ms 32.8341μs 30.4562 KOps/s 30.6885 KOps/s $\color{#d91a1a}-0.76\%$
test_step_mdp_speed[True-True-True-True-False] 38.9010μs 19.4021μs 51.5409 KOps/s 51.2276 KOps/s $\color{#35bf28}+0.61\%$
test_step_mdp_speed[True-True-True-False-True] 36.6300μs 18.0575μs 55.3787 KOps/s 53.6150 KOps/s $\color{#35bf28}+3.29\%$
test_step_mdp_speed[True-True-True-False-False] 25.6100μs 10.9926μs 90.9704 KOps/s 90.7599 KOps/s $\color{#35bf28}+0.23\%$
test_step_mdp_speed[True-True-False-True-True] 53.1700μs 34.2072μs 29.2336 KOps/s 29.1471 KOps/s $\color{#35bf28}+0.30\%$
test_step_mdp_speed[True-True-False-True-False] 47.4610μs 21.4666μs 46.5841 KOps/s 47.0551 KOps/s $\color{#d91a1a}-1.00\%$
test_step_mdp_speed[True-True-False-False-True] 39.0810μs 20.0858μs 49.7864 KOps/s 49.0437 KOps/s $\color{#35bf28}+1.51\%$
test_step_mdp_speed[True-True-False-False-False] 28.9010μs 12.7999μs 78.1255 KOps/s 77.2852 KOps/s $\color{#35bf28}+1.09\%$
test_step_mdp_speed[True-False-True-True-True] 60.1910μs 36.0992μs 27.7014 KOps/s 27.3271 KOps/s $\color{#35bf28}+1.37\%$
test_step_mdp_speed[True-False-True-True-False] 44.5220μs 23.1677μs 43.1635 KOps/s 42.8247 KOps/s $\color{#35bf28}+0.79\%$
test_step_mdp_speed[True-False-True-False-True] 35.1200μs 19.7228μs 50.7028 KOps/s 49.3979 KOps/s $\color{#35bf28}+2.64\%$
test_step_mdp_speed[True-False-True-False-False] 38.3700μs 12.8530μs 77.8031 KOps/s 78.0304 KOps/s $\color{#d91a1a}-0.29\%$
test_step_mdp_speed[True-False-False-True-True] 62.9810μs 38.1751μs 26.1951 KOps/s 26.5216 KOps/s $\color{#d91a1a}-1.23\%$
test_step_mdp_speed[True-False-False-True-False] 41.9300μs 25.1267μs 39.7983 KOps/s 40.2088 KOps/s $\color{#d91a1a}-1.02\%$
test_step_mdp_speed[True-False-False-False-True] 36.5810μs 21.5851μs 46.3282 KOps/s 45.7132 KOps/s $\color{#35bf28}+1.35\%$
test_step_mdp_speed[True-False-False-False-False] 33.1800μs 14.5980μs 68.5025 KOps/s 67.3919 KOps/s $\color{#35bf28}+1.65\%$
test_step_mdp_speed[False-True-True-True-True] 59.4510μs 36.5165μs 27.3849 KOps/s 27.6040 KOps/s $\color{#d91a1a}-0.79\%$
test_step_mdp_speed[False-True-True-True-False] 44.5010μs 23.1797μs 43.1412 KOps/s 42.9754 KOps/s $\color{#35bf28}+0.39\%$
test_step_mdp_speed[False-True-True-False-True] 43.0810μs 23.4277μs 42.6846 KOps/s 40.6741 KOps/s $\color{#35bf28}+4.94\%$
test_step_mdp_speed[False-True-True-False-False] 31.1110μs 14.5783μs 68.5949 KOps/s 67.1511 KOps/s $\color{#35bf28}+2.15\%$
test_step_mdp_speed[False-True-False-True-True] 61.8910μs 37.6996μs 26.5255 KOps/s 26.2086 KOps/s $\color{#35bf28}+1.21\%$
test_step_mdp_speed[False-True-False-True-False] 76.2810μs 25.1889μs 39.7000 KOps/s 39.8889 KOps/s $\color{#d91a1a}-0.47\%$
test_step_mdp_speed[False-True-False-False-True] 53.3210μs 25.9807μs 38.4902 KOps/s 38.8347 KOps/s $\color{#d91a1a}-0.89\%$
test_step_mdp_speed[False-True-False-False-False] 32.6610μs 16.4328μs 60.8539 KOps/s 59.8962 KOps/s $\color{#35bf28}+1.60\%$
test_step_mdp_speed[False-False-True-True-True] 63.8610μs 40.0304μs 24.9810 KOps/s 24.8248 KOps/s $\color{#35bf28}+0.63\%$
test_step_mdp_speed[False-False-True-True-False] 46.7210μs 27.2310μs 36.7228 KOps/s 37.0147 KOps/s $\color{#d91a1a}-0.79\%$
test_step_mdp_speed[False-False-True-False-True] 45.1110μs 26.0609μs 38.3717 KOps/s 38.9997 KOps/s $\color{#d91a1a}-1.61\%$
test_step_mdp_speed[False-False-True-False-False] 47.0110μs 16.6290μs 60.1359 KOps/s 61.1376 KOps/s $\color{#d91a1a}-1.64\%$
test_step_mdp_speed[False-False-False-True-True] 93.5720μs 41.6845μs 23.9897 KOps/s 24.4164 KOps/s $\color{#d91a1a}-1.75\%$
test_step_mdp_speed[False-False-False-True-False] 54.8310μs 28.7317μs 34.8048 KOps/s 34.8301 KOps/s $\color{#d91a1a}-0.07\%$
test_step_mdp_speed[False-False-False-False-True] 46.8020μs 26.8454μs 37.2503 KOps/s 35.5280 KOps/s $\color{#35bf28}+4.85\%$
test_step_mdp_speed[False-False-False-False-False] 38.1010μs 17.9989μs 55.5589 KOps/s 54.4680 KOps/s $\color{#35bf28}+2.00\%$
test_values[generalized_advantage_estimate-True-True] 24.3506ms 23.1906ms 43.1210 Ops/s 43.3612 Ops/s $\color{#d91a1a}-0.55\%$
test_values[vec_generalized_advantage_estimate-True-True] 82.8485ms 3.1975ms 312.7478 Ops/s 312.4617 Ops/s $\color{#35bf28}+0.09\%$
test_values[td0_return_estimate-False-False] 89.8310μs 60.4690μs 16.5374 KOps/s 16.2053 KOps/s $\color{#35bf28}+2.05\%$
test_values[td1_return_estimate-False-False] 50.1634ms 48.9217ms 20.4408 Ops/s 20.1539 Ops/s $\color{#35bf28}+1.42\%$
test_values[vec_td1_return_estimate-False-False] 2.0597ms 1.7289ms 578.3884 Ops/s 580.3776 Ops/s $\color{#d91a1a}-0.34\%$
test_values[td_lambda_return_estimate-True-False] 79.5492ms 77.9697ms 12.8255 Ops/s 12.6692 Ops/s $\color{#35bf28}+1.23\%$
test_values[vec_td_lambda_return_estimate-True-False] 2.0884ms 1.7190ms 581.7180 Ops/s 581.1097 Ops/s $\color{#35bf28}+0.10\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 21.4034ms 21.0977ms 47.3985 Ops/s 46.6916 Ops/s $\color{#35bf28}+1.51\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.8616ms 0.6474ms 1.5446 KOps/s 1.5013 KOps/s $\color{#35bf28}+2.88\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.6566ms 0.6114ms 1.6355 KOps/s 1.5877 KOps/s $\color{#35bf28}+3.01\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.4650ms 1.4147ms 706.8507 Ops/s 702.1025 Ops/s $\color{#35bf28}+0.68\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.9251ms 0.6366ms 1.5709 KOps/s 1.5906 KOps/s $\color{#d91a1a}-1.24\%$
test_dqn_speed 1.7946ms 1.3747ms 727.4107 Ops/s 718.9643 Ops/s $\color{#35bf28}+1.17\%$
test_ddpg_speed 2.9368ms 2.6216ms 381.4507 Ops/s 370.9019 Ops/s $\color{#35bf28}+2.84\%$
test_sac_speed 8.4657ms 7.7288ms 129.3857 Ops/s 127.1097 Ops/s $\color{#35bf28}+1.79\%$
test_redq_speed 10.8850ms 9.9329ms 100.6758 Ops/s 98.0526 Ops/s $\color{#35bf28}+2.68\%$
test_redq_deprec_speed 12.8741ms 10.9764ms 91.1046 Ops/s 88.2579 Ops/s $\color{#35bf28}+3.23\%$
test_td3_speed 7.7603ms 7.6296ms 131.0685 Ops/s 126.7841 Ops/s $\color{#35bf28}+3.38\%$
test_cql_speed 25.9294ms 24.9705ms 40.0473 Ops/s 39.6053 Ops/s $\color{#35bf28}+1.12\%$
test_a2c_speed 5.7910ms 5.4709ms 182.7854 Ops/s 179.9477 Ops/s $\color{#35bf28}+1.58\%$
test_ppo_speed 6.0002ms 5.7798ms 173.0161 Ops/s 171.0259 Ops/s $\color{#35bf28}+1.16\%$
test_reinforce_speed 5.2694ms 4.4158ms 226.4597 Ops/s 215.7071 Ops/s $\color{#35bf28}+4.98\%$
test_iql_speed 19.3043ms 18.6978ms 53.4823 Ops/s 51.9887 Ops/s $\color{#35bf28}+2.87\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.9408ms 2.8156ms 355.1608 Ops/s 345.5837 Ops/s $\color{#35bf28}+2.77\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.2926ms 0.5363ms 1.8648 KOps/s 1.8331 KOps/s $\color{#35bf28}+1.73\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7179ms 0.5127ms 1.9503 KOps/s 1.9182 KOps/s $\color{#35bf28}+1.67\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.9729ms 2.8039ms 356.6430 Ops/s 344.6496 Ops/s $\color{#35bf28}+3.48\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.6562ms 0.5263ms 1.8999 KOps/s 1.8572 KOps/s $\color{#35bf28}+2.30\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.1074s 0.5991ms 1.6690 KOps/s 1.9473 KOps/s $\textbf{\color{#d91a1a}-14.29\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.5945ms 1.4487ms 690.2879 Ops/s 671.3639 Ops/s $\color{#35bf28}+2.82\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.6103ms 1.3891ms 719.8889 Ops/s 697.7831 Ops/s $\color{#35bf28}+3.17\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.0253ms 2.9511ms 338.8535 Ops/s 333.1543 Ops/s $\color{#35bf28}+1.71\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.2144ms 0.6584ms 1.5188 KOps/s 1.4880 KOps/s $\color{#35bf28}+2.07\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8966ms 0.6553ms 1.5261 KOps/s 1.3563 KOps/s $\textbf{\color{#35bf28}+12.52\%}$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.3544ms 2.8583ms 349.8610 Ops/s 347.2237 Ops/s $\color{#35bf28}+0.76\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.6705ms 0.5541ms 1.8049 KOps/s 1.8144 KOps/s $\color{#d91a1a}-0.53\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 4.5275ms 0.5316ms 1.8812 KOps/s 1.9166 KOps/s $\color{#d91a1a}-1.85\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.0052ms 2.8577ms 349.9288 Ops/s 348.2136 Ops/s $\color{#35bf28}+0.49\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7067ms 0.5411ms 1.8482 KOps/s 1.8479 KOps/s $\color{#35bf28}+0.02\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6901ms 0.5228ms 1.9130 KOps/s 1.5140 KOps/s $\textbf{\color{#35bf28}+26.35\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.1720ms 2.9995ms 333.3902 Ops/s 334.0191 Ops/s $\color{#d91a1a}-0.19\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.3518ms 0.6672ms 1.4987 KOps/s 1.4900 KOps/s $\color{#35bf28}+0.58\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8325ms 0.6431ms 1.5549 KOps/s 1.5423 KOps/s $\color{#35bf28}+0.82\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1212s 7.0008ms 142.8417 Ops/s 115.4844 Ops/s $\textbf{\color{#35bf28}+23.69\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 19.3816ms 14.2017ms 70.4139 Ops/s 68.0864 Ops/s $\color{#35bf28}+3.42\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 2.4018ms 1.1395ms 877.5724 Ops/s 851.0505 Ops/s $\color{#35bf28}+3.12\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1011s 8.4715ms 118.0432 Ops/s 148.8921 Ops/s $\textbf{\color{#d91a1a}-20.72\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 16.1788ms 14.0480ms 71.1845 Ops/s 68.4895 Ops/s $\color{#35bf28}+3.93\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 2.0972ms 1.0762ms 929.1697 Ops/s 871.2821 Ops/s $\textbf{\color{#35bf28}+6.64\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 99.6158ms 6.9333ms 144.2317 Ops/s 111.7455 Ops/s $\textbf{\color{#35bf28}+29.07\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 17.0738ms 14.6223ms 68.3885 Ops/s 66.8192 Ops/s $\color{#35bf28}+2.35\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 2.4433ms 1.4233ms 702.5813 Ops/s 619.3900 Ops/s $\textbf{\color{#35bf28}+13.43\%}$

@vmoens
Copy link
Collaborator Author

vmoens commented Mar 18, 2024

cc @albertbou92 upgrading the GPU jobs to 3.10 makes the Ray jobs fail, but the 3.8 is starting to fail on its own due to Hydra issues (see #2014).
Any clue on what I should do here?

@vmoens vmoens added the CI Has to do with CI setup (e.g. wheels & builds, tests...) label Mar 18, 2024
@albertbou92
Copy link
Contributor

albertbou92 commented Mar 18, 2024

This solution solves the problem in #1862 -> #2015

@vmoens vmoens merged commit 77d2fc9 into main Mar 18, 2024
SandishKumarHN pushed a commit to SandishKumarHN/rl that referenced this pull request Mar 18, 2024
vmoens pushed a commit that referenced this pull request Mar 25, 2024
@vmoens vmoens deleted the upgrade-3.8 branch April 3, 2024 06:04
vmoens pushed a commit that referenced this pull request Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Has to do with CI setup (e.g. wheels & builds, tests...) CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants