Skip to content

[BugFix] union -> intersection in _StepMDP check #2039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2024
Merged

[BugFix] union -> intersection in _StepMDP check #2039

merged 1 commit into from
Mar 25, 2024

Conversation

@vmoens
Copy link
Collaborator

@vmoens vmoens commented Mar 25, 2024

No description provided.

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 25, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2039

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 3 New Failures, 21 Unrelated Failures

As of commit 812bcd7 with merge base 1fcd3e3 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 25, 2024
@vmoens vmoens merged commit 247ed6e into main Mar 25, 2024
@vmoens vmoens added the bug Something isn't working label Mar 25, 2024
@github-actions
Copy link

github-actions bot commented Mar 25, 2024

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 91. Improved: $\large\color{#35bf28}7$. Worsened: $\large\color{#d91a1a}2$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 51.8795ms 51.0880ms 19.5741 Ops/s 17.5270 Ops/s $\textbf{\color{#35bf28}+11.68\%}$
test_sync 35.9428ms 29.9258ms 33.4160 Ops/s 34.0393 Ops/s $\color{#d91a1a}-1.83\%$
test_async 52.2986ms 26.4861ms 37.7556 Ops/s 35.9363 Ops/s $\textbf{\color{#35bf28}+5.06\%}$
test_simple 0.3324s 0.3291s 3.0387 Ops/s 2.8791 Ops/s $\textbf{\color{#35bf28}+5.54\%}$
test_transformed 0.5357s 0.4817s 2.0758 Ops/s 2.0669 Ops/s $\color{#35bf28}+0.43\%$
test_serial 1.2470s 1.1920s 0.8390 Ops/s 0.8247 Ops/s $\color{#35bf28}+1.72\%$
test_parallel 1.0483s 0.9926s 1.0075 Ops/s 0.9612 Ops/s $\color{#35bf28}+4.81\%$
test_step_mdp_speed[True-True-True-True-True] 49.5230μs 21.0739μs 47.4521 KOps/s 47.7631 KOps/s $\color{#d91a1a}-0.65\%$
test_step_mdp_speed[True-True-True-True-False] 38.7320μs 12.9522μs 77.2069 KOps/s 78.3465 KOps/s $\color{#d91a1a}-1.45\%$
test_step_mdp_speed[True-True-True-False-True] 33.6020μs 12.2163μs 81.8581 KOps/s 82.3641 KOps/s $\color{#d91a1a}-0.61\%$
test_step_mdp_speed[True-True-True-False-False] 54.9230μs 7.5708μs 132.0868 KOps/s 134.4170 KOps/s $\color{#d91a1a}-1.73\%$
test_step_mdp_speed[True-True-False-True-True] 53.0090μs 22.1123μs 45.2236 KOps/s 45.1551 KOps/s $\color{#35bf28}+0.15\%$
test_step_mdp_speed[True-True-False-True-False] 57.5240μs 14.1191μs 70.8261 KOps/s 71.8340 KOps/s $\color{#d91a1a}-1.40\%$
test_step_mdp_speed[True-True-False-False-True] 30.3570μs 13.3259μs 75.0418 KOps/s 74.5316 KOps/s $\color{#35bf28}+0.68\%$
test_step_mdp_speed[True-True-False-False-False] 33.9030μs 8.7291μs 114.5599 KOps/s 115.9722 KOps/s $\color{#d91a1a}-1.22\%$
test_step_mdp_speed[True-False-True-True-True] 72.3450μs 23.1793μs 43.1419 KOps/s 42.8875 KOps/s $\color{#35bf28}+0.59\%$
test_step_mdp_speed[True-False-True-True-False] 47.6480μs 15.3970μs 64.9477 KOps/s 65.8028 KOps/s $\color{#d91a1a}-1.30\%$
test_step_mdp_speed[True-False-True-False-True] 53.2490μs 13.4931μs 74.1119 KOps/s 74.7937 KOps/s $\color{#d91a1a}-0.91\%$
test_step_mdp_speed[True-False-True-False-False] 38.7720μs 8.7778μs 113.9235 KOps/s 116.1610 KOps/s $\color{#d91a1a}-1.93\%$
test_step_mdp_speed[True-False-False-True-True] 62.0350μs 24.4256μs 40.9406 KOps/s 40.6041 KOps/s $\color{#35bf28}+0.83\%$
test_step_mdp_speed[True-False-False-True-False] 47.2380μs 16.6314μs 60.1272 KOps/s 60.4945 KOps/s $\color{#d91a1a}-0.61\%$
test_step_mdp_speed[True-False-False-False-True] 58.8000μs 14.3662μs 69.6080 KOps/s 68.8497 KOps/s $\color{#35bf28}+1.10\%$
test_step_mdp_speed[True-False-False-False-False] 34.9750μs 9.9058μs 100.9513 KOps/s 101.4137 KOps/s $\color{#d91a1a}-0.46\%$
test_step_mdp_speed[False-True-True-True-True] 0.1045ms 23.7937μs 42.0280 KOps/s 42.3870 KOps/s $\color{#d91a1a}-0.85\%$
test_step_mdp_speed[False-True-True-True-False] 61.4950μs 15.5321μs 64.3827 KOps/s 64.8172 KOps/s $\color{#d91a1a}-0.67\%$
test_step_mdp_speed[False-True-True-False-True] 43.2730μs 15.5306μs 64.3889 KOps/s 63.3047 KOps/s $\color{#35bf28}+1.71\%$
test_step_mdp_speed[False-True-True-False-False] 33.2920μs 9.9268μs 100.7371 KOps/s 101.2397 KOps/s $\color{#d91a1a}-0.50\%$
test_step_mdp_speed[False-True-False-True-True] 55.6440μs 25.0311μs 39.9502 KOps/s 39.6946 KOps/s $\color{#35bf28}+0.64\%$
test_step_mdp_speed[False-True-False-True-False] 44.5840μs 16.7285μs 59.7782 KOps/s 60.3987 KOps/s $\color{#d91a1a}-1.03\%$
test_step_mdp_speed[False-True-False-False-True] 35.5960μs 16.6804μs 59.9507 KOps/s 59.3995 KOps/s $\color{#35bf28}+0.93\%$
test_step_mdp_speed[False-True-False-False-False] 32.5700μs 11.0517μs 90.4842 KOps/s 90.5794 KOps/s $\color{#d91a1a}-0.11\%$
test_step_mdp_speed[False-False-True-True-True] 59.6410μs 25.9361μs 38.5563 KOps/s 38.6564 KOps/s $\color{#d91a1a}-0.26\%$
test_step_mdp_speed[False-False-True-True-False] 83.3860μs 17.7903μs 56.2103 KOps/s 56.4438 KOps/s $\color{#d91a1a}-0.41\%$
test_step_mdp_speed[False-False-True-False-True] 50.3740μs 16.6190μs 60.1722 KOps/s 59.4166 KOps/s $\color{#35bf28}+1.27\%$
test_step_mdp_speed[False-False-True-False-False] 37.6600μs 11.0054μs 90.8649 KOps/s 90.1991 KOps/s $\color{#35bf28}+0.74\%$
test_step_mdp_speed[False-False-False-True-True] 75.0480μs 26.7802μs 37.3410 KOps/s 37.0394 KOps/s $\color{#35bf28}+0.81\%$
test_step_mdp_speed[False-False-False-True-False] 43.4610μs 18.8599μs 53.0226 KOps/s 53.3238 KOps/s $\color{#d91a1a}-0.56\%$
test_step_mdp_speed[False-False-False-False-True] 47.8290μs 17.7255μs 56.4160 KOps/s 55.3372 KOps/s $\color{#35bf28}+1.95\%$
test_step_mdp_speed[False-False-False-False-False] 34.6750μs 12.1835μs 82.0781 KOps/s 82.2838 KOps/s $\color{#d91a1a}-0.25\%$
test_values[generalized_advantage_estimate-True-True] 10.0661ms 9.6032ms 104.1318 Ops/s 108.1156 Ops/s $\color{#d91a1a}-3.68\%$
test_values[vec_generalized_advantage_estimate-True-True] 38.4372ms 35.7205ms 27.9951 Ops/s 27.7631 Ops/s $\color{#35bf28}+0.84\%$
test_values[td0_return_estimate-False-False] 0.2720ms 0.1649ms 6.0648 KOps/s 5.9965 KOps/s $\color{#35bf28}+1.14\%$
test_values[td1_return_estimate-False-False] 26.9074ms 23.6497ms 42.2839 Ops/s 43.4140 Ops/s $\color{#d91a1a}-2.60\%$
test_values[vec_td1_return_estimate-False-False] 37.3828ms 35.8862ms 27.8658 Ops/s 27.6377 Ops/s $\color{#35bf28}+0.83\%$
test_values[td_lambda_return_estimate-True-False] 37.3417ms 34.1101ms 29.3168 Ops/s 29.7833 Ops/s $\color{#d91a1a}-1.57\%$
test_values[vec_td_lambda_return_estimate-True-False] 38.7494ms 35.9560ms 27.8117 Ops/s 27.7447 Ops/s $\color{#35bf28}+0.24\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 8.5065ms 8.2333ms 121.4581 Ops/s 122.5876 Ops/s $\color{#d91a1a}-0.92\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.3224ms 2.0460ms 488.7587 Ops/s 489.2641 Ops/s $\color{#d91a1a}-0.10\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.5266ms 0.3510ms 2.8493 KOps/s 2.8488 KOps/s $\color{#35bf28}+0.02\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 50.8925ms 48.3947ms 20.6634 Ops/s 20.4356 Ops/s $\color{#35bf28}+1.11\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 3.7017ms 3.0188ms 331.2622 Ops/s 330.8605 Ops/s $\color{#35bf28}+0.12\%$
test_dqn_speed 7.8799ms 1.3782ms 725.5951 Ops/s 678.1367 Ops/s $\textbf{\color{#35bf28}+7.00\%}$
test_ddpg_speed 3.4529ms 2.7272ms 366.6799 Ops/s 369.5805 Ops/s $\color{#d91a1a}-0.78\%$
test_sac_speed 9.8124ms 8.3119ms 120.3092 Ops/s 120.5577 Ops/s $\color{#d91a1a}-0.21\%$
test_redq_speed 15.4711ms 13.2877ms 75.2573 Ops/s 72.9529 Ops/s $\color{#35bf28}+3.16\%$
test_redq_deprec_speed 14.5334ms 13.0652ms 76.5395 Ops/s 76.8790 Ops/s $\color{#d91a1a}-0.44\%$
test_td3_speed 17.1385ms 8.2835ms 120.7224 Ops/s 121.8269 Ops/s $\color{#d91a1a}-0.91\%$
test_cql_speed 37.4898ms 36.2494ms 27.5867 Ops/s 27.7347 Ops/s $\color{#d91a1a}-0.53\%$
test_a2c_speed 8.3869ms 7.3342ms 136.3467 Ops/s 136.3333 Ops/s $+0.01\%$
test_ppo_speed 8.1747ms 7.6399ms 130.8916 Ops/s 130.9021 Ops/s $-0.01\%$
test_reinforce_speed 6.8670ms 6.5269ms 153.2110 Ops/s 152.4006 Ops/s $\color{#35bf28}+0.53\%$
test_iql_speed 34.1808ms 32.5406ms 30.7309 Ops/s 30.4021 Ops/s $\color{#35bf28}+1.08\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.6802ms 2.2923ms 436.2402 Ops/s 443.6185 Ops/s $\color{#d91a1a}-1.66\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.0639ms 0.4892ms 2.0440 KOps/s 2.0248 KOps/s $\color{#35bf28}+0.95\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7534ms 0.4672ms 2.1404 KOps/s 2.1328 KOps/s $\color{#35bf28}+0.36\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.3939ms 2.1931ms 455.9756 Ops/s 422.0171 Ops/s $\textbf{\color{#35bf28}+8.05\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7566ms 0.4843ms 2.0647 KOps/s 2.0206 KOps/s $\color{#35bf28}+2.18\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7636ms 0.4567ms 2.1898 KOps/s 2.1611 KOps/s $\color{#35bf28}+1.32\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 2.1915ms 1.2093ms 826.8983 Ops/s 818.5989 Ops/s $\color{#35bf28}+1.01\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 4.3428ms 1.1525ms 867.7148 Ops/s 865.4463 Ops/s $\color{#35bf28}+0.26\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.0159ms 2.2656ms 441.3775 Ops/s 416.5210 Ops/s $\textbf{\color{#35bf28}+5.97\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.1052s 0.6888ms 1.4517 KOps/s 1.6365 KOps/s $\textbf{\color{#d91a1a}-11.29\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8413ms 0.5798ms 1.7248 KOps/s 1.7186 KOps/s $\color{#35bf28}+0.36\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.1859ms 2.1785ms 459.0373 Ops/s 447.0455 Ops/s $\color{#35bf28}+2.68\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.1073ms 0.4934ms 2.0268 KOps/s 2.0078 KOps/s $\color{#35bf28}+0.95\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6322ms 0.4641ms 2.1548 KOps/s 2.1598 KOps/s $\color{#d91a1a}-0.23\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.7101ms 2.2056ms 453.3934 Ops/s 458.4679 Ops/s $\color{#d91a1a}-1.11\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.8477ms 0.4846ms 2.0637 KOps/s 2.0656 KOps/s $\color{#d91a1a}-0.09\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 4.1592ms 0.4681ms 2.1363 KOps/s 2.1357 KOps/s $\color{#35bf28}+0.03\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.3429ms 2.3147ms 432.0295 Ops/s 438.0085 Ops/s $\color{#d91a1a}-1.37\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.7448ms 0.6083ms 1.6439 KOps/s 1.6537 KOps/s $\color{#d91a1a}-0.60\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8470ms 0.5883ms 1.6999 KOps/s 1.7031 KOps/s $\color{#d91a1a}-0.19\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1190s 7.9414ms 125.9226 Ops/s 125.7830 Ops/s $\color{#35bf28}+0.11\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 14.7931ms 11.9714ms 83.5324 Ops/s 82.8054 Ops/s $\color{#35bf28}+0.88\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 1.1063ms 1.0335ms 967.6157 Ops/s 931.2189 Ops/s $\color{#35bf28}+3.91\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1049s 5.6962ms 175.5569 Ops/s 178.4820 Ops/s $\color{#d91a1a}-1.64\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 14.2600ms 11.9596ms 83.6149 Ops/s 72.2124 Ops/s $\textbf{\color{#35bf28}+15.79\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 1.6459ms 1.0981ms 910.6313 Ops/s 867.4697 Ops/s $\color{#35bf28}+4.98\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1136s 8.1971ms 121.9937 Ops/s 162.6471 Ops/s $\textbf{\color{#d91a1a}-24.99\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 14.8751ms 12.2841ms 81.4058 Ops/s 81.7196 Ops/s $\color{#d91a1a}-0.38\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 4.5720ms 1.4802ms 675.5953 Ops/s 696.6673 Ops/s $\color{#d91a1a}-3.02\%$

@github-actions
Copy link

github-actions bot commented Mar 25, 2024

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 94. Improved: $\large\color{#35bf28}5$. Worsened: $\large\color{#d91a1a}4$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1010s 99.8542ms 10.0146 Ops/s 9.2364 Ops/s $\textbf{\color{#35bf28}+8.43\%}$
test_sync 93.5857ms 87.0734ms 11.4846 Ops/s 11.0819 Ops/s $\color{#35bf28}+3.63\%$
test_async 0.1616s 70.5181ms 14.1808 Ops/s 11.6291 Ops/s $\textbf{\color{#35bf28}+21.94\%}$
test_single_pixels 0.1083s 0.1079s 9.2698 Ops/s 9.2206 Ops/s $\color{#35bf28}+0.53\%$
test_sync_pixels 66.3914ms 65.1735ms 15.3437 Ops/s 14.8391 Ops/s $\color{#35bf28}+3.40\%$
test_async_pixels 0.1216s 55.3490ms 18.0672 Ops/s 17.8746 Ops/s $\color{#35bf28}+1.08\%$
test_simple 0.7473s 0.6777s 1.4755 Ops/s 1.5222 Ops/s $\color{#d91a1a}-3.07\%$
test_transformed 0.9507s 0.8847s 1.1303 Ops/s 1.1868 Ops/s $\color{#d91a1a}-4.76\%$
test_serial 2.1566s 2.0907s 0.4783 Ops/s 0.4986 Ops/s $\color{#d91a1a}-4.06\%$
test_parallel 1.8379s 1.7615s 0.5677 Ops/s 0.5573 Ops/s $\color{#35bf28}+1.87\%$
test_step_mdp_speed[True-True-True-True-True] 54.2720μs 32.2849μs 30.9743 KOps/s 30.5965 KOps/s $\color{#35bf28}+1.23\%$
test_step_mdp_speed[True-True-True-True-False] 36.3620μs 19.7785μs 50.5599 KOps/s 51.3342 KOps/s $\color{#d91a1a}-1.51\%$
test_step_mdp_speed[True-True-True-False-True] 35.6520μs 18.6455μs 53.6322 KOps/s 54.2854 KOps/s $\color{#d91a1a}-1.20\%$
test_step_mdp_speed[True-True-True-False-False] 38.4920μs 11.2293μs 89.0530 KOps/s 90.7528 KOps/s $\color{#d91a1a}-1.87\%$
test_step_mdp_speed[True-True-False-True-True] 53.0730μs 34.6818μs 28.8336 KOps/s 29.1488 KOps/s $\color{#d91a1a}-1.08\%$
test_step_mdp_speed[True-True-False-True-False] 35.8110μs 21.7186μs 46.0434 KOps/s 46.7092 KOps/s $\color{#d91a1a}-1.43\%$
test_step_mdp_speed[True-True-False-False-True] 37.7420μs 20.6833μs 48.3481 KOps/s 49.8512 KOps/s $\color{#d91a1a}-3.02\%$
test_step_mdp_speed[True-True-False-False-False] 28.3410μs 13.1628μs 75.9717 KOps/s 77.0747 KOps/s $\color{#d91a1a}-1.43\%$
test_step_mdp_speed[True-False-True-True-True] 53.0030μs 36.7454μs 27.2143 KOps/s 27.9534 KOps/s $\color{#d91a1a}-2.64\%$
test_step_mdp_speed[True-False-True-True-False] 46.7920μs 23.7666μs 42.0758 KOps/s 43.2809 KOps/s $\color{#d91a1a}-2.78\%$
test_step_mdp_speed[True-False-True-False-True] 36.9120μs 20.6623μs 48.3974 KOps/s 50.1574 KOps/s $\color{#d91a1a}-3.51\%$
test_step_mdp_speed[True-False-True-False-False] 28.4710μs 13.1936μs 75.7944 KOps/s 77.7821 KOps/s $\color{#d91a1a}-2.56\%$
test_step_mdp_speed[True-False-False-True-True] 57.8420μs 38.9096μs 25.7006 KOps/s 26.5703 KOps/s $\color{#d91a1a}-3.27\%$
test_step_mdp_speed[True-False-False-True-False] 41.8620μs 25.5206μs 39.1841 KOps/s 39.9064 KOps/s $\color{#d91a1a}-1.81\%$
test_step_mdp_speed[True-False-False-False-True] 50.5930μs 22.2381μs 44.9678 KOps/s 46.2694 KOps/s $\color{#d91a1a}-2.81\%$
test_step_mdp_speed[True-False-False-False-False] 29.3720μs 14.9367μs 66.9490 KOps/s 67.6125 KOps/s $\color{#d91a1a}-0.98\%$
test_step_mdp_speed[False-True-True-True-True] 54.0530μs 36.6745μs 27.2669 KOps/s 27.7499 KOps/s $\color{#d91a1a}-1.74\%$
test_step_mdp_speed[False-True-True-True-False] 40.4520μs 23.7913μs 42.0322 KOps/s 43.2500 KOps/s $\color{#d91a1a}-2.82\%$
test_step_mdp_speed[False-True-True-False-True] 45.7020μs 24.2169μs 41.2935 KOps/s 41.5497 KOps/s $\color{#d91a1a}-0.62\%$
test_step_mdp_speed[False-True-True-False-False] 39.5010μs 14.8558μs 67.3140 KOps/s 67.8930 KOps/s $\color{#d91a1a}-0.85\%$
test_step_mdp_speed[False-True-False-True-True] 59.7230μs 38.0140μs 26.3061 KOps/s 26.0971 KOps/s $\color{#35bf28}+0.80\%$
test_step_mdp_speed[False-True-False-True-False] 40.4820μs 25.2699μs 39.5728 KOps/s 39.7488 KOps/s $\color{#d91a1a}-0.44\%$
test_step_mdp_speed[False-True-False-False-True] 44.0420μs 25.8206μs 38.7287 KOps/s 38.3298 KOps/s $\color{#35bf28}+1.04\%$
test_step_mdp_speed[False-True-False-False-False] 31.8410μs 16.6234μs 60.1560 KOps/s 61.0995 KOps/s $\color{#d91a1a}-1.54\%$
test_step_mdp_speed[False-False-True-True-True] 74.0740μs 39.9309μs 25.0433 KOps/s 24.9816 KOps/s $\color{#35bf28}+0.25\%$
test_step_mdp_speed[False-False-True-True-False] 54.3430μs 27.6010μs 36.2306 KOps/s 36.9526 KOps/s $\color{#d91a1a}-1.95\%$
test_step_mdp_speed[False-False-True-False-True] 41.5920μs 25.7268μs 38.8700 KOps/s 38.4954 KOps/s $\color{#35bf28}+0.97\%$
test_step_mdp_speed[False-False-True-False-False] 33.1410μs 16.5486μs 60.4280 KOps/s 61.1396 KOps/s $\color{#d91a1a}-1.16\%$
test_step_mdp_speed[False-False-False-True-True] 64.3330μs 41.2974μs 24.2146 KOps/s 24.3830 KOps/s $\color{#d91a1a}-0.69\%$
test_step_mdp_speed[False-False-False-True-False] 44.5320μs 29.0052μs 34.4766 KOps/s 35.5633 KOps/s $\color{#d91a1a}-3.06\%$
test_step_mdp_speed[False-False-False-False-True] 52.2820μs 27.8083μs 35.9605 KOps/s 37.1998 KOps/s $\color{#d91a1a}-3.33\%$
test_step_mdp_speed[False-False-False-False-False] 32.5920μs 18.5013μs 54.0503 KOps/s 55.4804 KOps/s $\color{#d91a1a}-2.58\%$
test_values[generalized_advantage_estimate-True-True] 25.2630ms 24.6609ms 40.5501 Ops/s 42.2230 Ops/s $\color{#d91a1a}-3.96\%$
test_values[vec_generalized_advantage_estimate-True-True] 83.5811ms 3.2457ms 308.0981 Ops/s 301.3613 Ops/s $\color{#35bf28}+2.24\%$
test_values[td0_return_estimate-False-False] 91.9240μs 65.8055μs 15.1963 KOps/s 15.6985 KOps/s $\color{#d91a1a}-3.20\%$
test_values[td1_return_estimate-False-False] 56.7562ms 54.9739ms 18.1905 Ops/s 18.6807 Ops/s $\color{#d91a1a}-2.62\%$
test_values[vec_td1_return_estimate-False-False] 2.1278ms 1.7715ms 564.4879 Ops/s 568.4513 Ops/s $\color{#d91a1a}-0.70\%$
test_values[td_lambda_return_estimate-True-False] 88.3949ms 87.5241ms 11.4254 Ops/s 11.7658 Ops/s $\color{#d91a1a}-2.89\%$
test_values[vec_td_lambda_return_estimate-True-False] 2.0902ms 1.7658ms 566.3299 Ops/s 569.2455 Ops/s $\color{#d91a1a}-0.51\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 24.4138ms 24.2439ms 41.2474 Ops/s 42.1232 Ops/s $\color{#d91a1a}-2.08\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.9006ms 0.7091ms 1.4102 KOps/s 1.4333 KOps/s $\color{#d91a1a}-1.61\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.7234ms 0.6565ms 1.5232 KOps/s 1.5418 KOps/s $\color{#d91a1a}-1.21\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.4823ms 1.4584ms 685.6805 Ops/s 689.3011 Ops/s $\color{#d91a1a}-0.53\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.9593ms 0.6777ms 1.4756 KOps/s 1.4942 KOps/s $\color{#d91a1a}-1.24\%$
test_dqn_speed 8.3100ms 1.4490ms 690.1086 Ops/s 712.0487 Ops/s $\color{#d91a1a}-3.08\%$
test_ddpg_speed 4.2095ms 2.7817ms 359.4885 Ops/s 375.3713 Ops/s $\color{#d91a1a}-4.23\%$
test_sac_speed 8.5820ms 8.1325ms 122.9639 Ops/s 126.3604 Ops/s $\color{#d91a1a}-2.69\%$
test_redq_speed 11.1707ms 10.3125ms 96.9696 Ops/s 100.4373 Ops/s $\color{#d91a1a}-3.45\%$
test_redq_deprec_speed 12.8491ms 11.3280ms 88.2771 Ops/s 93.8643 Ops/s $\textbf{\color{#d91a1a}-5.95\%}$
test_td3_speed 8.1874ms 8.0317ms 124.5067 Ops/s 126.3914 Ops/s $\color{#d91a1a}-1.49\%$
test_cql_speed 26.1328ms 25.3796ms 39.4018 Ops/s 40.8119 Ops/s $\color{#d91a1a}-3.46\%$
test_a2c_speed 6.0022ms 5.7031ms 175.3446 Ops/s 184.3969 Ops/s $\color{#d91a1a}-4.91\%$
test_ppo_speed 6.8245ms 6.0202ms 166.1071 Ops/s 172.1508 Ops/s $\color{#d91a1a}-3.51\%$
test_reinforce_speed 4.8129ms 4.5506ms 219.7502 Ops/s 226.7410 Ops/s $\color{#d91a1a}-3.08\%$
test_iql_speed 23.5476ms 19.8919ms 50.2718 Ops/s 51.8155 Ops/s $\color{#d91a1a}-2.98\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.0204ms 2.9184ms 342.6517 Ops/s 347.4137 Ops/s $\color{#d91a1a}-1.37\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.4369ms 0.5450ms 1.8349 KOps/s 1.6388 KOps/s $\textbf{\color{#35bf28}+11.97\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7165ms 0.5175ms 1.9326 KOps/s 1.9499 KOps/s $\color{#d91a1a}-0.89\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.0784ms 2.9159ms 342.9524 Ops/s 347.6609 Ops/s $\color{#d91a1a}-1.35\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.6416ms 0.5349ms 1.8695 KOps/s 1.8929 KOps/s $\color{#d91a1a}-1.24\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.8001ms 0.5116ms 1.9548 KOps/s 1.9706 KOps/s $\color{#d91a1a}-0.80\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 2.0624ms 1.5093ms 662.5477 Ops/s 708.5420 Ops/s $\textbf{\color{#d91a1a}-6.49\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.9492ms 1.4531ms 688.1644 Ops/s 745.2174 Ops/s $\textbf{\color{#d91a1a}-7.66\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.1193ms 3.0307ms 329.9535 Ops/s 333.6351 Ops/s $\color{#d91a1a}-1.10\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.1996ms 0.6704ms 1.4917 KOps/s 1.5237 KOps/s $\color{#d91a1a}-2.10\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8011ms 0.6448ms 1.5508 KOps/s 1.5799 KOps/s $\color{#d91a1a}-1.84\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.9840ms 2.8927ms 345.6976 Ops/s 348.6931 Ops/s $\color{#d91a1a}-0.86\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.6442ms 0.5428ms 1.8423 KOps/s 1.8524 KOps/s $\color{#d91a1a}-0.54\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 4.4459ms 0.5291ms 1.8899 KOps/s 1.9619 KOps/s $\color{#d91a1a}-3.67\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.1767ms 2.9146ms 343.0952 Ops/s 346.5712 Ops/s $\color{#d91a1a}-1.00\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.6779ms 0.5387ms 1.8563 KOps/s 1.8980 KOps/s $\color{#d91a1a}-2.20\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7035ms 0.5156ms 1.9396 KOps/s 1.9804 KOps/s $\color{#d91a1a}-2.06\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.1665ms 3.0347ms 329.5235 Ops/s 334.0628 Ops/s $\color{#d91a1a}-1.36\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8119ms 0.6689ms 1.4950 KOps/s 1.5199 KOps/s $\color{#d91a1a}-1.64\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 4.6557ms 0.6492ms 1.5404 KOps/s 1.5763 KOps/s $\color{#d91a1a}-2.28\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1216s 9.3800ms 106.6100 Ops/s 105.6808 Ops/s $\color{#35bf28}+0.88\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 17.1843ms 14.9655ms 66.8204 Ops/s 69.2211 Ops/s $\color{#d91a1a}-3.47\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 2.3710ms 1.0912ms 916.3869 Ops/s 794.4319 Ops/s $\textbf{\color{#35bf28}+15.35\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1159s 7.0745ms 141.3518 Ops/s 144.2900 Ops/s $\color{#d91a1a}-2.04\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 17.0723ms 14.9492ms 66.8933 Ops/s 68.2567 Ops/s $\color{#d91a1a}-2.00\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 2.0677ms 1.0966ms 911.8780 Ops/s 782.4272 Ops/s $\textbf{\color{#35bf28}+16.54\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1169s 7.4600ms 134.0484 Ops/s 135.7313 Ops/s $\color{#d91a1a}-1.24\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 0.1274s 17.6156ms 56.7679 Ops/s 66.9546 Ops/s $\textbf{\color{#d91a1a}-15.21\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 2.5303ms 1.4483ms 690.4786 Ops/s 669.7127 Ops/s $\color{#35bf28}+3.10\%$

@vmoens vmoens deleted the fix-intersection branch April 3, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vmoens @facebook-github-bot