Skip to content

[BugFix] Use same signature for append_transform in all cases #2091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 18, 2024
Merged

[BugFix] Use same signature for append_transform in all cases #2091

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24f2b11
init
Apr 18, 2024
3c43efb
amend
Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions torchrl/data/replay_buffers/replay_buffers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -612,7 +612,7 @@ def sample(self, batch_size: int | None = None, return_info: bool = False) -> An
def mark_update(self, index: Union[int, torch.Tensor]) -> None:
self._sampler.mark_update(index)

def append_transform(self, transform: "Transform") -> None: # noqa-F821
def append_transform(self, transform: "Transform") -> ReplayBuffer: # noqa-F821
"""Appends transform at the end.

Transforms are applied in order when `sample` is called.
Expand All @@ -626,8 +626,11 @@ def append_transform(self, transform: "Transform") -> None: # noqa-F821
transform = _CallableTransform(transform)
transform.eval()
self._transform.append(transform)
return self

def insert_transform(self, index: int, transform: "Transform") -> None: # noqa-F821
def insert_transform(
self, index: int, transform: "Transform" # noqa-F821
) -> ReplayBuffer:
"""Inserts transform.

Transforms are executed in order when `sample` is called.
Expand All @@ -638,6 +641,7 @@ def insert_transform(self, index: int, transform: "Transform") -> None: # noqa-
"""
transform.eval()
self._transform.insert(index, transform)
return self

def __iter__(self):
if self._sampler.ran_out:
Expand Down
6 changes: 4 additions & 2 deletions torchrl/envs/transforms/transforms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -877,7 +877,7 @@ def empty_cache(self):

def append_transform(
self, transform: Transform | Callable[[TensorDictBase], TensorDictBase]
) -> None:
) -> TransformedEnv:
"""Appends a transform to the env.

:class:`~torchrl.envs.transforms.Transform` or callable are accepted.
Expand All @@ -899,8 +899,9 @@ def append_transform(
self.transform.append(prev_transform)

self.transform.append(transform)
return self

def insert_transform(self, index: int, transform: Transform) -> None:
def insert_transform(self, index: int, transform: Transform) -> TransformedEnv:
"""Inserts a transform to the env at the desired index.

:class:`~torchrl.envs.transforms.Transform` or callable are accepted.
Expand All @@ -920,6 +921,7 @@ def insert_transform(self, index: int, transform: Transform) -> None:
self.transform = compose # parent set automatically

self.transform.insert(index, transform)
return self

def __getattr__(self, attr: str) -> Any:
try:
Expand Down