Skip to content

Conversation

@matteobettini
Copy link
Contributor

Fix #2515

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 27, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2519

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 5 Unrelated Failures

As of commit b9dd0b7 with merge base a70b258 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 27, 2024
@matteobettini matteobettini changed the title amend [Tutorial] Bug fix of buffer device and improve explaination Oct 27, 2024
@matteobettini matteobettini changed the title [Tutorial] Bug fix of buffer device and improve explaination [Tutorial] MADDPG bug fix of buffer device and improve explaination Oct 27, 2024
@vmoens vmoens added the documentation Improvements or additions to documentation label Oct 29, 2024
@vmoens vmoens changed the title [Tutorial] MADDPG bug fix of buffer device and improve explaination [Doc] MADDPG bug fix of buffer device and improve explaination Oct 29, 2024
Copy link
Collaborator

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for this

@vmoens vmoens merged commit 3e4b292 into pytorch:main Oct 29, 2024
72 of 76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]Competitive MARL (DDPG) with TorchRL Tutorial - Memory map device other than CPU isn't supported

3 participants