Skip to content

[Minor] Fix fbcode imports of mocking classes #2526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2024
Merged

[Minor] Fix fbcode imports of mocking classes #2526

merged 1 commit into from
Oct 29, 2024

Conversation

@vmoens
Copy link
Collaborator

@vmoens vmoens commented Oct 29, 2024 •
edited
Loading

Update
d59ef0b 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 29, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2526

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 5 Unrelated Failures

As of commit d59ef0b with merge base 3e4b292 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

vmoens pushed a commit that referenced this pull request Oct 29, 2024
[Minor] Fix fbcode imports of mocking classes
371c58a 
ghstack-source-id: 74f9f3b
Pull Request resolved: #2526
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 29, 2024
@vmoens vmoens added the Suitable for minor Suitable to be integrated in minor release (no new feature) label Oct 29, 2024
@github-actions
Copy link

github-actions bot commented Oct 29, 2024

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 145. Improved: $\large\color{#35bf28}11$. Worsened: $\large\color{#d91a1a}4$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_simple 0.4163s 0.4134s 2.4192 Ops/s 2.2903 Ops/s $\textbf{\color{#35bf28}+5.63\%}$
test_transformed 0.6983s 0.6148s 1.6266 Ops/s 1.6564 Ops/s $\color{#d91a1a}-1.80\%$
test_serial 1.3566s 1.3474s 0.7422 Ops/s 0.7615 Ops/s $\color{#d91a1a}-2.54\%$
test_parallel 1.3922s 1.3010s 0.7686 Ops/s 0.7674 Ops/s $\color{#35bf28}+0.16\%$
test_step_mdp_speed[True-True-True-True-True] 0.1721ms 26.9705μs 37.0776 KOps/s 37.0201 KOps/s $\color{#35bf28}+0.16\%$
test_step_mdp_speed[True-True-True-True-False] 50.4040μs 15.7466μs 63.5057 KOps/s 64.1389 KOps/s $\color{#d91a1a}-0.99\%$
test_step_mdp_speed[True-True-True-False-True] 60.7940μs 15.3782μs 65.0271 KOps/s 64.9185 KOps/s $\color{#35bf28}+0.17\%$
test_step_mdp_speed[True-True-True-False-False] 39.7550μs 8.8121μs 113.4801 KOps/s 111.0818 KOps/s $\color{#35bf28}+2.16\%$
test_step_mdp_speed[True-True-False-True-True] 73.0770μs 28.5257μs 35.0562 KOps/s 34.2736 KOps/s $\color{#35bf28}+2.28\%$
test_step_mdp_speed[True-True-False-True-False] 47.7090μs 17.2653μs 57.9197 KOps/s 57.8004 KOps/s $\color{#35bf28}+0.21\%$
test_step_mdp_speed[True-True-False-False-True] 76.9840μs 17.2436μs 57.9925 KOps/s 58.4400 KOps/s $\color{#d91a1a}-0.77\%$
test_step_mdp_speed[True-True-False-False-False] 58.7600μs 10.4254μs 95.9200 KOps/s 93.8149 KOps/s $\color{#35bf28}+2.24\%$
test_step_mdp_speed[True-False-True-True-True] 89.7580μs 30.3605μs 32.9375 KOps/s 32.3875 KOps/s $\color{#35bf28}+1.70\%$
test_step_mdp_speed[True-False-True-True-False] 51.3360μs 19.1740μs 52.1540 KOps/s 52.4304 KOps/s $\color{#d91a1a}-0.53\%$
test_step_mdp_speed[True-False-True-False-True] 76.9140μs 16.9801μs 58.8924 KOps/s 58.5404 KOps/s $\color{#35bf28}+0.60\%$
test_step_mdp_speed[True-False-True-False-False] 39.7750μs 10.5073μs 95.1715 KOps/s 94.7176 KOps/s $\color{#35bf28}+0.48\%$
test_step_mdp_speed[True-False-False-True-True] 0.1104ms 32.0139μs 31.2365 KOps/s 31.2040 KOps/s $\color{#35bf28}+0.10\%$
test_step_mdp_speed[True-False-False-True-False] 71.1530μs 20.4864μs 48.8130 KOps/s 48.4026 KOps/s $\color{#35bf28}+0.85\%$
test_step_mdp_speed[True-False-False-False-True] 52.7590μs 18.4293μs 54.2615 KOps/s 52.9428 KOps/s $\color{#35bf28}+2.49\%$
test_step_mdp_speed[True-False-False-False-False] 47.9990μs 12.2099μs 81.9010 KOps/s 82.9050 KOps/s $\color{#d91a1a}-1.21\%$
test_step_mdp_speed[False-True-True-True-True] 72.2960μs 30.4372μs 32.8546 KOps/s 32.7339 KOps/s $\color{#35bf28}+0.37\%$
test_step_mdp_speed[False-True-True-True-False] 71.5440μs 18.9592μs 52.7449 KOps/s 52.4304 KOps/s $\color{#35bf28}+0.60\%$
test_step_mdp_speed[False-True-True-False-True] 62.7770μs 19.4533μs 51.4052 KOps/s 51.0305 KOps/s $\color{#35bf28}+0.73\%$
test_step_mdp_speed[False-True-True-False-False] 51.4160μs 11.8702μs 84.2446 KOps/s 84.2613 KOps/s $\color{#d91a1a}-0.02\%$
test_step_mdp_speed[False-True-False-True-True] 68.1480μs 32.3581μs 30.9042 KOps/s 31.1742 KOps/s $\color{#d91a1a}-0.87\%$
test_step_mdp_speed[False-True-False-True-False] 78.2770μs 20.7297μs 48.2399 KOps/s 48.6157 KOps/s $\color{#d91a1a}-0.77\%$
test_step_mdp_speed[False-True-False-False-True] 2.8018ms 20.9397μs 47.7561 KOps/s 46.5982 KOps/s $\color{#35bf28}+2.48\%$
test_step_mdp_speed[False-True-False-False-False] 57.8280μs 13.4681μs 74.2497 KOps/s 74.2234 KOps/s $\color{#35bf28}+0.04\%$
test_step_mdp_speed[False-False-True-True-True] 75.8910μs 33.7182μs 29.6576 KOps/s 29.7051 KOps/s $\color{#d91a1a}-0.16\%$
test_step_mdp_speed[False-False-True-True-False] 81.5630μs 22.0668μs 45.3168 KOps/s 45.4788 KOps/s $\color{#d91a1a}-0.36\%$
test_step_mdp_speed[False-False-True-False-True] 68.0470μs 20.9521μs 47.7279 KOps/s 47.2339 KOps/s $\color{#35bf28}+1.05\%$
test_step_mdp_speed[False-False-True-False-False] 41.9490μs 13.3689μs 74.8003 KOps/s 74.0468 KOps/s $\color{#35bf28}+1.02\%$
test_step_mdp_speed[False-False-False-True-True] 0.1175ms 34.3413μs 29.1195 KOps/s 28.4767 KOps/s $\color{#35bf28}+2.26\%$
test_step_mdp_speed[False-False-False-True-False] 61.4950μs 23.3121μs 42.8961 KOps/s 42.3468 KOps/s $\color{#35bf28}+1.30\%$
test_step_mdp_speed[False-False-False-False-True] 54.0810μs 22.0158μs 45.4219 KOps/s 44.7237 KOps/s $\color{#35bf28}+1.56\%$
test_step_mdp_speed[False-False-False-False-False] 49.9730μs 14.8285μs 67.4376 KOps/s 66.8989 KOps/s $\color{#35bf28}+0.81\%$
test_values[generalized_advantage_estimate-True-True] 10.4946ms 9.8348ms 101.6795 Ops/s 103.0030 Ops/s $\color{#d91a1a}-1.28\%$
test_values[vec_generalized_advantage_estimate-True-True] 41.1367ms 36.2824ms 27.5615 Ops/s 28.3760 Ops/s $\color{#d91a1a}-2.87\%$
test_values[td0_return_estimate-False-False] 0.2405ms 0.1914ms 5.2245 KOps/s 5.4438 KOps/s $\color{#d91a1a}-4.03\%$
test_values[td1_return_estimate-False-False] 28.7558ms 24.4749ms 40.8582 Ops/s 41.6295 Ops/s $\color{#d91a1a}-1.85\%$
test_values[vec_td1_return_estimate-False-False] 38.3663ms 36.0796ms 27.7165 Ops/s 28.4875 Ops/s $\color{#d91a1a}-2.71\%$
test_values[td_lambda_return_estimate-True-False] 38.2269ms 35.0722ms 28.5126 Ops/s 28.4628 Ops/s $\color{#35bf28}+0.18\%$
test_values[vec_td_lambda_return_estimate-True-False] 36.7384ms 34.8266ms 28.7137 Ops/s 29.0745 Ops/s $\color{#d91a1a}-1.24\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 9.5820ms 8.4063ms 118.9583 Ops/s 119.3377 Ops/s $\color{#d91a1a}-0.32\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.7684ms 2.0604ms 485.3474 Ops/s 495.1295 Ops/s $\color{#d91a1a}-1.98\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.4627ms 0.3641ms 2.7468 KOps/s 2.7303 KOps/s $\color{#35bf28}+0.60\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 47.2036ms 45.6782ms 21.8923 Ops/s 20.7527 Ops/s $\textbf{\color{#35bf28}+5.49\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 3.9583ms 3.1034ms 322.2317 Ops/s 327.2273 Ops/s $\color{#d91a1a}-1.53\%$
test_dqn_speed[False-None] 6.3585ms 1.3902ms 719.3118 Ops/s 731.6204 Ops/s $\color{#d91a1a}-1.68\%$
test_dqn_speed[False-backward] 2.0646ms 1.8968ms 527.2052 Ops/s 542.2075 Ops/s $\color{#d91a1a}-2.77\%$
test_dqn_speed[True-None] 1.3468ms 0.4726ms 2.1160 KOps/s 2.1144 KOps/s $\color{#35bf28}+0.07\%$
test_dqn_speed[True-backward] 1.0131ms 0.9192ms 1.0879 KOps/s 1.1168 KOps/s $\color{#d91a1a}-2.59\%$
test_dqn_speed[reduce-overhead-None] 0.6414ms 0.4762ms 2.0999 KOps/s 2.1504 KOps/s $\color{#d91a1a}-2.35\%$
test_dqn_speed[reduce-overhead-backward] 1.0008ms 0.9017ms 1.1091 KOps/s 1.1095 KOps/s $\color{#d91a1a}-0.04\%$
test_ddpg_speed[False-None] 4.1685ms 2.8410ms 351.9899 Ops/s 355.6391 Ops/s $\color{#d91a1a}-1.03\%$
test_ddpg_speed[False-backward] 4.3169ms 3.9954ms 250.2886 Ops/s 254.6413 Ops/s $\color{#d91a1a}-1.71\%$
test_ddpg_speed[True-None] 1.4114ms 1.0122ms 987.9351 Ops/s 991.7720 Ops/s $\color{#d91a1a}-0.39\%$
test_ddpg_speed[True-backward] 1.9505ms 1.8985ms 526.7287 Ops/s 468.1789 Ops/s $\textbf{\color{#35bf28}+12.51\%}$
test_ddpg_speed[reduce-overhead-None] 1.3998ms 1.0212ms 979.2410 Ops/s 974.7964 Ops/s $\color{#35bf28}+0.46\%$
test_ddpg_speed[reduce-overhead-backward] 2.2897ms 1.9860ms 503.5165 Ops/s 472.9193 Ops/s $\textbf{\color{#35bf28}+6.47\%}$
test_sac_speed[False-None] 9.7166ms 8.2588ms 121.0824 Ops/s 121.4026 Ops/s $\color{#d91a1a}-0.26\%$
test_sac_speed[False-backward] 11.8724ms 11.3420ms 88.1677 Ops/s 92.3909 Ops/s $\color{#d91a1a}-4.57\%$
test_sac_speed[True-None] 2.3945ms 1.8680ms 535.3442 Ops/s 541.5971 Ops/s $\color{#d91a1a}-1.15\%$
test_sac_speed[True-backward] 3.9531ms 3.7121ms 269.3918 Ops/s 279.7756 Ops/s $\color{#d91a1a}-3.71\%$
test_sac_speed[reduce-overhead-None] 2.3051ms 1.8810ms 531.6447 Ops/s 541.3691 Ops/s $\color{#d91a1a}-1.80\%$
test_sac_speed[reduce-overhead-backward] 4.0422ms 3.6660ms 272.7760 Ops/s 282.0398 Ops/s $\color{#d91a1a}-3.28\%$
test_redq_speed[False-None] 16.3826ms 13.2834ms 75.2821 Ops/s 66.5378 Ops/s $\textbf{\color{#35bf28}+13.14\%}$
test_redq_speed[False-backward] 24.9038ms 23.0481ms 43.3875 Ops/s 44.0936 Ops/s $\color{#d91a1a}-1.60\%$
test_redq_speed[True-None] 5.8333ms 5.2860ms 189.1806 Ops/s 196.1628 Ops/s $\color{#d91a1a}-3.56\%$
test_redq_speed[True-backward] 14.2452ms 12.5338ms 79.7845 Ops/s 81.3743 Ops/s $\color{#d91a1a}-1.95\%$
test_redq_speed[reduce-overhead-None] 5.6518ms 4.8152ms 207.6765 Ops/s 206.2756 Ops/s $\color{#35bf28}+0.68\%$
test_redq_speed[reduce-overhead-backward] 12.9564ms 12.2217ms 81.8218 Ops/s 81.8797 Ops/s $\color{#d91a1a}-0.07\%$
test_redq_deprec_speed[False-None] 13.7357ms 12.7075ms 78.6940 Ops/s 79.7835 Ops/s $\color{#d91a1a}-1.37\%$
test_redq_deprec_speed[False-backward] 19.6109ms 18.4302ms 54.2589 Ops/s 54.5427 Ops/s $\color{#d91a1a}-0.52\%$
test_redq_deprec_speed[True-None] 4.3741ms 3.6326ms 275.2827 Ops/s 278.0566 Ops/s $\color{#d91a1a}-1.00\%$
test_redq_deprec_speed[True-backward] 9.9197ms 8.1878ms 122.1331 Ops/s 123.2383 Ops/s $\color{#d91a1a}-0.90\%$
test_redq_deprec_speed[reduce-overhead-None] 3.8475ms 3.5755ms 279.6809 Ops/s 278.0817 Ops/s $\color{#35bf28}+0.58\%$
test_redq_deprec_speed[reduce-overhead-backward] 8.8433ms 8.1638ms 122.4921 Ops/s 125.1332 Ops/s $\color{#d91a1a}-2.11\%$
test_td3_speed[False-None] 37.1583ms 8.1500ms 122.6997 Ops/s 127.3352 Ops/s $\color{#d91a1a}-3.64\%$
test_td3_speed[False-backward] 11.2258ms 10.3961ms 96.1899 Ops/s 96.9236 Ops/s $\color{#d91a1a}-0.76\%$
test_td3_speed[True-None] 1.8075ms 1.7152ms 583.0275 Ops/s 566.6531 Ops/s $\color{#35bf28}+2.89\%$
test_td3_speed[True-backward] 3.4659ms 3.3075ms 302.3442 Ops/s 280.8762 Ops/s $\textbf{\color{#35bf28}+7.64\%}$
test_td3_speed[reduce-overhead-None] 1.9309ms 1.7106ms 584.6060 Ops/s 561.0070 Ops/s $\color{#35bf28}+4.21\%$
test_td3_speed[reduce-overhead-backward] 3.4142ms 3.3038ms 302.6859 Ops/s 293.8582 Ops/s $\color{#35bf28}+3.00\%$
test_cql_speed[False-None] 38.1468ms 35.5715ms 28.1124 Ops/s 27.9773 Ops/s $\color{#35bf28}+0.48\%$
test_cql_speed[False-backward] 49.3809ms 46.4407ms 21.5328 Ops/s 21.8454 Ops/s $\color{#d91a1a}-1.43\%$
test_cql_speed[True-None] 16.8888ms 15.5772ms 64.1965 Ops/s 61.7925 Ops/s $\color{#35bf28}+3.89\%$
test_cql_speed[True-backward] 23.8527ms 22.2378ms 44.9685 Ops/s 45.4195 Ops/s $\color{#d91a1a}-0.99\%$
test_cql_speed[reduce-overhead-None] 16.8280ms 15.5852ms 64.1636 Ops/s 63.6387 Ops/s $\color{#35bf28}+0.82\%$
test_cql_speed[reduce-overhead-backward] 23.4042ms 22.2546ms 44.9345 Ops/s 43.0844 Ops/s $\color{#35bf28}+4.29\%$
test_a2c_speed[False-None] 9.4007ms 7.2483ms 137.9634 Ops/s 135.4669 Ops/s $\color{#35bf28}+1.84\%$
test_a2c_speed[False-backward] 15.8656ms 14.3523ms 69.6752 Ops/s 66.9345 Ops/s $\color{#35bf28}+4.09\%$
test_a2c_speed[True-None] 3.7172ms 3.2989ms 303.1357 Ops/s 299.5408 Ops/s $\color{#35bf28}+1.20\%$
test_a2c_speed[True-backward] 11.6263ms 9.8445ms 101.5796 Ops/s 101.9129 Ops/s $\color{#d91a1a}-0.33\%$
test_a2c_speed[reduce-overhead-None] 3.5917ms 3.3164ms 301.5285 Ops/s 298.3660 Ops/s $\color{#35bf28}+1.06\%$
test_a2c_speed[reduce-overhead-backward] 10.3295ms 9.8429ms 101.5958 Ops/s 102.1972 Ops/s $\color{#d91a1a}-0.59\%$
test_ppo_speed[False-None] 9.3711ms 7.5392ms 132.6398 Ops/s 133.8251 Ops/s $\color{#d91a1a}-0.89\%$
test_ppo_speed[False-backward] 15.6401ms 15.0854ms 66.2894 Ops/s 67.8513 Ops/s $\color{#d91a1a}-2.30\%$
test_ppo_speed[True-None] 4.1810ms 3.8227ms 261.5928 Ops/s 266.8680 Ops/s $\color{#d91a1a}-1.98\%$
test_ppo_speed[True-backward] 10.7112ms 9.6989ms 103.1046 Ops/s 103.6886 Ops/s $\color{#d91a1a}-0.56\%$
test_ppo_speed[reduce-overhead-None] 4.5171ms 3.7965ms 263.4028 Ops/s 266.9134 Ops/s $\color{#d91a1a}-1.32\%$
test_ppo_speed[reduce-overhead-backward] 10.0898ms 9.5921ms 104.2520 Ops/s 103.7521 Ops/s $\color{#35bf28}+0.48\%$
test_reinforce_speed[False-None] 8.1777ms 6.5061ms 153.7008 Ops/s 154.3524 Ops/s $\color{#d91a1a}-0.42\%$
test_reinforce_speed[False-backward] 10.6639ms 10.2929ms 97.1548 Ops/s 103.2408 Ops/s $\textbf{\color{#d91a1a}-5.90\%}$
test_reinforce_speed[True-None] 3.9354ms 2.7806ms 359.6315 Ops/s 376.8908 Ops/s $\color{#d91a1a}-4.58\%$
test_reinforce_speed[True-backward] 9.7200ms 9.0541ms 110.4467 Ops/s 115.7056 Ops/s $\color{#d91a1a}-4.55\%$
test_reinforce_speed[reduce-overhead-None] 2.9469ms 2.6636ms 375.4366 Ops/s 371.9184 Ops/s $\color{#35bf28}+0.95\%$
test_reinforce_speed[reduce-overhead-backward] 9.3142ms 8.6407ms 115.7319 Ops/s 116.1092 Ops/s $\color{#d91a1a}-0.32\%$
test_iql_speed[False-None] 33.5343ms 32.1689ms 31.0860 Ops/s 31.4212 Ops/s $\color{#d91a1a}-1.07\%$
test_iql_speed[False-backward] 46.7261ms 45.3259ms 22.0624 Ops/s 22.3257 Ops/s $\color{#d91a1a}-1.18\%$
test_iql_speed[True-None] 12.0631ms 11.0360ms 90.6123 Ops/s 88.5199 Ops/s $\color{#35bf28}+2.36\%$
test_iql_speed[True-backward] 23.4120ms 22.5874ms 44.2724 Ops/s 45.5510 Ops/s $\color{#d91a1a}-2.81\%$
test_iql_speed[reduce-overhead-None] 11.9770ms 10.9871ms 91.0159 Ops/s 89.0607 Ops/s $\color{#35bf28}+2.20\%$
test_iql_speed[reduce-overhead-backward] 24.3656ms 21.5596ms 46.3830 Ops/s 43.8568 Ops/s $\textbf{\color{#35bf28}+5.76\%}$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 0.3259s 6.5058ms 153.7100 Ops/s 192.9020 Ops/s $\textbf{\color{#d91a1a}-20.32\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7672ms 0.4808ms 2.0800 KOps/s 2.0506 KOps/s $\color{#35bf28}+1.44\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6496ms 0.4579ms 2.1838 KOps/s 2.1100 KOps/s $\color{#35bf28}+3.50\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 5.1508ms 4.6648ms 214.3698 Ops/s 206.6436 Ops/s $\color{#35bf28}+3.74\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 3.3391ms 0.4754ms 2.1035 KOps/s 2.0271 KOps/s $\color{#35bf28}+3.77\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7915ms 0.4549ms 2.1982 KOps/s 2.1093 KOps/s $\color{#35bf28}+4.22\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.8113ms 1.5909ms 628.5802 Ops/s 613.9161 Ops/s $\color{#35bf28}+2.39\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 2.0333ms 1.5466ms 646.5821 Ops/s 638.5231 Ops/s $\color{#35bf28}+1.26\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 7.3541ms 4.7029ms 212.6363 Ops/s 196.5593 Ops/s $\textbf{\color{#35bf28}+8.18\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.1149ms 0.6156ms 1.6245 KOps/s 1.5771 KOps/s $\color{#35bf28}+3.00\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.9663ms 0.5912ms 1.6916 KOps/s 1.6585 KOps/s $\color{#35bf28}+1.99\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 6.5584ms 4.6623ms 214.4861 Ops/s 212.6993 Ops/s $\color{#35bf28}+0.84\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 2.0805ms 0.4832ms 2.0695 KOps/s 2.0479 KOps/s $\color{#35bf28}+1.06\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7993ms 0.4617ms 2.1657 KOps/s 2.1315 KOps/s $\color{#35bf28}+1.61\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 5.3733ms 4.5951ms 217.6218 Ops/s 215.6268 Ops/s $\color{#35bf28}+0.93\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7013ms 0.4724ms 2.1170 KOps/s 2.0435 KOps/s $\color{#35bf28}+3.60\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 7.4583ms 0.4580ms 2.1833 KOps/s 2.1974 KOps/s $\color{#d91a1a}-0.64\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 4.9103ms 4.7143ms 212.1208 Ops/s 202.4352 Ops/s $\color{#35bf28}+4.78\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8170ms 0.6129ms 1.6317 KOps/s 1.5788 KOps/s $\color{#35bf28}+3.35\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 8.2201ms 0.6048ms 1.6535 KOps/s 1.6238 KOps/s $\color{#35bf28}+1.83\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 5.3875ms 4.1455ms 241.2279 Ops/s 230.7655 Ops/s $\color{#35bf28}+4.53\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 6.6732ms 2.3173ms 431.5438 Ops/s 411.6275 Ops/s $\color{#35bf28}+4.84\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 6.6814ms 1.3608ms 734.8445 Ops/s 777.9096 Ops/s $\textbf{\color{#d91a1a}-5.54\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.3916s 11.9244ms 83.8615 Ops/s 230.7601 Ops/s $\textbf{\color{#d91a1a}-63.66\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 7.5781ms 2.3041ms 434.0058 Ops/s 434.9625 Ops/s $\color{#d91a1a}-0.22\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 5.1588ms 1.2899ms 775.2294 Ops/s 707.8685 Ops/s $\textbf{\color{#35bf28}+9.52\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 5.5695ms 4.3412ms 230.3491 Ops/s 223.6786 Ops/s $\color{#35bf28}+2.98\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 8.8348ms 2.4224ms 412.8133 Ops/s 412.9019 Ops/s $\color{#d91a1a}-0.02\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 3.8152ms 1.3661ms 732.0066 Ops/s 693.0343 Ops/s $\textbf{\color{#35bf28}+5.62\%}$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000-100-True] 45.5602ms 41.3234ms 24.1993 Ops/s 22.5109 Ops/s $\textbf{\color{#35bf28}+7.50\%}$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000-100-False] 9.8477ms 8.9171ms 112.1446 Ops/s 108.6645 Ops/s $\color{#35bf28}+3.20\%$

@vmoens vmoens merged commit d59ef0b into gh/vmoens/36/base Oct 29, 2024
71 of 74 checks passed
vmoens pushed a commit that referenced this pull request Oct 29, 2024
[Minor] Fix fbcode imports of mocking classes
da0bf18 
ghstack-source-id: 74f9f3b
Pull Request resolved: #2526
@vmoens vmoens deleted the gh/vmoens/36/head branch October 29, 2024 11:51
vmoens pushed a commit that referenced this pull request Nov 4, 2024
[Minor] Fix fbcode imports of mocking classes
0d1d3e5 
ghstack-source-id: 74f9f3b
Pull Request resolved: #2526

(cherry picked from commit da0bf18)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Suitable for minor Suitable to be integrated in minor release (no new feature)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vmoens @facebook-github-bot