Skip to content

[Test] Fix flaky parallel env test #3161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2025
Merged

[Test] Fix flaky parallel env test #3161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions torchrl/envs/batched_envs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2451,13 +2451,15 @@ def look_for_cuda(tensor, has_cuda=has_cuda):
if event is not None:
event.record()
event.synchronize()
mp_event.set()

if _non_tensor_keys:
child_pipe.send(
("non_tensor", cur_td.select(*_non_tensor_keys, strict=False))
)

# Set event only after non-tensor data is sent to avoid race condition
mp_event.set()

del cur_td

elif cmd == "step":
Expand All @@ -2483,7 +2485,6 @@ def look_for_cuda(tensor, has_cuda=has_cuda):
if event is not None:
event.record()
event.synchronize()
mp_event.set()

# Make sure the root is updated
root_shared_tensordict.update_(env._step_mdp(input))
Expand All @@ -2493,6 +2494,9 @@ def look_for_cuda(tensor, has_cuda=has_cuda):
("non_tensor", next_td.select(*_non_tensor_keys, strict=False))
)

# Set event only after non-tensor data is sent to avoid race condition
mp_event.set()

del next_td

elif cmd == "step_and_maybe_reset":
Expand Down Expand Up @@ -2525,13 +2529,15 @@ def look_for_cuda(tensor, has_cuda=has_cuda):
if event is not None:
event.record()
event.synchronize()
mp_event.set()

if _non_tensor_keys:
ntd = root_next_td.select(*_non_tensor_keys)
ntd.set("next", td_next.select(*_non_tensor_keys))
child_pipe.send(("non_tensor", ntd))

# Set event only after non-tensor data is sent to avoid race condition
mp_event.set()

del td, root_next_td

elif cmd == "close":
Expand Down
Loading