-
Notifications
You must be signed in to change notification settings - Fork 418
[Feature] Enable storing rollouts on a different device #3199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/3199
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 658b219 with merge base 80bfa6e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
vmoens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it!
Let's just make sure we don't incur any overhead for other use cases
|
What overhead? |
A function call is a function call, I'd prefer if we were avoiding any call to |
|
Gotcha! |
vmoens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small nit otherwise lgtm!
Description
Added a
storing_deviceargument toenv.rolloutto save to a different device, like in collectors.Motivation and Context
Fix #3177
Types of changes
What types of changes does your code introduce? Remove all that do not apply:
Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!