Skip to content

[Feature] Composite specs can create named tensors with 'zero' and 'rand' (#3214) #3217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: gh/vmoens/167/base
Choose a base branch
from
Open

[Feature] Composite specs can create named tensors with 'zero' and 'rand' (#3214) #3217

wants to merge 6 commits into from

Conversation

@vmoens
Copy link
Collaborator

@vmoens vmoens commented Oct 22, 2025 •
edited
Loading

@vmoens
Update
9e30bff 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 22, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/3217

Note: Links to docs will display an error until the docs builds have been completed.

❌ 9 New Failures, 6 Unrelated Failures

As of commit f773e8d with merge base 47ad9d8 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 22, 2025
This was referenced Oct 22, 2025
Merged
Open
Open
Open
Open
Open
Merged
vmoens added 2 commits October 22, 2025 12:31
@vmoens
Update
6114490 
[ghstack-poisoned]
@vmoens
Update
567e437 
[ghstack-poisoned]
@github-actions
Copy link

github-actions bot commented Oct 22, 2025 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 154. Improved: $\large\color{#35bf28}32$. Worsened: $\large\color{#d91a1a}4$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_tensor_to_bytestream_speed[pickle] 81.9062μs 80.1657μs 12.4742 KOps/s 11.7998 KOps/s $\textbf{\color{#35bf28}+5.72\%}$
test_tensor_to_bytestream_speed[torch.save] 0.1391ms 0.1384ms 7.2261 KOps/s 7.2624 KOps/s $\color{#d91a1a}-0.50\%$
test_tensor_to_bytestream_speed[untyped_storage] 0.1192s 0.1186s 8.4314 Ops/s 8.4808 Ops/s $\color{#d91a1a}-0.58\%$
test_tensor_to_bytestream_speed[numpy] 2.7742μs 2.7651μs 361.6555 KOps/s 360.1171 KOps/s $\color{#35bf28}+0.43\%$
test_tensor_to_bytestream_speed[safetensors] 42.0054μs 41.6784μs 23.9932 KOps/s 23.6034 KOps/s $\color{#35bf28}+1.65\%$
test_simple 0.5393s 0.5386s 1.8567 Ops/s 1.7757 Ops/s $\color{#35bf28}+4.56\%$
test_transformed 1.0953s 1.0940s 0.9141 Ops/s 0.9027 Ops/s $\color{#35bf28}+1.26\%$
test_serial 1.6312s 1.6279s 0.6143 Ops/s 0.6085 Ops/s $\color{#35bf28}+0.96\%$
test_parallel 1.1431s 1.0989s 0.9100 Ops/s 0.9246 Ops/s $\color{#d91a1a}-1.58\%$
test_step_mdp_speed[True-True-True-True-True] 0.2090ms 44.5158μs 22.4639 KOps/s 22.9062 KOps/s $\color{#d91a1a}-1.93\%$
test_step_mdp_speed[True-True-True-True-False] 57.9210μs 25.2331μs 39.6305 KOps/s 40.3806 KOps/s $\color{#d91a1a}-1.86\%$
test_step_mdp_speed[True-True-True-False-True] 54.7910μs 24.9068μs 40.1497 KOps/s 41.2521 KOps/s $\color{#d91a1a}-2.67\%$
test_step_mdp_speed[True-True-True-False-False] 41.1600μs 13.7717μs 72.6129 KOps/s 75.4433 KOps/s $\color{#d91a1a}-3.75\%$
test_step_mdp_speed[True-True-False-True-True] 75.5610μs 47.1896μs 21.1911 KOps/s 21.7538 KOps/s $\color{#d91a1a}-2.59\%$
test_step_mdp_speed[True-True-False-True-False] 67.4310μs 27.1383μs 36.8483 KOps/s 36.7309 KOps/s $\color{#35bf28}+0.32\%$
test_step_mdp_speed[True-True-False-False-True] 60.8210μs 27.4409μs 36.4419 KOps/s 36.4165 KOps/s $\color{#35bf28}+0.07\%$
test_step_mdp_speed[True-True-False-False-False] 46.2900μs 16.3140μs 61.2970 KOps/s 61.4834 KOps/s $\color{#d91a1a}-0.30\%$
test_step_mdp_speed[True-False-True-True-True] 76.8510μs 49.0146μs 20.4021 KOps/s 20.3174 KOps/s $\color{#35bf28}+0.42\%$
test_step_mdp_speed[True-False-True-True-False] 58.2310μs 29.5372μs 33.8556 KOps/s 33.4427 KOps/s $\color{#35bf28}+1.23\%$
test_step_mdp_speed[True-False-True-False-True] 53.0510μs 27.1071μs 36.8908 KOps/s 37.3532 KOps/s $\color{#d91a1a}-1.24\%$
test_step_mdp_speed[True-False-True-False-False] 46.9710μs 16.1359μs 61.9734 KOps/s 61.6002 KOps/s $\color{#35bf28}+0.61\%$
test_step_mdp_speed[True-False-False-True-True] 88.7220μs 52.5747μs 19.0206 KOps/s 19.1528 KOps/s $\color{#d91a1a}-0.69\%$
test_step_mdp_speed[True-False-False-True-False] 73.6310μs 32.2256μs 31.0313 KOps/s 31.5536 KOps/s $\color{#d91a1a}-1.66\%$
test_step_mdp_speed[True-False-False-False-True] 61.9110μs 29.9353μs 33.4054 KOps/s 34.3935 KOps/s $\color{#d91a1a}-2.87\%$
test_step_mdp_speed[True-False-False-False-False] 59.9410μs 18.8927μs 52.9306 KOps/s 52.7519 KOps/s $\color{#35bf28}+0.34\%$
test_step_mdp_speed[False-True-True-True-True] 82.2810μs 49.0541μs 20.3857 KOps/s 20.4761 KOps/s $\color{#d91a1a}-0.44\%$
test_step_mdp_speed[False-True-True-True-False] 66.3210μs 30.0508μs 33.2770 KOps/s 34.0167 KOps/s $\color{#d91a1a}-2.17\%$
test_step_mdp_speed[False-True-True-False-True] 2.5009ms 31.0822μs 32.1728 KOps/s 31.8770 KOps/s $\color{#35bf28}+0.93\%$
test_step_mdp_speed[False-True-True-False-False] 43.7810μs 18.0619μs 55.3651 KOps/s 55.6000 KOps/s $\color{#d91a1a}-0.42\%$
test_step_mdp_speed[False-True-False-True-True] 0.1035ms 52.3509μs 19.1019 KOps/s 19.4025 KOps/s $\color{#d91a1a}-1.55\%$
test_step_mdp_speed[False-True-False-True-False] 63.6710μs 32.4962μs 30.7729 KOps/s 31.1103 KOps/s $\color{#d91a1a}-1.08\%$
test_step_mdp_speed[False-True-False-False-True] 77.3710μs 33.4792μs 29.8693 KOps/s 29.6387 KOps/s $\color{#35bf28}+0.78\%$
test_step_mdp_speed[False-True-False-False-False] 49.9710μs 20.3893μs 49.0454 KOps/s 48.0003 KOps/s $\color{#35bf28}+2.18\%$
test_step_mdp_speed[False-False-True-True-True] 89.2010μs 54.6133μs 18.3106 KOps/s 18.3974 KOps/s $\color{#d91a1a}-0.47\%$
test_step_mdp_speed[False-False-True-True-False] 85.6920μs 34.9386μs 28.6216 KOps/s 28.5487 KOps/s $\color{#35bf28}+0.26\%$
test_step_mdp_speed[False-False-True-False-True] 71.5110μs 33.9679μs 29.4395 KOps/s 29.9094 KOps/s $\color{#d91a1a}-1.57\%$
test_step_mdp_speed[False-False-True-False-False] 51.4910μs 20.4037μs 49.0107 KOps/s 48.0743 KOps/s $\color{#35bf28}+1.95\%$
test_step_mdp_speed[False-False-False-True-True] 92.2420μs 57.0441μs 17.5303 KOps/s 17.5513 KOps/s $\color{#d91a1a}-0.12\%$
test_step_mdp_speed[False-False-False-True-False] 67.2510μs 37.9993μs 26.3163 KOps/s 26.6817 KOps/s $\color{#d91a1a}-1.37\%$
test_step_mdp_speed[False-False-False-False-True] 65.4410μs 35.2122μs 28.3992 KOps/s 28.0917 KOps/s $\color{#35bf28}+1.09\%$
test_step_mdp_speed[False-False-False-False-False] 49.0610μs 22.8268μs 43.8081 KOps/s 44.1041 KOps/s $\color{#d91a1a}-0.67\%$
test_values[generalized_advantage_estimate-True-True] 10.8920ms 10.3720ms 96.4139 Ops/s 100.3077 Ops/s $\color{#d91a1a}-3.88\%$
test_values[vec_generalized_advantage_estimate-True-True] 13.6568ms 10.9954ms 90.9475 Ops/s 57.2361 Ops/s $\textbf{\color{#35bf28}+58.90\%}$
test_values[td0_return_estimate-False-False] 0.2473ms 0.1271ms 7.8662 KOps/s 7.7643 KOps/s $\color{#35bf28}+1.31\%$
test_values[td1_return_estimate-False-False] 28.5792ms 28.0862ms 35.6046 Ops/s 36.9803 Ops/s $\color{#d91a1a}-3.72\%$
test_values[vec_td1_return_estimate-False-False] 11.5122ms 11.0966ms 90.1176 Ops/s 57.0698 Ops/s $\textbf{\color{#35bf28}+57.91\%}$
test_values[td_lambda_return_estimate-True-False] 43.5367ms 42.0924ms 23.7572 Ops/s 24.7168 Ops/s $\color{#d91a1a}-3.88\%$
test_values[vec_td_lambda_return_estimate-True-False] 12.3647ms 11.1654ms 89.5627 Ops/s 57.0355 Ops/s $\textbf{\color{#35bf28}+57.03\%}$
test_gae_speed[generalized_advantage_estimate-False-1-512] 8.9982ms 8.8650ms 112.8030 Ops/s 115.5903 Ops/s $\color{#d91a1a}-2.41\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 1.7493ms 1.5444ms 647.5055 Ops/s 656.1325 Ops/s $\color{#d91a1a}-1.31\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.7070ms 0.4143ms 2.4136 KOps/s 2.4405 KOps/s $\color{#d91a1a}-1.10\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 30.2570ms 24.9710ms 40.0465 Ops/s 32.8932 Ops/s $\textbf{\color{#35bf28}+21.75\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 2.0766ms 1.7106ms 584.5835 Ops/s 586.4072 Ops/s $\color{#d91a1a}-0.31\%$
test_dqn_speed[False-None] 6.6072ms 1.4086ms 709.9195 Ops/s 716.0000 Ops/s $\color{#d91a1a}-0.85\%$
test_dqn_speed[False-backward] 1.9721ms 1.9000ms 526.3067 Ops/s 527.5935 Ops/s $\color{#d91a1a}-0.24\%$
test_dqn_speed[True-None] 0.9214ms 0.5227ms 1.9130 KOps/s 1.8809 KOps/s $\color{#35bf28}+1.71\%$
test_dqn_speed[True-backward] 0.9870ms 0.9557ms 1.0463 KOps/s 917.2186 Ops/s $\textbf{\color{#35bf28}+14.07\%}$
test_dqn_speed[reduce-overhead-None] 0.8625ms 0.5109ms 1.9575 KOps/s 1.9891 KOps/s $\color{#d91a1a}-1.59\%$
test_dqn_speed[reduce-overhead-backward] 0.9759ms 0.9411ms 1.0625 KOps/s 947.5477 Ops/s $\textbf{\color{#35bf28}+12.14\%}$
test_ddpg_speed[False-None] 3.1621ms 2.8483ms 351.0873 Ops/s 352.2740 Ops/s $\color{#d91a1a}-0.34\%$
test_ddpg_speed[False-backward] 4.1328ms 4.0486ms 246.9983 Ops/s 244.7892 Ops/s $\color{#35bf28}+0.90\%$
test_ddpg_speed[True-None] 2.1268ms 1.3676ms 731.2053 Ops/s 717.4286 Ops/s $\color{#35bf28}+1.92\%$
test_ddpg_speed[True-backward] 2.3959ms 2.3357ms 428.1292 Ops/s 368.3002 Ops/s $\textbf{\color{#35bf28}+16.24\%}$
test_ddpg_speed[reduce-overhead-None] 1.7177ms 1.3567ms 737.0643 Ops/s 737.5169 Ops/s $\color{#d91a1a}-0.06\%$
test_ddpg_speed[reduce-overhead-backward] 2.3985ms 2.3129ms 432.3533 Ops/s 363.3164 Ops/s $\textbf{\color{#35bf28}+19.00\%}$
test_sac_speed[False-None] 8.3651ms 7.8244ms 127.8057 Ops/s 128.5179 Ops/s $\color{#d91a1a}-0.55\%$
test_sac_speed[False-backward] 11.5168ms 11.1454ms 89.7232 Ops/s 90.1527 Ops/s $\color{#d91a1a}-0.48\%$
test_sac_speed[True-None] 2.4120ms 2.0602ms 485.3946 Ops/s 480.1480 Ops/s $\color{#35bf28}+1.09\%$
test_sac_speed[True-backward] 4.0862ms 3.9724ms 251.7358 Ops/s 250.1357 Ops/s $\color{#35bf28}+0.64\%$
test_sac_speed[reduce-overhead-None] 2.2570ms 2.0600ms 485.4436 Ops/s 461.0714 Ops/s $\textbf{\color{#35bf28}+5.29\%}$
test_sac_speed[reduce-overhead-backward] 4.0813ms 3.9604ms 252.4999 Ops/s 220.8271 Ops/s $\textbf{\color{#35bf28}+14.34\%}$
test_redq_speed[False-None] 10.6076ms 10.0372ms 99.6290 Ops/s 84.2802 Ops/s $\textbf{\color{#35bf28}+18.21\%}$
test_redq_speed[False-backward] 18.1438ms 17.4652ms 57.2566 Ops/s 56.8031 Ops/s $\color{#35bf28}+0.80\%$
test_redq_speed[True-None] 4.6617ms 4.3146ms 231.7727 Ops/s 234.9692 Ops/s $\color{#d91a1a}-1.36\%$
test_redq_speed[True-backward] 9.9798ms 9.5283ms 104.9509 Ops/s 105.3547 Ops/s $\color{#d91a1a}-0.38\%$
test_redq_speed[reduce-overhead-None] 4.5088ms 4.2665ms 234.3858 Ops/s 234.3626 Ops/s $+0.01\%$
test_redq_speed[reduce-overhead-backward] 10.0750ms 9.6945ms 103.1512 Ops/s 99.5598 Ops/s $\color{#35bf28}+3.61\%$
test_redq_deprec_speed[False-None] 11.0615ms 10.6464ms 93.9287 Ops/s 91.9481 Ops/s $\color{#35bf28}+2.15\%$
test_redq_deprec_speed[False-backward] 15.8978ms 15.4094ms 64.8956 Ops/s 64.2728 Ops/s $\color{#35bf28}+0.97\%$
test_redq_deprec_speed[True-None] 3.7842ms 3.4718ms 288.0382 Ops/s 276.6819 Ops/s $\color{#35bf28}+4.10\%$
test_redq_deprec_speed[True-backward] 7.4997ms 7.1666ms 139.5362 Ops/s 124.7093 Ops/s $\textbf{\color{#35bf28}+11.89\%}$
test_redq_deprec_speed[reduce-overhead-None] 3.7415ms 3.4114ms 293.1359 Ops/s 283.0771 Ops/s $\color{#35bf28}+3.55\%$
test_redq_deprec_speed[reduce-overhead-backward] 7.6124ms 7.1869ms 139.1425 Ops/s 124.9560 Ops/s $\textbf{\color{#35bf28}+11.35\%}$
test_td3_speed[False-None] 8.2034ms 7.8784ms 126.9297 Ops/s 128.1406 Ops/s $\color{#d91a1a}-0.94\%$
test_td3_speed[False-backward] 11.3479ms 10.7634ms 92.9074 Ops/s 93.7085 Ops/s $\color{#d91a1a}-0.85\%$
test_td3_speed[True-None] 1.8911ms 1.7694ms 565.1570 Ops/s 554.3170 Ops/s $\color{#35bf28}+1.96\%$
test_td3_speed[True-backward] 3.8136ms 3.5793ms 279.3850 Ops/s 281.9934 Ops/s $\color{#d91a1a}-0.92\%$
test_td3_speed[reduce-overhead-None] 1.8034ms 1.7350ms 576.3684 Ops/s 582.8872 Ops/s $\color{#d91a1a}-1.12\%$
test_td3_speed[reduce-overhead-backward] 3.7683ms 3.5948ms 278.1832 Ops/s 235.4903 Ops/s $\textbf{\color{#35bf28}+18.13\%}$
test_cql_speed[False-None] 28.2390ms 25.6477ms 38.9898 Ops/s 39.1014 Ops/s $\color{#d91a1a}-0.29\%$
test_cql_speed[False-backward] 38.0363ms 34.6896ms 28.8271 Ops/s 28.8260 Ops/s $+0.00\%$
test_cql_speed[True-None] 12.7002ms 12.0809ms 82.7752 Ops/s 82.9058 Ops/s $\color{#d91a1a}-0.16\%$
test_cql_speed[True-backward] 17.6203ms 17.3284ms 57.7086 Ops/s 57.8304 Ops/s $\color{#d91a1a}-0.21\%$
test_cql_speed[reduce-overhead-None] 12.5790ms 12.1300ms 82.4402 Ops/s 82.5862 Ops/s $\color{#d91a1a}-0.18\%$
test_cql_speed[reduce-overhead-backward] 17.6867ms 17.2850ms 57.8538 Ops/s 57.1317 Ops/s $\color{#35bf28}+1.26\%$
test_a2c_speed[False-None] 5.8037ms 5.3494ms 186.9379 Ops/s 187.3783 Ops/s $\color{#d91a1a}-0.24\%$
test_a2c_speed[False-backward] 12.2288ms 11.7573ms 85.0536 Ops/s 85.9938 Ops/s $\color{#d91a1a}-1.09\%$
test_a2c_speed[True-None] 4.0808ms 3.6178ms 276.4120 Ops/s 274.0206 Ops/s $\color{#35bf28}+0.87\%$
test_a2c_speed[True-backward] 8.7653ms 8.5711ms 116.6707 Ops/s 112.9950 Ops/s $\color{#35bf28}+3.25\%$
test_a2c_speed[reduce-overhead-None] 3.9959ms 3.6487ms 274.0717 Ops/s 274.1140 Ops/s $\color{#d91a1a}-0.02\%$
test_a2c_speed[reduce-overhead-backward] 9.1266ms 8.7380ms 114.4429 Ops/s 115.6841 Ops/s $\color{#d91a1a}-1.07\%$
test_ppo_speed[False-None] 6.3554ms 5.8641ms 170.5305 Ops/s 173.8751 Ops/s $\color{#d91a1a}-1.92\%$
test_ppo_speed[False-backward] 12.8159ms 12.5380ms 79.7573 Ops/s 81.7549 Ops/s $\color{#d91a1a}-2.44\%$
test_ppo_speed[True-None] 3.8041ms 3.6164ms 276.5157 Ops/s 279.5153 Ops/s $\color{#d91a1a}-1.07\%$
test_ppo_speed[True-backward] 8.7564ms 8.3810ms 119.3173 Ops/s 111.4553 Ops/s $\textbf{\color{#35bf28}+7.05\%}$
test_ppo_speed[reduce-overhead-None] 4.1917ms 3.5545ms 281.3322 Ops/s 279.0520 Ops/s $\color{#35bf28}+0.82\%$
test_ppo_speed[reduce-overhead-backward] 9.0226ms 8.6974ms 114.9775 Ops/s 114.8501 Ops/s $\color{#35bf28}+0.11\%$
test_reinforce_speed[False-None] 4.8606ms 4.5279ms 220.8539 Ops/s 221.0189 Ops/s $\color{#d91a1a}-0.07\%$
test_reinforce_speed[False-backward] 7.6221ms 7.2970ms 137.0433 Ops/s 138.1652 Ops/s $\color{#d91a1a}-0.81\%$
test_reinforce_speed[True-None] 2.9836ms 2.7777ms 360.0056 Ops/s 348.2125 Ops/s $\color{#35bf28}+3.39\%$
test_reinforce_speed[True-backward] 7.9688ms 7.5989ms 131.5974 Ops/s 104.5090 Ops/s $\textbf{\color{#35bf28}+25.92\%}$
test_reinforce_speed[reduce-overhead-None] 3.2653ms 2.7795ms 359.7744 Ops/s 347.6612 Ops/s $\color{#35bf28}+3.48\%$
test_reinforce_speed[reduce-overhead-backward] 8.0810ms 7.8278ms 127.7498 Ops/s 124.4500 Ops/s $\color{#35bf28}+2.65\%$
test_iql_speed[False-None] 25.6648ms 19.8309ms 50.4265 Ops/s 48.6953 Ops/s $\color{#35bf28}+3.56\%$
test_iql_speed[False-backward] 35.8527ms 30.4103ms 32.8836 Ops/s 32.9798 Ops/s $\color{#d91a1a}-0.29\%$
test_iql_speed[True-None] 8.7490ms 8.3870ms 119.2320 Ops/s 115.7202 Ops/s $\color{#35bf28}+3.03\%$
test_iql_speed[True-backward] 16.7280ms 16.3803ms 61.0490 Ops/s 60.9564 Ops/s $\color{#35bf28}+0.15\%$
test_iql_speed[reduce-overhead-None] 8.8639ms 8.4078ms 118.9367 Ops/s 115.5839 Ops/s $\color{#35bf28}+2.90\%$
test_iql_speed[reduce-overhead-backward] 17.2695ms 16.8469ms 59.3580 Ops/s 57.8541 Ops/s $\color{#35bf28}+2.60\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 7.3999ms 5.8515ms 170.8970 Ops/s 172.2165 Ops/s $\color{#d91a1a}-0.77\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.6009ms 0.3021ms 3.3105 KOps/s 2.9086 KOps/s $\textbf{\color{#35bf28}+13.82\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6554ms 0.2893ms 3.4562 KOps/s 2.7862 KOps/s $\textbf{\color{#35bf28}+24.05\%}$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 5.8914ms 5.6354ms 177.4482 Ops/s 183.4036 Ops/s $\color{#d91a1a}-3.25\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.5880s 0.6698ms 1.4929 KOps/s 3.1787 KOps/s $\textbf{\color{#d91a1a}-53.03\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.5305ms 0.2640ms 3.7885 KOps/s 3.3628 KOps/s $\textbf{\color{#35bf28}+12.66\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.4927ms 1.2495ms 800.3429 Ops/s 713.6561 Ops/s $\textbf{\color{#35bf28}+12.15\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.6577ms 1.2020ms 831.9382 Ops/s 749.9414 Ops/s $\textbf{\color{#35bf28}+10.93\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 5.9022ms 5.7815ms 172.9649 Ops/s 175.4078 Ops/s $\color{#d91a1a}-1.39\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.1035ms 0.4786ms 2.0896 KOps/s 2.1650 KOps/s $\color{#d91a1a}-3.48\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.7133ms 0.4590ms 2.1786 KOps/s 2.2207 KOps/s $\color{#d91a1a}-1.89\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 5.7861ms 5.6537ms 176.8761 Ops/s 181.4138 Ops/s $\color{#d91a1a}-2.50\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 2.2707ms 0.3631ms 2.7541 KOps/s 838.0070 Ops/s $\textbf{\color{#35bf28}+228.65\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6324ms 0.3045ms 3.2841 KOps/s 2.7666 KOps/s $\textbf{\color{#35bf28}+18.71\%}$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 5.9259ms 5.6108ms 178.2283 Ops/s 178.0379 Ops/s $\color{#35bf28}+0.11\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.9806ms 0.3503ms 2.8551 KOps/s 2.6700 KOps/s $\textbf{\color{#35bf28}+6.93\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.5656ms 0.3267ms 3.0604 KOps/s 2.7809 KOps/s $\textbf{\color{#35bf28}+10.05\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 5.9293ms 5.8152ms 171.9625 Ops/s 172.9279 Ops/s $\color{#d91a1a}-0.56\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.1912ms 0.4683ms 2.1354 KOps/s 1.8620 KOps/s $\textbf{\color{#35bf28}+14.68\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.7105ms 0.4868ms 2.0544 KOps/s 1.9415 KOps/s $\textbf{\color{#35bf28}+5.82\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.5133s 15.1978ms 65.7991 Ops/s 196.3051 Ops/s $\textbf{\color{#d91a1a}-66.48\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 2.8998ms 1.3973ms 715.6410 Ops/s 429.6935 Ops/s $\textbf{\color{#35bf28}+66.55\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 11.6477ms 1.2236ms 817.2928 Ops/s 807.1755 Ops/s $\color{#35bf28}+1.25\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 7.0183ms 5.0298ms 198.8153 Ops/s 54.9840 Ops/s $\textbf{\color{#35bf28}+261.59\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 8.7889ms 2.0152ms 496.2331 Ops/s 513.1957 Ops/s $\color{#d91a1a}-3.31\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 7.3018ms 1.1742ms 851.6249 Ops/s 999.8785 Ops/s $\textbf{\color{#d91a1a}-14.83\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.4984s 15.1502ms 66.0057 Ops/s 185.7731 Ops/s $\textbf{\color{#d91a1a}-64.47\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 12.1280ms 2.0848ms 479.6580 Ops/s 452.8844 Ops/s $\textbf{\color{#35bf28}+5.91\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 1.1818ms 1.0067ms 993.3018 Ops/s 720.0349 Ops/s $\textbf{\color{#35bf28}+37.95\%}$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-True] 34.7635ms 32.6063ms 30.6690 Ops/s 30.4623 Ops/s $\color{#35bf28}+0.68\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-False] 19.0261ms 17.0092ms 58.7918 Ops/s 58.2618 Ops/s $\color{#35bf28}+0.91\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-True] 35.4735ms 33.5807ms 29.7790 Ops/s 29.7462 Ops/s $\color{#35bf28}+0.11\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-False] 18.8410ms 17.2977ms 57.8112 Ops/s 56.8827 Ops/s $\color{#35bf28}+1.63\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-True] 36.6494ms 34.9518ms 28.6108 Ops/s 28.7935 Ops/s $\color{#d91a1a}-0.63\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-False] 20.3560ms 18.7232ms 53.4097 Ops/s 52.6721 Ops/s $\color{#35bf28}+1.40\%$

vmoens added 3 commits October 22, 2025 13:29
@vmoens
Update
e4ce1d2 
[ghstack-poisoned]
@vmoens
Update
d6e349d 
[ghstack-poisoned]
@vmoens
Update
f773e8d 
[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@vmoens