Skip to content

Conversation

@alexanderlobov
Copy link
Contributor

@alexanderlobov alexanderlobov commented Oct 31, 2022

Description

TransformedEnv of a TransformedEnv should just append the transforms, not create a new TransformedEnv
close #602

Failing tests investigation is in progress

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • New feature (non-breaking change which adds core functionality)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 31, 2022
@vmoens vmoens changed the title #602 Unfold transforms for folded TransformedEnv [Feature] Unfold transforms for folded TransformedEnv Nov 1, 2022
@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Merging #630 (de7f2b1) into main (6f9faaa) will increase coverage by 0.00%.
The diff coverage is 95.00%.

@@           Coverage Diff           @@
##             main     #630   +/-   ##
=======================================
  Coverage   87.45%   87.46%           
=======================================
  Files         124      124           
  Lines       22850    22882   +32     
=======================================
+ Hits        19984    20014   +30     
- Misses       2866     2868    +2     
Flag Coverage Δ
linux-cpu 85.87% <95.00%> (+0.01%) ⬆️
linux-gpu 87.27% <95.00%> (+0.02%) ⬆️
linux-outdeps-gpu 76.33% <95.00%> (+0.04%) ⬆️
linux-stable-cpu 85.87% <95.00%> (+0.02%) ⬆️
linux-stable-gpu 87.27% <95.00%> (+0.02%) ⬆️
macos-cpu 85.65% <95.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchrl/envs/transforms/transforms.py 85.88% <92.85%> (+0.09%) ⬆️
test/test_transforms.py 95.82% <100.00%> (+0.04%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vmoens vmoens changed the title [Feature] Unfold transforms for folded TransformedEnv [Feature] Unfold transforms for folded TransformedEnv Nov 1, 2022
@vmoens vmoens added the enhancement New feature or request label Nov 1, 2022
Copy link
Collaborator

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for this

@vmoens vmoens merged commit dd9a98f into pytorch:main Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] TransformedEnv of a TransformedEnv should just append the transforms, not create a new TransformedEnv

3 participants