Skip to content

Conversation

@nickspell
Copy link
Contributor

Description

This PR:

  • Documents an issue with PyTorch versioning
  • Proposes some workarounds to make the library work with older PyTorch versions installed.
  • Links such documentation in the troubleshooting section of the README

Motivation and Context

When using torch at lower version than 1.13 and installing the package stable version via pip, an undefined symbol error appears when trying to import the module.

Related to #689.

Types of changes

  • Documentation (update in the documentation)

Checklist

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 24, 2022
Copy link
Collaborator

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could maybe make this a bit more generic? See my suggestions

Copy link
Collaborator

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vmoens vmoens changed the title Document undefined symbol error with torch version < 1.13 [Doc] Document undefined symbol error with torch version < 1.13 Nov 24, 2022
@vmoens vmoens merged commit 3105819 into pytorch:main Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants