Skip to content

Conversation

@tcbegley
Copy link
Contributor

Description

Recent changes to docs CI/CD change the outputdir of sphinx from build/html to _local_build.

This PR ensures we pull the TensorDict docs into the same directory.

Tested in my fork and seems to be working: https://github.com/tcbegley/rl/tree/gh-pages

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 25, 2022
@vmoens vmoens changed the title Clone TensorDict docs into _local_build [BugFix, Doc] Clone TensorDict docs into _local_build Nov 25, 2022
@vmoens vmoens added the documentation Improvements or additions to documentation label Nov 25, 2022
Copy link
Collaborator

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmoens vmoens merged commit c52caac into pytorch:main Nov 25, 2022
@tcbegley tcbegley deleted the tensordict-docs-fix branch November 25, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants