Skip to content

Conversation

@tcbegley
Copy link
Contributor

@tcbegley tcbegley commented Dec 1, 2022

Description

Correct links to tutorials in README.

Closes #723

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 1, 2022
@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Merging #724 (b0d9b2d) into main (08e3b71) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #724   +/-   ##
=======================================
  Coverage   88.66%   88.66%           
=======================================
  Files         120      120           
  Lines       20186    20186           
=======================================
+ Hits        17897    17898    +1     
+ Misses       2289     2288    -1     
Flag Coverage Δ
habitat-gpu 25.05% <ø> (ø)
linux-cpu 85.59% <ø> (ø)
linux-gpu 86.54% <ø> (ø)
linux-jumanji 30.27% <ø> (ø)
linux-outdeps-gpu 72.22% <ø> (ø)
linux-stable-cpu 85.44% <ø> (ø)
linux-stable-gpu 86.18% <ø> (+0.01%) ⬆️
linux_examples-gpu 43.09% <ø> (ø)
macos-cpu 85.26% <ø> (-0.01%) ⬇️
olddeps-gpu 76.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/test_trainer.py 98.23% <0.00%> (-0.33%) ⬇️
torchrl/envs/vec_env.py 69.06% <0.00%> (+0.50%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@vmoens vmoens merged commit bac229a into pytorch:main Dec 1, 2022
albertbou92 pushed a commit to PyTorchRL/rl that referenced this pull request Dec 2, 2022
@tcbegley tcbegley deleted the readme-links branch March 29, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TensorDict tutorial links are broken in Readme[BUG]

3 participants