Skip to content

[Feature] Better advantage API for higher order derivatives #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 14, 2022
Merged

[Feature] Better advantage API for higher order derivatives #744

merged 5 commits into from
Dec 14, 2022

Conversation

@vmoens
Copy link
Collaborator

@vmoens vmoens commented Dec 14, 2022 •
edited
Loading

Description

Changes the advantage API such that

  1. computing the value error is done in a standardized way using the target value computed by the advantage module
  2. removes the possibility of using the advantage module inside PPOLoss to give a better control over its behaviour to the user

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 14, 2022
@vmoens vmoens added the enhancement New feature or request label Dec 14, 2022
@vmoens vmoens merged commit 9d50995 into main Dec 14, 2022
@vmoens vmoens deleted the fix_gae branch December 14, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vmoens @facebook-github-bot