[Refactor] Cosmetic improvements to advantage modules #746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
# Conflicts: # test/test_cost.py # torchrl/objectives/value/advantages.py
vmoens
commented
Dec 15, 2022
| The module supports non-tensordict (i.e. unpacked tensordict) inputs too: | ||
| Examples: | ||
| >>> value_net = SafeModule( |
Collaborator
Author
There was a problem hiding this comment.
cc @tcbegley this is something a bit more interesting than TensorDictModule
This module is a regular nn.Module that reads from a tensordict.
You may have a some crazy combination of keys that your value network needs to read, but you'd still be able to use regular tensors with this.
Codecov Report
@@ Coverage Diff @@
## main #746 +/- ##
==========================================
- Coverage 88.74% 88.74% -0.01%
==========================================
Files 123 123
Lines 20786 20810 +24
==========================================
+ Hits 18447 18468 +21
- Misses 2339 2342 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some cosmetic improvements to GAE, TDL and TD.
Gathers the in_keys and out_keys automatically, and allows to use the modules without tensordict.