[Refactor] Remove env.is_done attribute #748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
# Conflicts: # torchrl/envs/common.py
vmoens
added a commit
that referenced
this pull request
Dec 23, 2022
* [BugFix] Fix NoopReset in parallel settings (#747) * [Refactor] Remove env.is_done attribute (#748) * Drop use of prototype modules (#738) * Fix test_cost * Lint and format * Fix test_postprocs * Fix test_collectors * amend * [BugFix] Fixes for `speed` branch merge on tensordict (#755) * init * empty * empty * amend * empty * run legit tests * empty * reset_workers * brax/jumanji fix * lint * reward shape for jumanji * jumanji * jumanji * bf * amend * amend * amend * bf * bf * bf Co-authored-by: Tom Begley <tomcbegley@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the
is_doneattribute of the envs as this may be confusing in batched / multiagent / multitask envs (not always a single boolean)