Skip to content

Conversation

@tcbegley
Copy link
Contributor

@tcbegley tcbegley commented Dec 20, 2022

Description

This PR adds support for tensorclasses to Lazy{Tensor,Memmap}Storage. This should allow us to add support for tensorclasses to replay buffers in future.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 20, 2022
@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Merging #752 (4761fab) into main (1f8341c) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 4761fab differs from pull request most recent head 741dbdc. Consider uploading reports for the commit 741dbdc to get more accurate results

@@            Coverage Diff             @@
##             main     #752      +/-   ##
==========================================
- Coverage   88.77%   88.77%   -0.01%     
==========================================
  Files         123      123              
  Lines       20788    20814      +26     
==========================================
+ Hits        18454    18477      +23     
- Misses       2334     2337       +3     
Flag Coverage Δ
habitat-gpu 25.14% <12.50%> (-0.01%) ⬇️
linux-brax 29.48% <12.50%> (-0.02%) ⬇️
linux-cpu 85.31% <100.00%> (+0.01%) ⬆️
linux-gpu 86.22% <100.00%> (+0.01%) ⬆️
linux-jumanji 30.21% <12.50%> (-0.02%) ⬇️
linux-outdeps-gpu 72.10% <100.00%> (+0.03%) ⬆️
linux-stable-cpu 85.16% <100.00%> (+0.01%) ⬆️
linux-stable-gpu 85.86% <100.00%> (+<0.01%) ⬆️
linux_examples-gpu 43.00% <25.00%> (-0.02%) ⬇️
macos-cpu 84.99% <100.00%> (+0.01%) ⬆️
olddeps-gpu 75.96% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/test_rb.py 97.43% <100.00%> (+0.10%) ⬆️
torchrl/data/replay_buffers/storages.py 84.05% <100.00%> (+0.56%) ⬆️
torchrl/envs/vec_env.py 69.13% <0.00%> (-0.51%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tcbegley tcbegley marked this pull request as ready for review December 20, 2022 14:44
Copy link
Collaborator

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I added a couple of tests for get and set

@vmoens vmoens merged commit 0f2e641 into pytorch:main Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants