Skip to content

Conversation

@yohann-benchetrit
Copy link
Contributor

@yohann-benchetrit yohann-benchetrit commented Dec 22, 2022

Description

  • Add binary_win_wheel job to CircleCI
  • Run this job in build workflow for:
    • cu_version=cpu,cu116,cu117
    • python_version=3.7,3.8,3.9,3.10

Motivation and Context

TorchRL is currently built and tested for OsX and Linux only and there is some demand for a windows built.

Types of changes

  • New feature
    • Add build for Windows wheels in CircleCI for the CUDA and Python versions mentioned above.
    • Add scripts needed to run the build in packaging/windows (slightly modified from Torchvision's ones)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 22, 2022
@yohann-benchetrit yohann-benchetrit force-pushed the add_windows_builds_and_tests branch 2 times, most recently from 5855275 to 6c28001 Compare December 22, 2022 14:16
@yohann-benchetrit yohann-benchetrit changed the title [WIP] Add binary_win_wheel build-workflows [WIP] Add windows wheel build to CircleCI Dec 22, 2022
@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Merging #759 (8c0a4b3) into main (e4e485b) will increase coverage by 0.51%.
The diff coverage is n/a.

❗ Current head 8c0a4b3 differs from pull request most recent head 52d67f4. Consider uploading reports for the commit 52d67f4 to get more accurate results

@@            Coverage Diff             @@
##             main     #759      +/-   ##
==========================================
+ Coverage   88.26%   88.77%   +0.51%     
==========================================
  Files         123      123              
  Lines       21270    20788     -482     
==========================================
- Hits        18773    18454     -319     
+ Misses       2497     2334     -163     
Flag Coverage Δ
habitat-gpu 25.15% <ø> (+0.37%) ⬆️
linux-brax 29.49% <ø> (-2.02%) ⬇️
linux-cpu 85.29% <ø> (+0.05%) ⬆️
linux-gpu 86.21% <ø> (+61.34%) ⬆️
linux-jumanji 30.22% <ø> (+0.09%) ⬆️
linux-outdeps-gpu 72.06% <ø> (-0.27%) ⬇️
linux-stable-cpu 85.14% <ø> (+0.04%) ⬆️
linux-stable-gpu 85.86% <ø> (?)
linux_examples-gpu 43.01% <ø> (+0.34%) ⬆️
macos-cpu 84.97% <ø> (?)
olddeps-gpu 75.93% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchrl/envs/libs/brax.py 92.15% <0.00%> (-1.48%) ⬇️
test/mocking_classes.py 97.88% <0.00%> (-0.60%) ⬇️
torchrl/data/replay_buffers/storages.py 83.48% <0.00%> (-0.57%) ⬇️
test/test_transforms.py 96.37% <0.00%> (-0.35%) ⬇️
torchrl/objectives/sac.py 91.40% <0.00%> (-0.33%) ⬇️
torchrl/envs/libs/jumanji.py 90.47% <0.00%> (-0.28%) ⬇️
torchrl/objectives/deprecated.py 92.45% <0.00%> (-0.21%) ⬇️
torchrl/envs/gym_like.py 88.88% <0.00%> (-0.19%) ⬇️
test/test_rb.py 97.32% <0.00%> (-0.19%) ⬇️
test/test_collector.py 98.61% <0.00%> (-0.13%) ⬇️
... and 24 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yohann-benchetrit yohann-benchetrit marked this pull request as ready for review December 23, 2022 13:15
@yohann-benchetrit yohann-benchetrit changed the title [WIP] Add windows wheel build to CircleCI Add windows wheel build to CircleCI Dec 23, 2022
@yohann-benchetrit yohann-benchetrit marked this pull request as draft December 26, 2022 08:28
@yohann-benchetrit yohann-benchetrit marked this pull request as ready for review December 26, 2022 08:50
Copy link
Collaborator

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
Minor question: Do we need both cuda 11.6 and 11.7?

@vmoens
Copy link
Collaborator

vmoens commented Jan 3, 2023

@yohann-benchetrit also let's avoid to link to internal tasks since this is an open-source repo

@yohann-benchetrit
Copy link
Contributor Author

@vmoens

Do we need both cuda 11.6 and 11.7?

I think it's good to have both as the two options are offered for Torch Windows install

@yohann-benchetrit yohann-benchetrit force-pushed the add_windows_builds_and_tests branch from 8c0a4b3 to 52d67f4 Compare January 4, 2023 12:21
@yohann-benchetrit yohann-benchetrit force-pushed the add_windows_builds_and_tests branch from 52d67f4 to bdfd342 Compare January 4, 2023 12:32
@vmoens vmoens merged commit e676e60 into pytorch:main Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants