-
Notifications
You must be signed in to change notification settings - Fork 418
Add windows wheel build to CircleCI #759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add windows wheel build to CircleCI #759
Conversation
5855275 to
6c28001
Compare
Codecov Report
@@ Coverage Diff @@
## main #759 +/- ##
==========================================
+ Coverage 88.26% 88.77% +0.51%
==========================================
Files 123 123
Lines 21270 20788 -482
==========================================
- Hits 18773 18454 -319
+ Misses 2497 2334 -163
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
vmoens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Minor question: Do we need both cuda 11.6 and 11.7?
|
@yohann-benchetrit also let's avoid to link to internal tasks since this is an open-source repo |
I think it's good to have both as the two options are offered for Torch Windows install |
8c0a4b3 to
52d67f4
Compare
52d67f4 to
bdfd342
Compare
Description
binary_win_wheeljob to CircleCIbuildworkflow for:cu_version=cpu,cu116,cu117python_version=3.7,3.8,3.9,3.10Motivation and Context
TorchRL is currently built and tested for OsX and Linux only and there is some demand for a windows built.
Types of changes
packaging/windows(slightly modified from Torchvision's ones)Checklist
Go over all the following points, and put an
xin all the boxes that apply.