Skip to content

Conversation

@vmoens
Copy link
Collaborator

@vmoens vmoens commented Dec 31, 2022

Description

Improves the error messages or remove unreadable error messages during program closure as pointed in #762.
To test the feature with envs and collectors: error messages after this PR should be more readable in these two cases:

python -c """
import gym
from torchrl.envs.libs.gym import GymWrapper

gym_env = gym.make('CartPole-v1')
env = GymWrapper(gym_env)                        
"""                                              

and for collectors:

MAX_IDLE_COUNT=10 python -c """
import gym
from torchrl.envs.libs.gym import GymWrapper
from torchrl.envs import EnvCreator, ParallelEnv
gym_env = gym.make('CartPole-v1')
env = ParallelEnv(4, EnvCreator(lambda: GymWrapper(gym_env)))
from torchrl.collectors.collectors import RandomPolicy, MultiaSyncDataCollector
c = MultiaSyncDataCollector([env, env], RandomPolicy(env.action_spec))
"""

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 31, 2022
@vmoens vmoens added the quality code quality label Dec 31, 2022
@vmoens vmoens merged commit 00424b7 into main Jan 1, 2023
@vmoens vmoens deleted the closing_error_message branch January 1, 2023 07:17
vmoens added a commit that referenced this pull request Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. quality code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants