Skip to content

[Refactor] Simplify FlattenObservation default kwargs #805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 9, 2023
Merged

[Refactor] Simplify FlattenObservation default kwargs #805

merged 2 commits into from
Jan 9, 2023

Conversation

@vmoens
Copy link
Collaborator

@vmoens vmoens commented Jan 9, 2023 •
edited
Loading

Description

FlattenObservation has default first and last dim 0 and -3 which may not be intuitive. Let's remove the defaults.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 9, 2023
@vmoens vmoens added bc breaking backward compatibility breaking change Refactoring Refactoring of an existing feature labels Jan 9, 2023
@vmoens vmoens merged commit e23151b into main Jan 9, 2023
@vmoens vmoens deleted the fix_default_flatten branch January 9, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bc breaking backward compatibility breaking change CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Refactoring Refactoring of an existing feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vmoens @facebook-github-bot