Skip to content

Conversation

@robandpdx
Copy link
Contributor

Description

Migrate unit tests from CircleCI to GitHub Actions

Motivation and Context

Why is this change required? What problem does it solve?
The direction is to move unit tests to GitHub Actions.

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

No change to functionality.

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • [x ] I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

@facebook-github-bot
Copy link

Hi @robandpdx!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@robandpdx robandpdx changed the title Unittests gha Unit tests GitHub Actions Jan 12, 2023
@robandpdx robandpdx changed the title Unit tests GitHub Actions Unit test workflow using GitHub Actions Jan 12, 2023
@robandpdx robandpdx force-pushed the unittests-gha branch 2 times, most recently from 00cdec8 to 7cf198f Compare January 18, 2023 19:54
@robandpdx robandpdx changed the title Unit test workflow using GitHub Actions [WIP] Unit test workflow using GitHub Actions Jan 18, 2023
@DanilBaibak
Copy link
Contributor

Hi @vmoens! @robandpdx works on migration the "Unit-tests on Linux GPU" job to GitHub Actions. There is a problem with the smoke test smoke_test_deps.py::test_dm_control: ImportError: Cannot initialize a headless EGL. Did you face such issue before?

@vmoens
Copy link
Collaborator

vmoens commented Jan 20, 2023

Hi @vmoens! @robandpdx works on migration the "Unit-tests on Linux GPU" job to GitHub Actions. There is a problem with the smoke test smoke_test_deps.py::test_dm_control: ImportError: Cannot initialize a headless EGL. Did you face such issue before?

It's a common issue with dm_control and related. We provide some solutions here:
https://pytorch.org/rl/reference/generated/knowledge_base/MUJOCO_INSTALLATION.html#installing-mujoco

@robandpdx robandpdx force-pushed the unittests-gha branch 3 times, most recently from beb27a9 to 92bceb8 Compare January 31, 2023 17:23
@robandpdx robandpdx changed the title [WIP] Unit test workflow using GitHub Actions CPU nit test workflow using GitHub Actions Jan 31, 2023
@robandpdx robandpdx changed the title CPU nit test workflow using GitHub Actions CPU unit test workflow using GitHub Actions Jan 31, 2023
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 31, 2023
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@robandpdx robandpdx changed the title CPU unit test workflow using GitHub Actions Linux CPU unit test workflow using GitHub Actions Jan 31, 2023
@seemethere seemethere merged commit 4456db0 into pytorch:main Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants