Windows 10 - JAVA_HOME "not set properly"

[therealjjj77]

Context

Starting torchserve to serve the model fails. Archiving wasn't a problem.

(venv) C:\Users\Jerr\AppData\Roaming\JetBrains\PyCharmCE2020.3\scratches\torch-serve>torchserve.exe --model-store model-store
java not found, please make sure JAVA_HOME is set properly.

But it shouldn't be an issue as it is set in env variables:

(venv) C:\Users\Jerr\AppData\Roaming\JetBrains\PyCharmCE2020.3\scratches\torch-serve\serve>java -version
openjdk version "11.0.2" 2019-01-15
OpenJDK Runtime Environment 18.9 (build 11.0.2+9)
OpenJDK 64-Bit Server VM 18.9 (build 11.0.2+9, mixed mode)

I am installing torchserve on my cpu in order to test why my model keeps crashing the Google Cloud Console when setup as a Docker image.

• torchserve version: 0.4.2

• torch-model-archiver version:0.4.2b20211009

• torch version: 1.9.0+cu111

• torchvision version [if any]:0.10.0+cu111

• torchtext version [if any]:0.10.0

• torchaudio version [if any]:0.9.0

• java version: openjdk version "11.0.2" 2019-01-15
  OpenJDK Runtime Environment 18.9 (build 11.0.2+9)
  OpenJDK 64-Bit Server VM 18.9 (build 11.0.2+9, mixed mode)
  nodejs(npm) version: 6.14.8
  Python Version: 3.7
  Environment: PycharmCE2020.3

• Operating System and version: Windows 10 Home 64

Your Environment

• Installed using source? [yes/no]: no
• Are you planning to deploy it using docker container? [yes/no]: no(actually, I will later, but now just trying to get torchserve up and running on my CPU to troubleshoot why it keeps crashing in Google Cloud Console)
• Is it a CPU or GPU environment?: GPU
• Using a default/custom handler? [If possible upload/share custom handler/model]: Yes, but didn't get that far, yet.
• What kind of model is it e.g. vision, text, audio?: N/A - didn't get that far
• Are you planning to use local models from model-store or public url being used e.g. from S3 bucket etc.?
  [If public url then provide link.]: N/A
• Provide config.properties, logs [ts.log] and parameters used for model registration/update APIs: N/A
• Link to your project [if any]: N/A

Expected Behavior

running torchserve --start --ncs --model-store ..\model-store --models conv1dppm.mar results in java not found error.

Current Behavior

See above.

Possible Solution

Steps to Reproduce

Steps were followed from https://github.com/pytorch/serve/blob/master/docs/torchserve_on_win_native.md except in Pycharm terminal as Administrator. (By the way, I tried Anaconda, but that ran into a whole slew of other issues along the way and also failed to install.)

See below for steps and log:

(venv) C:\Users\Jerr\AppData\Roaming\JetBrains\PyCharmCE2020.3\scratches\torch-serve\serve>python .\ts_scripts\install_dependencies.py
'conda' is not recognized as an internal or external command,
operable program or batch file.
Requirement already satisfied: pillow==8.3.2 in c:\users\jerr\pycharmprojects\pythonproject1\venv\lib\site-packages (from -r requirements/torch_windows.txt (line 1)) (8.3.2)
Requirement already satisfied: torch==1.9.0 in c:\users\jerr\pycharmprojects\pythonproject1\venv\lib\site-packages (from -r requirements/torch_windows.txt (line 2)) (1.9.0+cu111)
Requirement already satisfied: torchvision==0.10.0 in c:\users\jerr\pycharmprojects\pythonproject1\venv\lib\site-packages (from -r requirements/torch_windows.txt (line 3)) (0.10.0+cu111)
Requirement already satisfied: torchtext==0.10.0 in c:\users\jerr\pycharmprojects\pythonproject1\venv\lib\site-packages (from -r requirements/torch_windows.txt (line 4)) (0.10.0)
Requirement already satisfied: torchaudio==0.9.0 in c:\users\jerr\pycharmprojects\pythonproject1\venv\lib\site-packages (from -r requirements/torch_windows.txt (line 5)) (0.9.0)
Requirement already satisfied: typing-extensions in c:\users\jerr\pycharmprojects\pythonproject1\venv\lib\site-packages (from torch==1.9.0->-r requirements/torch_windows.txt (line 2)) (3.7.4.3)
Requirement already satisfied: numpy in c:\users\jerr\pycharmprojects\pythonproject1\venv\lib\site-packages (from torchvision==0.10.0->-r requirements/torch_windows.txt (line 3)) (1.19.3)
Requirement already satisfied: requests in c:\users\jerr\pycharmprojects\pythonproject1\venv\lib\site-packages (from torchtext==0.10.0->-r requirements/torch_windows.txt (line 4)) (2.26.0)
Requirement already satisfied: tqdm in c:\users\jerr\pycharmprojects\pythonproject1\venv\lib\site-packages (from torchtext==0.10.0->-r requirements/torch_windows.txt (line 4)) (4.56.0)
Requirement already satisfied: charset-normalizer~=2.0.0 in c:\users\jerr\pycharmprojects\pythonproject1\venv\lib\site-packages (from requests->torchtext==0.10.0->-r requirements/torch_windows.txt (line 4)) (2.0.6)
Requirement already satisfied: urllib3<1.27,>=1.21.1 in c:\users\jerr\pycharmprojects\pythonproject1\venv\lib\site-packages (from requests->torchtext==0.10.0->-r requirements/torch_windows.txt (line 4)) (1.24.2)
Requirement already satisfied: idna<4,>=2.5 in c:\users\jerr\pycharmprojects\pythonproject1\venv\lib\site-packages (from requests->torchtext==0.10.0->-r requirements/torch_windows.txt (line 4)) (2.10)
Requirement already satisfied: certifi>=2017.4.17 in c:\users\jerr\pycharmprojects\pythonproject1\venv\lib\site-packages (from requests->torchtext==0.10.0->-r requirements/torch_windows.txt (line 4)) (2020.12.5)
Requirement already satisfied: pip in c:\users\jerr\pycharmprojects\pythonproject1\venv\lib\site-packages (21.2.4)
Requirement already satisfied: setuptools in c:\users\jerr\pycharmprojects\pythonproject1\venv\lib\site-packages (58.2.0)
Ignoring numpy: markers 'sys_platform != "win32"' don't match your environment
Requirement already satisfied: future in c:\users\jerr\pycharmprojects\pythonproject1\venv\lib\site-packages (from -r requirements\common.txt (line 1)) (0.18.2)
Requirement already satisfied: psutil in c:\users\jerr\pycharmprojects\pythonproject1\venv\lib\site-packages (from -r requirements\common.txt (line 2)) (5.8.0)
Requirement already satisfied: wheel in c:\users\jerr\pycharmprojects\pythonproject1\venv\lib\site-packages (from -r requirements\common.txt (line 3)) (0.37.0)
Requirement already satisfied: requests in c:\users\jerr\pycharmprojects\pythonproject1\venv\lib\site-packages (from -r requirements\common.txt (line 4)) (2.26.0)
Requirement already satisfied: sentencepiece in c:\users\jerr\pycharmprojects\pythonproject1\venv\lib\site-packages (from -r requirements\common.txt (line 5)) (0.1.96)
Requirement already satisfied: pillow==8.3.2 in c:\users\jerr\pycharmprojects\pythonproject1\venv\lib\site-packages (from -r requirements\common.txt (line 6)) (8.3.2)
Requirement already satisfied: captum in c:\users\jerr\pycharmprojects\pythonproject1\venv\lib\site-packages (from -r requirements\common.txt (line 7)) (0.4.0)
Requirement already satisfied: packaging in c:\users\jerr\pycharmprojects\pythonproject1\venv\lib\site-packages (from -r requirements\common.txt (line 8)) (21.0)
Requirement already satisfied: numpy==1.19.3 in c:\users\jerr\pycharmprojects\pythonproject1\venv\lib\site-packages (from -r requirements\common.txt (line 10)) (1.19.3)
Requirement already satisfied: urllib3<1.27,>=1.21.1 in c:\users\jerr\pycharmprojects\pythonproject1\venv\lib\site-packages (from requests->-r requirements\common.txt (line 4)) (1.24.2)
Requirement already satisfied: certifi>=2017.4.17 in c:\users\jerr\pycharmprojects\pythonproject1\venv\lib\site-packages (from requests->-r requirements\common.txt (line 4)) (2020.12.5)
Requirement already satisfied: charset-normalizer~=2.0.0 in c:\users\jerr\pycharmprojects\pythonproject1\venv\lib\site-packages (from requests->-r requirements\common.txt (line 4)) (2.0.6)
Requirement already satisfied: idna<4,>=2.5 in c:\users\jerr\pycharmprojects\pythonproject1\venv\lib\site-packages (from requests->-r requirements\common.txt (line 4)) (2.10)
Requirement already satisfied: matplotlib in c:\users\jerr\pycharmprojects\pythonproject1\venv\lib\site-packages (from captum->-r requirements\common.txt (line 7)) (3.3.3)
Requirement already satisfied: torch>=1.2 in c:\users\jerr\pycharmprojects\pythonproject1\venv\lib\site-packages (from captum->-r requirements\common.txt (line 7)) (1.9.0+cu111)
Requirement already satisfied: pyparsing>=2.0.2 in c:\users\jerr\pycharmprojects\pythonproject1\venv\lib\site-packages (from packaging->-r requirements\common.txt (line 8)) (2.4.7)
Requirement already satisfied: typing-extensions in c:\users\jerr\pycharmprojects\pythonproject1\venv\lib\site-packages (from torch>=1.2->captum->-r requirements\common.txt (line 7)) (3.7.4.3)
Requirement already satisfied: cycler>=0.10 in c:\users\jerr\pycharmprojects\pythonproject1\venv\lib\site-packages (from matplotlib->captum->-r requirements\common.txt (line 7)) (0.10.0)
Requirement already satisfied: kiwisolver>=1.0.1 in c:\users\jerr\pycharmprojects\pythonproject1\venv\lib\site-packages (from matplotlib->captum->-r requirements\common.txt (line 7)) (1.3.1)
Requirement already satisfied: python-dateutil>=2.1 in c:\users\jerr\pycharmprojects\pythonproject1\venv\lib\site-packages (from matplotlib->captum->-r requirements\common.txt (line 7)) (2.8.1)
Requirement already satisfied: six in c:\users\jerr\pycharmprojects\pythonproject1\venv\lib\site-packages (from cycler>=0.10->matplotlib->captum->-r requirements\common.txt (line 7)) (1.15.0)

(venv) C:\Users\Jerr\AppData\Roaming\JetBrains\PyCharmCE2020.3\scratches\torch-serve\serve>pip install torchserve torch-model-archiver
Collecting torchserve
  Using cached torchserve-0.4.2-py2.py3-none-any.whl (18.1 MB)
Requirement already satisfied: torch-model-archiver in c:\users\jerr\pycharmprojects\pythonproject1\venv\lib\site-packages (0.4.2b20211009)
Requirement already satisfied: packaging in c:\users\jerr\pycharmprojects\pythonproject1\venv\lib\site-packages (from torchserve) (21.0)
Requirement already satisfied: psutil in c:\users\jerr\pycharmprojects\pythonproject1\venv\lib\site-packages (from torchserve) (5.8.0)
Requirement already satisfied: Pillow in c:\users\jerr\pycharmprojects\pythonproject1\venv\lib\site-packages (from torchserve) (8.3.2)
Requirement already satisfied: future in c:\users\jerr\pycharmprojects\pythonproject1\venv\lib\site-packages (from torchserve) (0.18.2)
Requirement already satisfied: enum-compat in c:\users\jerr\pycharmprojects\pythonproject1\venv\lib\site-packages (from torch-model-archiver) (0.0.3)
Requirement already satisfied: pyparsing>=2.0.2 in c:\users\jerr\pycharmprojects\pythonproject1\venv\lib\site-packages (from packaging->torchserve) (2.4.7)
Installing collected packages: torchserve
Successfully installed torchserve-0.4.2

(venv) C:\Users\Jerr\AppData\Roaming\JetBrains\PyCharmCE2020.3\scratches\torch-serve\serve>torchserve --start --ncs --model-store ..\model-store --models conv1dppm.mar
java not found, please make sure JAVA_HOME is set properly.

(venv) C:\Users\Jerr\AppData\Roaming\JetBrains\PyCharmCE2020.3\scratches\torch-serve\serve>java -version
openjdk version "11.0.2" 2019-01-15
OpenJDK Runtime Environment 18.9 (build 11.0.2+9)
OpenJDK 64-Bit Server VM 18.9 (build 11.0.2+9, mixed mode)

JAVA_HOME is set already and points to both the jdk and bin folder inside.

(venv) C:\Users\Jerr\AppData\Roaming\JetBrains\PyCharmCE2020.3\scratches\torch-serve\serve>echo %JAVA_HOME%
C:\Java\jdk-11.0.2;C:\Java\jdk-11.0.2\bin;C:\Users\Jerr\AppData\Roaming\JetBrains\PyCharmCE2020.3\scratches\torch-serve\jdk-11.0.2;C:\Users\Jerr\AppData\Roaming\JetBrains\PyCharmCE2020.3\scratches\torch-serve\jdk-11.0.2\bin;

[therealjjj77]

I managed to get Anaconda working to the point that torchserve was installed. The issue was the Anaconda folder needed the permissions adjusted in order to update everything via Pip without the --user command.

Anyway, Anaconda is giving back the same error:

(base) C:\Anaconda_work\torch-serve\serve>torchserve --start --ncs --model-store ..\model-store --models conv1dppm.mar
java not found, please make sure JAVA_HOME is set properly.

Java path and JAVA_HOME variables are set:

(base) C:\Anaconda_work\torch-serve\serve>java --version
openjdk 11.0.2 2019-01-15
OpenJDK Runtime Environment 18.9 (build 11.0.2+9)
OpenJDK 64-Bit Server VM 18.9 (build 11.0.2+9, mixed mode)

(base) C:\Anaconda_work\torch-serve\serve>echo %JAVA_HOME%
C:\Java\jdk-11.0.2;C:\Java\jdk-11.0.2\bin;C:\Users\Jerr\AppData\Roaming\JetBrains\PyCharmCE2020.3\scratches\torch-serve\jdk-11.0.2;C:\Users\Jerr\AppData\Roaming\JetBrains\PyCharmCE2020.3\scratches\torch-serve\jdk-11.0.2\bin;

[therealjjj77]

I updated the JAVA_HOME variable to be only C:\Java\jdk-11.0.2. Rebooted and still getting the same error in APP and Pycharm prompt. I see the error comes from this file around line 165:
https://github.com/pytorch/serve/blob/master/ts/model_server.py
I might try to build from source next to see if I can identify where the issue is coming from.

[therealjjj77]

Figured out the problem. First, JAVA_HOME shouldn't have multiple paths setup. Second, if you setup multiple paths in JAVA_HOME and then remove the extra paths, there will still be a semi-colon added by Windows environmental variables to delineate multiple entries that causes the error. I.e. C:\Java\jdk-11.0.2;. To fix it, delete any JAVA_HOME variables and then make a(singular) new variable and ensure there is no semi-colon at the end. Exit and reenter command prompt for the change to take effect.