Skip to content

Conversation

@tcbegley
Copy link
Contributor

Description

Since pytorch/rl#738 has been merged, we can now clean up these patch imports that were left to maintain compatibility.

I've run the TorchRL tests locally against this branch to make sure nothing is broken.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 16, 2022
@tcbegley tcbegley changed the title Remove prototype import patch [Refactor] Remove prototype import patch Dec 16, 2022
Copy link
Collaborator

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmoens vmoens added the Refactor Refactoring code - not a new feature label Jan 5, 2023
@vmoens vmoens merged commit e453b2b into main Jan 5, 2023
@vmoens vmoens deleted the remove-prototype-import branch January 5, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Refactor Refactoring code - not a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants